Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: update benchmark CI test indicator in README #35945

Merged
merged 1 commit into from Nov 5, 2020
Merged

doc: update benchmark CI test indicator in README #35945

merged 1 commit into from Nov 5, 2020

Conversation

Trott
Copy link
Member

@Trott Trott commented Nov 3, 2020

As of c7627da, benchmark tests are run
in CI, but the README was not updated to indicate this.

Checklist

@nodejs-github-bot nodejs-github-bot added the test Issues and PRs related to the tests. label Nov 3, 2020
@Trott
doc: update benchmark CI test indicator in README
c575aec 
As of c7627da, benchmark tests are run
in CI, but the README was not updated to indicate this.

PR-URL: nodejs#35945
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@Trott
Copy link
Member Author

Trott commented Nov 5, 2020

Landed in c575aec

@Trott Trott merged commit c575aec into nodejs:master Nov 5, 2020
@Trott Trott deleted the bm-test branch November 5, 2020 13:53
danielleadams pushed a commit that referenced this pull request Nov 9, 2020
@Trott @danielleadams
doc: update benchmark CI test indicator in README
6d56ba0 
As of c7627da, benchmark tests are run
in CI, but the README was not updated to indicate this.

PR-URL: #35945
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@danielleadams danielleadams mentioned this pull request Nov 9, 2020
Merged
BethGriggs pushed a commit that referenced this pull request Dec 9, 2020
@Trott @BethGriggs
doc: update benchmark CI test indicator in README
7f0843b 
As of c7627da, benchmark tests are run
in CI, but the README was not updated to indicate this.

PR-URL: #35945
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
BethGriggs pushed a commit that referenced this pull request Dec 10, 2020
@Trott @BethGriggs
doc: update benchmark CI test indicator in README
cf58d2f 
As of c7627da, benchmark tests are run
in CI, but the README was not updated to indicate this.

PR-URL: #35945
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@BethGriggs BethGriggs mentioned this pull request Dec 10, 2020
Merged
BethGriggs pushed a commit that referenced this pull request Dec 15, 2020
@Trott @BethGriggs
doc: update benchmark CI test indicator in README
773685c 
As of c7627da, benchmark tests are run
in CI, but the README was not updated to indicate this.

PR-URL: #35945
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lpinca lpinca lpinca approved these changes

@watilde watilde watilde approved these changes

@richardlau richardlau richardlau approved these changes

Assignees
No one assigned
Labels
test Issues and PRs related to the tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@Trott @lpinca @watilde @richardlau @nodejs-github-bot