Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

http2: Fix error stream write followed by destroy #35951

Merged
merged 1 commit into from Nov 6, 2020
Merged

http2: Fix error stream write followed by destroy #35951

merged 1 commit into from Nov 6, 2020

Conversation

davedoesdev
Copy link
Contributor

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

Without the fix, the test fails with:

node:internal/http2/core:179
  debugStream(stream[kID], stream[kSession][kType], message, ...args);
                                           ^

TypeError: Cannot read property 'Symbol(type)' of undefined
    at debugStreamObj (node:internal/http2/core:179:44)
    at node:internal/http2/core:2041:7
    at processTicksAndRejections (node:internal/process/task_queues:75:11)

@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/http2
  • @nodejs/net

@nodejs-github-bot nodejs-github-bot added the http2 Issues or PRs related to the http2 subsystem. label Nov 4, 2020
mcollina
mcollina approved these changes Nov 4, 2020
View reviewed changes
Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

rickyes
rickyes approved these changes Nov 5, 2020
View reviewed changes
test/parallel/test-http2-destroy-after-write.js Outdated
const server = http2.createServer();

server.on('session', function(session) {
session.on('stream', function(stream) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
session.on('stream', function(stream) {
session.on('stream', common.mustCall(function(stream) {

test/parallel/test-http2-destroy-after-write.js Outdated

const server = http2.createServer();

server.on('session', function(session) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
server.on('session', function(session) {
server.on('session', common.mustCall(function(session) {

@mcollina mcollina added the request-ci Add this label to start a Jenkins CI on a PR. label Nov 5, 2020
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Nov 5, 2020
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/34074/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/34075/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/34084/

@mcollina
Copy link
Member

mcollina commented Nov 5, 2020

There seems to be a problem on ARM :(

@davedoesdev
Copy link
Contributor Author

There seems to be a problem on ARM :(

14:22:04 + git checkout -f refs/remotes/jenkins_tmp
14:22:04 fatal: Unable to create '/home/iojs/build/workspace/node-test-binary-arm/.git/index.lock': File exists.
14:22:04 
14:22:04 Another git process seems to be running in this repository,
...
14:22:07 mkdir: cannot create directory ‘out/junit’: No such file or directory

@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Nov 6, 2020 •
edited by Trott

CI: https://ci.nodejs.org/job/node-test-pull-request/34112/ ✅

@richardlau
Copy link
Member

There seems to be a problem on ARM :(

14:22:04 + git checkout -f refs/remotes/jenkins_tmp
14:22:04 fatal: Unable to create '/home/iojs/build/workspace/node-test-binary-arm/.git/index.lock': File exists.
14:22:04 
14:22:04 Another git process seems to be running in this repository,
...
14:22:07 mkdir: cannot create directory ‘out/junit’: No such file or directory

Should have been fixed by nodejs/build#2475, I've resumed the last CI run.

@davedoesdev @Trott
http2: fix error stream write followed by destroy
1fd7d8e 
PR-URL: #35951
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Ricky Zhou <0x19951125@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
@Trott Trott merged commit 1fd7d8e into nodejs:master Nov 6, 2020
@Trott
Copy link
Member

Trott commented Nov 6, 2020

Landed in 1fd7d8e

danielleadams pushed a commit that referenced this pull request Nov 9, 2020
@davedoesdev @danielleadams
http2: fix error stream write followed by destroy
1dd744a 
PR-URL: #35951
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Ricky Zhou <0x19951125@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
@danielleadams danielleadams mentioned this pull request Nov 9, 2020
Merged
BethGriggs pushed a commit that referenced this pull request Dec 9, 2020
@davedoesdev @BethGriggs
http2: fix error stream write followed by destroy
b03ea21 
PR-URL: #35951
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Ricky Zhou <0x19951125@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
BethGriggs pushed a commit that referenced this pull request Dec 10, 2020
@davedoesdev @BethGriggs
http2: fix error stream write followed by destroy
1a520e5 
PR-URL: #35951
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Ricky Zhou <0x19951125@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
@BethGriggs BethGriggs mentioned this pull request Dec 10, 2020
Merged
BethGriggs pushed a commit that referenced this pull request Dec 15, 2020
@davedoesdev @BethGriggs
http2: fix error stream write followed by destroy
92bd7b5 
PR-URL: #35951
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Ricky Zhou <0x19951125@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mcollina mcollina mcollina approved these changes

@Trott Trott Trott approved these changes

@rickyes rickyes rickyes approved these changes

@crypt096 crypt096 crypt096 approved these changes

Assignees
No one assigned
Labels
http2 Issues or PRs related to the http2 subsystem.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@davedoesdev @nodejs-github-bot @mcollina @richardlau @Trott @rickyes @crypt096