tools: fix config serialization w/ long strings #35982
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
So that “config.gypi” gets serialized correctly in cases such as:
./configure --v8-options='--write-protect-code-memory \
--wasm-write-protect-code-memory'
Where “v8_options” gets prettyprinted into a multiline string.
nodejs-github-bot
added
the
build
|
@nodejs/python @joyeecheung @devsnek @danbev |
danbev
approved these changes
Nov 10, 2020
joyeecheung
approved these changes
Nov 11, 2020
richardlau
approved these changes
Nov 11, 2020
richardlau
added
request-ci
github-actions
bot
removed
the
request-ci
This comment has been minimized.
This comment has been minimized.
Trott
approved these changes
Nov 12, 2020
richardlau
added
the
commit-queue
github-actions
bot
removed
the
commit-queue
|
Landed in 35274cb...f6ada62 |
nodejs-github-bot
pushed a commit
that referenced
this pull request
Nov 12, 2020
So that “config.gypi” gets serialized correctly in cases such as:
./configure --v8-options='--write-protect-code-memory \
--wasm-write-protect-code-memory'
Where “v8_options” gets prettyprinted into a multiline string.
PR-URL: #35982
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
codebytere
pushed a commit
that referenced
this pull request
Nov 22, 2020
So that “config.gypi” gets serialized correctly in cases such as:
./configure --v8-options='--write-protect-code-memory \
--wasm-write-protect-code-memory'
Where “v8_options” gets prettyprinted into a multiline string.
PR-URL: #35982
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Merged
BethGriggs
pushed a commit
that referenced
this pull request
Dec 9, 2020
So that “config.gypi” gets serialized correctly in cases such as:
./configure --v8-options='--write-protect-code-memory \
--wasm-write-protect-code-memory'
Where “v8_options” gets prettyprinted into a multiline string.
PR-URL: #35982
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
BethGriggs
pushed a commit
that referenced
this pull request
Dec 10, 2020
So that “config.gypi” gets serialized correctly in cases such as:
./configure --v8-options='--write-protect-code-memory \
--wasm-write-protect-code-memory'
Where “v8_options” gets prettyprinted into a multiline string.
PR-URL: #35982
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Merged
BethGriggs
pushed a commit
that referenced
this pull request
Dec 15, 2020
So that “config.gypi” gets serialized correctly in cases such as:
./configure --v8-options='--write-protect-code-memory \
--wasm-write-protect-code-memory'
Where “v8_options” gets prettyprinted into a multiline string.
PR-URL: #35982
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So that “config.gypi” gets serialized correctly in cases such as:
Where “v8_options” gets prettyprinted into a multiline string.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes