Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: improve test-stream-duplex-readable-end #36056

Merged
merged 1 commit into from Nov 14, 2020
Merged

test: improve test-stream-duplex-readable-end #36056

merged 1 commit into from Nov 14, 2020

Commits on Nov 14, 2020

  1. test: improve test-stream-duplex-readable-end 

    - Remove unneeded listener for the `'error'` event.
- Use `common.mustCall()`.
- Verify that the `src` stream gets paused.

PR-URL: nodejs#36056
Refs: nodejs#35941
Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Ricky Zhou <0x19951125@gmail.com>
    @lpinca
    lpinca committed Nov 14, 2020
    Copy the full SHA
    d5e4e19 View commit details
    Browse the repository at this point in the history