Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fs: remove experimental from promises.rmdir recursive #36131

Closed
wants to merge 1 commit into from

Conversation

andersk
Copy link
Contributor

@andersk andersk commented Nov 16, 2020

This was missed in commit 35b17d9.

Refs: #34278
Refs: #35171

Checklist

This was missed in commit 35b17d9.

Refs: nodejs#34278
Refs: nodejs#35171

Signed-off-by: Anders Kaseorg <andersk@mit.edu>
@nodejs-github-bot nodejs-github-bot added doc Issues and PRs related to the documentations. fs Issues and PRs related to the fs subsystem / file system. labels Nov 16, 2020
@benjamingr
Copy link
Member

I think the YAML immediately above needs to be updated, the changes: bit with the fact it's no longer experimental like other APIs

@andersk
Copy link
Contributor Author

andersk commented Nov 16, 2020

@benjamingr To be clear, you’re suggesting the addition of a changes entry like “Recursive removal is no longer experimental” for the following version?

No such entries were added in #35171, and I don’t think they should be necessary. The decision to remove experimental status means that we relinquish the right to quietly make backward incompatible changes. For a feature that has not had any previous backward incompatible changes, this relinquishment applies retroactively to all versions where it exists, and the result is the same as if the feature had never been experimental at all.

If my reasoning is incorrect, let me know and I’ll be happy to add them.

@Trott Trott requested a review from bcoe November 16, 2020 14:49
@bcoe
Copy link
Contributor

bcoe commented Nov 16, 2020

@andersk, @Trott, @benjamingr not sure if we need to add the yaml entry, as there are no functional changes (might have been an oversight on my part).

@nodejs-github-bot

This comment has been minimized.

@nodejs-github-bot
Copy link
Collaborator

@bcoe bcoe added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Nov 17, 2020
@aduh95 aduh95 added the commit-queue Add this label to land a pull request using GitHub Actions. label Nov 18, 2020
@github-actions github-actions bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Nov 18, 2020
@github-actions
Copy link
Contributor

Commit Queue failed
- Loading data for nodejs/node/pull/36131
✔  Done loading data for nodejs/node/pull/36131
----------------------------------- PR info ------------------------------------
Title      fs: remove experimental from promises.rmdir recursive (#36131)
Author     Anders Kaseorg  (@andersk, first-time contributor)
Branch     andersk:fs-promises-rmdir-recursive -> nodejs:master
Labels     author ready, doc, fs
Commits    1
 - fs: remove experimental from promises.rmdir recursive
Committers 1
 - Anders Kaseorg 
PR-URL: https://github.com/nodejs/node/pull/36131
Refs: https://github.com/nodejs/node/issues/34278
Refs: https://github.com/nodejs/node/pull/35171
Reviewed-By: Benjamin Gruenbaum 
Reviewed-By: Rich Trott 
Reviewed-By: Ben Coe 
Reviewed-By: Luigi Pinca 
Reviewed-By: James M Snell 
------------------------------ Generated metadata ------------------------------
PR-URL: https://github.com/nodejs/node/pull/36131
Refs: https://github.com/nodejs/node/issues/34278
Refs: https://github.com/nodejs/node/pull/35171
Reviewed-By: Benjamin Gruenbaum 
Reviewed-By: Rich Trott 
Reviewed-By: Ben Coe 
Reviewed-By: Luigi Pinca 
Reviewed-By: James M Snell 
--------------------------------------------------------------------------------
   ✖  GitHub CI is still running
   ℹ  Doc-only changes
   ℹ  This PR was created on Mon, 16 Nov 2020 04:28:56 GMT
   ✔  Approvals: 5
   ✔  - Benjamin Gruenbaum (@benjamingr): https://github.com/nodejs/node/pull/36131#pullrequestreview-531104541
   ✔  - Rich Trott (@Trott) (TSC): https://github.com/nodejs/node/pull/36131#pullrequestreview-531392319
   ✔  - Ben Coe (@bcoe): https://github.com/nodejs/node/pull/36131#pullrequestreview-531473309
   ✔  - Luigi Pinca (@lpinca): https://github.com/nodejs/node/pull/36131#pullrequestreview-531678115
   ✔  - James M Snell (@jasnell) (TSC): https://github.com/nodejs/node/pull/36131#pullrequestreview-532649062
--------------------------------------------------------------------------------
   ✔  Aborted `git node land` session in /home/runner/work/node/node/.ncu
https://github.com/nodejs/node/actions/runs/370844246

@github-actions github-actions bot added the commit-queue-failed An error occurred while landing this pull request using GitHub Actions. label Nov 18, 2020
@aduh95 aduh95 added commit-queue Add this label to land a pull request using GitHub Actions. and removed commit-queue-failed An error occurred while landing this pull request using GitHub Actions. labels Nov 19, 2020
@github-actions github-actions bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Nov 19, 2020
@github-actions
Copy link
Contributor

Landed in d7bfa58...275aa68

@github-actions github-actions bot closed this Nov 19, 2020
nodejs-github-bot pushed a commit that referenced this pull request Nov 19, 2020
This was missed in commit 35b17d9.

Refs: #34278
Refs: #35171

Signed-off-by: Anders Kaseorg <andersk@mit.edu>

PR-URL: #36131
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Ben Coe <bencoe@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
codebytere pushed a commit that referenced this pull request Nov 22, 2020
This was missed in commit 35b17d9.

Refs: #34278
Refs: #35171

Signed-off-by: Anders Kaseorg <andersk@mit.edu>

PR-URL: #36131
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Ben Coe <bencoe@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@codebytere codebytere mentioned this pull request Nov 22, 2020
BethGriggs pushed a commit that referenced this pull request Dec 10, 2020
This was missed in commit 35b17d9.

Refs: #34278
Refs: #35171

Signed-off-by: Anders Kaseorg <andersk@mit.edu>

PR-URL: #36131
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Ben Coe <bencoe@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
BethGriggs pushed a commit that referenced this pull request Dec 10, 2020
This was missed in commit 35b17d9.

Refs: #34278
Refs: #35171

Signed-off-by: Anders Kaseorg <andersk@mit.edu>

PR-URL: #36131
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Ben Coe <bencoe@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@BethGriggs BethGriggs mentioned this pull request Dec 10, 2020
BethGriggs pushed a commit that referenced this pull request Dec 15, 2020
This was missed in commit 35b17d9.

Refs: #34278
Refs: #35171

Signed-off-by: Anders Kaseorg <andersk@mit.edu>

PR-URL: #36131
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Ben Coe <bencoe@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. doc Issues and PRs related to the documentations. fs Issues and PRs related to the fs subsystem / file system.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

8 participants