Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: de-emphasize wrapping in napi_define_class #36159

Closed
wants to merge 2 commits into from
Closed

doc: de-emphasize wrapping in napi_define_class #36159

wants to merge 2 commits into from

Commits on Nov 18, 2020

  1. doc: de-emphasize wrapping in napi_define_class 

    Change the documentation for `napi_define_class` in such a way that
it mentions wrapping C++ class instances as a possible use for the API,
rather than making the assumption that it is the use case for the API.

Signed-off-by: Gabriel Schulhof <gabriel.schulhof@intel.com>
Fixes: nodejs#36150
    Gabriel Schulhof committed Nov 18, 2020
    Copy the full SHA
    1d921bc View commit details
    Browse the repository at this point in the history

Commits on Nov 19, 2020

  1. Apply suggestions from code review 

    Co-authored-by: Rich Trott <rtrott@gmail.com>
    @Trott
    Gabriel Schulhof and Trott committed Nov 19, 2020
    Copy the full SHA
    9f2d92a View commit details
    Browse the repository at this point in the history