Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

n-api: clean up binding creation #36170

Closed
wants to merge 1 commit into from
Closed

n-api: clean up binding creation #36170

wants to merge 1 commit into from

Commits on Nov 19, 2020

  1. n-api: clean up binding creation 

    * Remove dead code for `GetterCallbackWrapper` and
  `SetterCallbackWrapper`.
* Factor out creation of new `v8::Function`s.
* Factor out creation of new `v8::FunctionTemplate`s.
* Turn `CallbackBundle` into a class, internalizing creation of new
  instances and garbage collection.

Signed-off-by: Gabriel Schulhof <gabriel.schulhof@intel.com>
PR-URL: nodejs#36170
    Gabriel Schulhof committed Nov 19, 2020
    Copy the full SHA
    26ee991 View commit details
    Browse the repository at this point in the history