Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

n-api: fix test_async_context warnings #36171

Closed
wants to merge 1 commit into from

Conversation

gabrielschulhof
Copy link
Contributor

Signed-off-by: @gabrielschulhof

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines

Signed-off-by: Gabriel Schulhof <gabriel.schulhof@intel.com>
@nodejs-github-bot nodejs-github-bot added the test Issues and PRs related to the tests. label Nov 19, 2020
@gabrielschulhof gabrielschulhof added the node-api Issues and PRs related to the Node-API. label Nov 19, 2020
@Flarna Flarna added the request-ci Add this label to start a Jenkins CI on a PR. label Nov 19, 2020
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Nov 19, 2020
@nodejs-github-bot
Copy link
Collaborator

Copy link
Member

@mhdawson mhdawson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mhdawson
Copy link
Member

Requesting fast-track as I think it's uncontroversial and would be good to address the warnings

@mhdawson mhdawson added the fast-track PRs that do not need to wait for 48 hours to land. label Nov 20, 2020
gabrielschulhof pushed a commit that referenced this pull request Nov 20, 2020
Signed-off-by: Gabriel Schulhof <gabriel.schulhof@intel.com>
PR-URL: #36171
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>
Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de>
@gabrielschulhof
Copy link
Contributor Author

Landed in 551d8c4.

@gabrielschulhof gabrielschulhof deleted the fix-warnings branch November 20, 2020 21:45
codebytere pushed a commit that referenced this pull request Nov 22, 2020
Signed-off-by: Gabriel Schulhof <gabriel.schulhof@intel.com>
PR-URL: #36171
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>
Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de>
@codebytere codebytere mentioned this pull request Nov 22, 2020
BethGriggs pushed a commit that referenced this pull request Dec 10, 2020
Signed-off-by: Gabriel Schulhof <gabriel.schulhof@intel.com>
PR-URL: #36171
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>
Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de>
BethGriggs pushed a commit that referenced this pull request Dec 10, 2020
Signed-off-by: Gabriel Schulhof <gabriel.schulhof@intel.com>
PR-URL: #36171
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>
Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de>
@BethGriggs BethGriggs mentioned this pull request Dec 10, 2020
BethGriggs pushed a commit that referenced this pull request Dec 15, 2020
Signed-off-by: Gabriel Schulhof <gabriel.schulhof@intel.com>
PR-URL: #36171
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>
Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fast-track PRs that do not need to wait for 48 hours to land. node-api Issues and PRs related to the Node-API. test Issues and PRs related to the tests.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants