Commits on Nov 25, 2020

1. deps: V8: cherry-pick 86991d0587a1 …

   Adds methods for fetching stack trace information about
   enclosing function.
   
   Refs nodejs#36042
   
   Original commit message:
   
       Reland "stack-trace-api: implement getEnclosingLine/Column"
   
       This reverts commit 5557a63beb5a53c93e9b590eaf2933e21bcb3768.
   
       Reason for revert: Sheriff's mistake, failing test was previously flaking.
   
       Original change's description:
       > Revert "stack-trace-api: implement getEnclosingLine/Column"
       >
       > This reverts commit c48ae2d96cbfdc2216706a5e9a79ae1dce5a638b.
       >
       > Reason for revert: Breaks a profiling test:
       > https://ci.chromium.org/p/v8/builders/ci/V8%20Win32/30010
       >
       > Original change's description:
       > > stack-trace-api: implement getEnclosingLine/Column
       > >
       > > Introduces getEnclosingColumn and getEnclosingLine on CallSite
       > > so that the position can be used to lookup the original symbol
       > > for function when source maps are used.
       > >
       > > BUG=v8:11157
       > >
       > > Change-Id: I06c4c374d172d206579abb170c7b7a2bd3bb159f
       > > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2547218
       > > Reviewed-by: Jakob Kummerow <jkummerow@chromium.org>
       > > Commit-Queue: Benjamin Coe <bencoe@google.com>
       > > Cr-Commit-Position: refs/heads/master@{#71343}
       >
       > TBR=jkummerow@chromium.org,yangguo@chromium.org,bencoe@google.com
       >
       > Change-Id: Iab5c250c1c4fbdab86971f4a7e40abc8f87cf79c
       > No-Presubmit: true
       > No-Tree-Checks: true
       > No-Try: true
       > Bug: v8:11157
       > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2555384
       > Reviewed-by: Bill Budge <bbudge@chromium.org>
       > Commit-Queue: Bill Budge <bbudge@chromium.org>
       > Cr-Commit-Position: refs/heads/master@{#71345}
   
       TBR=bbudge@chromium.org,jkummerow@chromium.org,yangguo@chromium.org,bencoe@google.com
   
       # Not skipping CQ checks because this is a reland.
   
       Bug: v8:11157
       Change-Id: I8dba19ceb29a24594469d2cf79626f741dc4cad3
       Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2555499
       Reviewed-by: Bill Budge <bbudge@chromium.org>
       Commit-Queue: Bill Budge <bbudge@chromium.org>
       Cr-Commit-Position: refs/heads/master@{#71348}
   
   Refs: v8/v8@86991d0

   

   bcoe committed Nov 25, 2020
   Copy the full SHA

   d5a93e8 View commit details

   Browse the repository at this point in the history