Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[v12.x backport] http2: check write not scheduled in scope destructor #36355

Closed
wants to merge 1 commit into from
Closed

[v12.x backport] http2: check write not scheduled in scope destructor #36355

wants to merge 1 commit into from

Conversation

davedoesdev
Copy link
Contributor

Fixes: #33156

PR-URL: #36241
Reviewed-By: Matteo Collina matteo.collina@gmail.com
Reviewed-By: Rich Trott rtrott@gmail.com

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. http2 Issues or PRs related to the http2 subsystem. v12.x labels Dec 2, 2020
@davedoesdev
http2: check write not scheduled in scope destructor
10c7e3a 
Fixes: #33156

PR-URL: #36241
Backport-PR-URL: #36355
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
@davedoesdev
Copy link
Contributor Author

Is this waiting for the next v12 release?

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/36012/

ruyadorno pushed a commit that referenced this pull request Feb 8, 2021
@davedoesdev @ruyadorno
http2: check write not scheduled in scope destructor
97183ae 
Fixes: #33156

PR-URL: #36241
Backport-PR-URL: #36355
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
ruyadorno pushed a commit that referenced this pull request Feb 10, 2021
@davedoesdev @ruyadorno
http2: check write not scheduled in scope destructor
4ac8f37 
Fixes: #33156

PR-URL: #36241
Backport-PR-URL: #36355
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/36730/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/36754/

@richardlau
Copy link
Member

It looks like this landed as 4ac8f37 and released in #37286?

@richardlau richardlau closed this Jul 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Trott Trott Trott approved these changes

@BethGriggs BethGriggs BethGriggs approved these changes

Assignees
No one assigned
Labels
c++ Issues and PRs that require attention from people who are familiar with C++. http2 Issues or PRs related to the http2 subsystem.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@davedoesdev @nodejs-github-bot @richardlau @Trott @BethGriggs