Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[v14.x backport] http2: check write not scheduled in scope destructor #36372

Closed
wants to merge 1 commit into from
Closed

[v14.x backport] http2: check write not scheduled in scope destructor #36372

wants to merge 1 commit into from

Conversation

davedoesdev
Copy link
Contributor

Fixes: #33156

PR-URL: #36241
Reviewed-By: Matteo Collina matteo.collina@gmail.com
Reviewed-By: Rich Trott rtrott@gmail.com

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. http2 Issues or PRs related to the http2 subsystem. v14.x labels Dec 3, 2020
@davedoesdev
http2: check write not scheduled in scope destructor
f6737f0 
Fixes: #33156

PR-URL: #36241
Backport-PR-URL: #36372
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
@BethGriggs BethGriggs added the request-ci Add this label to start a Jenkins CI on a PR. label Dec 9, 2020
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Dec 9, 2020
@nodejs-github-bot

This comment has been minimized.

Sign in to view
@BethGriggs BethGriggs added the request-ci Add this label to start a Jenkins CI on a PR. label Dec 9, 2020
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Dec 9, 2020
@nodejs-github-bot

This comment has been minimized.

Sign in to view
@BethGriggs BethGriggs added the request-ci Add this label to start a Jenkins CI on a PR. label Dec 10, 2020
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Dec 10, 2020
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Dec 10, 2020 •
edited by BethGriggs

CI: https://ci.nodejs.org/job/node-test-pull-request/34884/
(Fixed a flake on v14.x-staging, so this one should be green.) 🤞🏻

@BethGriggs
Copy link
Member

BethGriggs commented Dec 10, 2020 •
edited

Last CI is good (osx failure appears to be due to nodejs/build#2482).

The original PR #36241 hasn't been in current for 2 weeks - could anyone from @nodejs/http2 give this a review and advise whether you feel it should land in v14.x without the wait?

@mcollina
Copy link
Member

I would include it.

BethGriggs pushed a commit that referenced this pull request Dec 10, 2020
@davedoesdev @BethGriggs
http2: check write not scheduled in scope destructor
4b315a5 
Fixes: #33156

PR-URL: #36241
Backport-PR-URL: #36372
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
@BethGriggs
Copy link
Member

Landed in 4b315a5

@BethGriggs BethGriggs closed this Dec 10, 2020
BethGriggs pushed a commit that referenced this pull request Dec 15, 2020
@davedoesdev @BethGriggs
http2: check write not scheduled in scope destructor
71c3efe 
Fixes: #33156

PR-URL: #36241
Backport-PR-URL: #36372
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BethGriggs BethGriggs BethGriggs approved these changes

Assignees
No one assigned
Labels
c++ Issues and PRs that require attention from people who are familiar with C++. http2 Issues or PRs related to the http2 subsystem.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@davedoesdev @nodejs-github-bot @BethGriggs @mcollina