Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: make explicit reverting node_version.h changes #36461

Closed
wants to merge 2 commits into from
Closed

doc: make explicit reverting node_version.h changes #36461

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
61f69fb
doc: make explicit reverting node_version.h changes
richardlau Dec 9, 2020
af347d6
fixup! doc: make explicit reverting node_version.h changes
richardlau Dec 10, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
8 changes: 7 additions & 1 deletion doc/guides/releases.md
View file
Open in desktop
Expand Up @@ -544,7 +544,13 @@ $ git cherry-pick v1.x^
```

Git should stop to let you fix conflicts. Revert all changes that were made to
`src/node_version.h`. If there are conflicts in `doc` due to updated `REPLACEME`
`src/node_version.h`:

```console
$ git checkout --ours HEAD -- src/node_version.h
```

If there are conflicts in `doc` due to updated `REPLACEME`
placeholders (that happens when a change previously landed on another release
branch), keep both version numbers. Convert the YAML field to an array if it is
not already one.
Expand Down