v15.5.0 release proposal #36597

targos · 2020-12-22T08:33:49Z

2020-12-22, Version 15.5.0 (Current), @targos

Notable Changes

Extended support for `AbortSignal` in child_process and stream

The following APIs now support an AbortSignal in their options object:

child_process.spawn()

Calling .abort() on the corresponding AbortController is similar to calling .kill() on the child process except the error passed to the callback will be an AbortError:

const controller = new AbortController();
const { signal } = controller;
const grep = spawn('grep', ['ssh'], { signal });
grep.on('error', (err) => {
  // This will be called with err being an AbortError if the controller aborts
});
controller.abort(); // stops the process

new stream.Writable() and new stream.Readable()

Calling .abort() on the corresponding AbortController will behave the same way as calling .destroy(new AbortError()) on the stream:

const { Readable } = require('stream');
const controller = new AbortController();
const read = new Readable({
  read(size) {
    // ...
  },
  signal: controller.signal
});
// Later, abort the operation closing the stream
controller.abort();

Contributed by Benjamin Gruenbaum #36431, #36432.

BigInt support in `querystring.stringify()`

If querystring.stringify() is called with an object that contains BigInt values, they will now be serialized to their decimal representation instead of the empty string:

const querystring = require('querystring');
console.log(querystring.stringify({ bigint: 2n ** 64n }))
// Prints: bigint=18446744073709551616

Contributed by Darshan Sen #36499.

Additions to the C++ embedder APIs

A new IsolateSettingsFlag is available for those calling SetIsolateUpForNode(): SHOULD_NOT_SET_PREPARE_STACK_TRACE_CALLBACK can be used to prevent Node.js from setting a custom callback to prepare stack traces.

Contributed by Shelley Vohr #36447.

Added node::GetEnvironmentIsolateData() and node::GetArrayBufferAllocator() to respectively get the current IsolateData* and, from it, the current Node.js ArrayBufferAllocator if there is one.

Contributed by Anna Henningsen #36441.

New core collaborator

With this release, we welcome a new Node.js core collaborator:

Pooja D P @PoojaDurgad #36511

Commits

Semver-minor commits

[e449571230] - (SEMVER-MINOR) child_process: add signal support to spawn (Benjamin Gruenbaum) #36432
[25d7e90386] - (SEMVER-MINOR) http: use autoDestroy: true in incoming message (Daniele Belardi) #33035
[5481be8cbd] - (SEMVER-MINOR) lib: support BigInt in querystring.stringify (raisinten) #36499
[036ed1fafc] - (SEMVER-MINOR) src: add way to get IsolateData and allocator from Environment (Anna Henningsen) #36441
[e23309486b] - (SEMVER-MINOR) src: allow preventing SetPrepareStackTraceCallback (Shelley Vohr) #36447
[6ecbc1dcb3] - (SEMVER-MINOR) stream: support abortsignal in constructor (Benjamin Gruenbaum) #36431

Semver-patch commits

[1330995b80] - build,lib,test: change whitelist to allowlist (Michaël Zasso) #36406
[dc8d1a74a6] - deps: upgrade npm to 7.3.0 (Ruy Adorno) #36572
[b6a31f0a70] - deps: update archs files for OpenSSL-1.1.1i (Myles Borins) #36520
[5b49807c3f] - deps: re-enable OPENSSL_NO_QUIC guards (James M Snell) #36520
[309e2971a2] - deps: various quic patches from akamai/openssl (Todd Short) #36520
[27fb651cbc] - deps: upgrade openssl sources to 1.1.1i (Myles Borins) #36520
[1f43aadf90] - deps: update patch and docs for openssl update (Myles Borins) #36520
[752c94d202] - deps: fix npm doctor tests for pre-release node (nlf) #36543
[b0393fa2ed] - deps: upgrade npm to 7.2.0 (Myles Borins) #36543
[cb4652e91d] - deps: update to c-ares 1.17.1 (Danny Sonnenschein) #36207
[21fbcb6f81] - deps: V8: backport 4bf051d536a1 (Anna Henningsen) #36482
[30fe0ff681] - deps: upgrade npm to 7.1.2 (Darcy Clarke) #36487
[0baa610c3e] - deps: upgrade npm to 7.1.1 (Ruy Adorno) #36459
[5929b08851] - deps: upgrade npm to 7.1.0 (Ruy Adorno) #36395
[deaafd5788] - dns: refactor to use more primordials (Antoine du Hamel) #36314
[e30af7be33] - fs: refactor to use optional chaining (ZiJian Liu) #36524
[213dcd7930] - http: add test for incomingmessage destroy (Daniele Belardi) #33035
[36b4ddd382] - http: use standard args order in IncomingMEssage onError (Daniele Belardi) #33035
[60b5e696fc] - http: remove trailing space (Daniele Belardi) #33035
[f11a648d8e] - http: add comments in _http_incoming (Daniele Belardi) #33035
[4b81d79b58] - http: fix lint error in incoming message (Daniele Belardi) #33035
[397e31e25f] - http: reafactor incoming message destroy (Daniele Belardi) #33035
[9852ebca8d] - http: do not loop over prototype in Agent (Michaël Zasso) #36410
[e46a46a4cd] - inspector: refactor to use more primordials (Antoine du Hamel) #36356
[728f512c7d] - lib: make safe primordials safe to iterate (Antoine du Hamel) #36391
[f368d697cf] - Revert "perf_hooks: make PerformanceObserver an AsyncResource" (Nicolai Stange) #36343
[e2ced0d401] - perf_hooks: invoke performance_entry_callback via MakeSyncCallback() (Nicolai Stange) #36343
[7c903ec6c8] - repl: disable blocking completions by default (Anna Henningsen) #36564
[bbc0d14cd2] - src: use correct microtask queue for checkpoints (Anna Henningsen) #36581
[7efb3111e8] - src: remove unnecessary ToLocalChecked call (Daniel Bevenius) #36523
[68687d3419] - src: remove empty name check in node_env_var.cc (raisinten) #36133
[1b4984de98] - src: remove duplicate V macros in node_v8.cc (Daniel Bevenius) #36454
[5ff7f42e65] - src: use correct outer Context’s microtask queue (Anna Henningsen) #36482
[96c095f237] - src: guard against env != null in node_errors.cc (Anna Henningsen) #36414
[4f3d7bb417] - src: introduce convenience node::MakeSyncCallback() (Nicolai Stange) #36343
[e59788262c] - src: add typedef for CleanupHookCallback callback (Daniel Bevenius) #36442
[2a60e3b9df] - src: fix indentation in memory_tracker-inl.h (Daniel Bevenius) #36425
[210390f6fd] - src: remove identical V macro (Daniel Bevenius) #36427
[02afe586aa] - src: use using declarations consistently (Daniel Bevenius) #36365
[169406b7d7] - src: add missing context scopes (Anna Henningsen) #36413
[3f33d0bcda] - stream: fix pipe deadlock when starting with needDrain (Robert Nagy) #36563
[d8b5b9499c] - stream: accept iterable as a valid first argument (ZiJian Liu) #36479
[58319d5336] - tls: forward new SecureContext options (Alba Mendez) #36416
[fa40366276] - util: simplify constructor retrieval in inspect() (Rich Trott) #36466
[cc544dbfaa] - util: fix instanceof checks with null prototypes during inspection (Ruben Bridgewater) #36178
[13d6597b4b] - util: fix module prefixes during inspection (Ruben Bridgewater) #36178
[20ecc82569] - worker: fix broadcast channel SharedArrayBuffer passing (Anna Henningsen) #36501
[56fe9bae26] - worker: refactor MessagePort entanglement management (Anna Henningsen) #36345

Documentation commits

[9fbab3e2f5] - doc: update and run license-builder for Babel (Michaël Zasso) #36504
[a1ba6686a0] - doc: add remark about Collaborators discussion page (FrankQiu) #36420
[c5602fb166] - doc: simplify worker_threads.md text (Rich Trott) #36545
[149f2cfac1] - doc: add two tips for speeding the dev builds (Momtchil Momtchev) #36452
[ad75c78c32] - doc: add note about timingSafeEqual for TypedArray (Tobias Nießen) #36323
[9830fe5c9e] - doc: move Derek Lewis to emeritus (Rich Trott) #36514
[eb29a16bae] - doc: add issue reference to github pr template (Chinmoy Chakraborty) #36440
[f09985d42a] - doc: update url.md (Rock) #36147
[c3ec90d23c] - doc: make explicit reverting node_version.h changes (Richard Lau) #36461
[7a34452b1d] - doc: add license info to the README (FrankQiu) #36278
[22f039339f] - doc: revise addon mulitple initializations text (Rich Trott) #36457
[25a245443a] - doc: add v15.4.0 link to CHANGELOG.md (Danielle Adams) #36456
[1ec8516fd6] - doc: add PoojaDurgad to collaborators (Pooja D P) #36511
[98918110a1] - doc: edit addon text about event loop blocking (Rich Trott) #36448
[62bfe3d313] - doc: note v15.0.0 changed default --unhandled-rejections=throw (kai zhu) #36361
[129053fe4c] - doc: update terminology (Michael Dawson) #36475
[e331de2571] - doc: reword POSIX threads text in addons.md (Rich Trott) #36436
[04f166389b] - doc: add RaisinTen as a triager (raisinten) #36404
[3341b2cb9d] - doc: document ABORT_ERR code (Benjamin Gruenbaum) #36319
[6a6b3af736] - doc: provide more context on techinical values (Michael Dawson) #36201

Other commits

[e1f00fd996] - benchmark: reduce code duplication (Rich Trott) #36568
[82a26268d7] - build: do not run GitHub actions for draft PRs (Michaël Zasso) #35910
[95c80f5fb0] - build: run some workflows only on nodejs/node (Michaël Zasso) #36507
[584ea8b26c] - build: fix make test-npm (Ruy Adorno) #36369
[9fc2479707] - test: increase coverage for worker (ZiJian Liu) #36491
[81e603b7cf] - test: specify global object for globals (Rich Trott) #36498
[109ab787fd] - test: increase coverage for fs/dir read (Zijian Liu) #36388
[9f2d3c291b] - test: remove test-http2-client-upload as flaky (Rich Trott) #36496
[d299ceeac7] - test: increase coverage for net/blocklist (Zijian Liu) #36405
[f7635fd86d] - test: make executable name more general (Shelley Vohr) #36489
[acd78d9d25] - test: increased externalized string length (Shelley Vohr) #36451
[0f749a35ec] - test: add test for async contexts in PerformanceObserver (ZauberNerd) #36343
[dd705ad1f0] - test: increase execFile abort coverage (Moshe vilner) #36429
[31b062d591] - test: fix flaky test-repl (Rich Trott) #36415
[023291b43c] - test: check null proto-of-proto in util.inspect() (Rich Trott) #36399
[d3d1f338c7] - test: add SIGTRAP to test-signal-handler (Ash Cripps) #36368
[166aa8a7b5] - test: fix child-process-pipe-dataflow (Santiago Gimeno) #36366
[e3c5adc6d0] - tools: fix release script sign function (Antoine du Hamel) #36556
[0d4d34748d] - tools: update ESLint to 7.16.0 (Yongsheng Zhang) #36579
[f3828c9dcb] - tools: fix update-eslint.sh (Yongsheng Zhang) #36579
[27260c70b4] - tools: fix release script (Antoine du Hamel) #36540
[c6700ad041] - tools: remove unused variable in configure.py (Rich Trott) #36525
[7b8d373d5e] - tools: lint shell scripts (Antoine du Hamel) #36099
[c6e65d09ef] - tools: update ini in tools/node-lint-md-cli-rollup (Myles Borins) #36474
[7542a3bd55] - tools: enable no-unsafe-optional-chaining lint rule (Colin Ihrig) #36411
[26f8ccfbe6] - tools: update ESLint to 7.15.0 (Colin Ihrig) #36411
[8ecf2f9976] - tools: update doc tool dependencies (Michaël Zasso) #36407
[040b39f076] - tools: enable no-unused-expressions lint rule (Michaël Zasso) #36248

Fixes: #36364 PR-URL: #36410 Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de> Reviewed-By: Ricky Zhou <0x19951125@gmail.com>

Fixes: #36246 PR-URL: #36248 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>

PR-URL: #36314 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>

In the discussion of #35323 it was suggested that we should add some additional context/clarification to the technical values documented for the project. Signed-off-by: Michael Dawson <mdawson@devrus.com> PR-URL: #36201 Reviewed-By: Myles Borins <myles.borins@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>

Make sure all the `wc` process stdout data is received before checking its validity. Fixes: #25988 PR-URL: #36366 Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>

PR-URL: #36368 Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Evan Lucas <evanlucas@me.com>

Add a test to check util.inspect()'s handling of a null prototype-of-an-iterable-prototype. This covers a previously uncovered code branch. Refs: https://coverage.nodejs.org/coverage-0fd121e00c9d5987/lib/internal/util/inspect.js.html#L597 PR-URL: #36399 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>

Add scopes that ensure that the context associated with the current Environment is always entered when working with it. PR-URL: #36413 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Gus Caplan <me@gus.host> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>

PR-URL: #36407 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Myles Borins <myles.borins@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>

We added an `AbortError` with the same code and name as the web's as part of the consensus in #36084 but never actually documented the error in our error codes list. This PR adds the error code. PR-URL: #36319 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>

PR-URL: #36365 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Rich Trott <rtrott@gmail.com>

This commit removes one of the V macros in IsolateData::MemoryInfo as they are identical as far as I can tell. PR-URL: #36427 Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Zeyu Yang <himself65@outlook.com>

PR-URL: #36425 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>

The timeout is insufficient in CI (failures on Raspberry Pi) and I can reproduce locally (on macOS) with `tools/test.py -j 96 --repeat 192 test-repl`. Increase timeout drastically as it only is useful in an error condition. PR-URL: #36415 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de> Reviewed-By: James M Snell <jasnell@gmail.com>

PR-URL: #36395 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Myles Borins <myles.borins@gmail.com>

I would like to apply for the role of a triager in this project. My motivation to become a triager is to help with the issues in this repo and the help repo, as well as learn deeper internals of Node.js, and to eventually become a collaborator! I hearby declare that I have read and understood the Code of Conduct of the project and will adhere to that. PR-URL: #36404 Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Rich Trott <rtrott@gmail.com>

Update ESLint to 7.15.0 PR-URL: #36411 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com>

This rule is new in ESLint 7.15.0. PR-URL: #36411 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com>

PR-URL: #36436 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>

Verify that if something different than Abortcontroller.signal is passed to child_process.execFile(), ERR_INVALID_ARG_TYPE is thrown. PR-URL: #36429 Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>

PR-URL: #36356 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com>

PR-URL: #36431 Reviewed-By: Robert Nagy <ronagy@icloud.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com>

Signed-off-by: Michael Dawson <mdawson@devrus.com> PR-URL: #36475 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>

PR-URL: #36406 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Michael Dawson <midawson@redhat.com>

This commit adds a typedef for the callback parameter used in CleanupHookCallback's constructor, AddCleanupHook, and RemoveCleanupHook. PR-URL: #36442 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>

There are situations where one wants to invoke a JS callback's ->Call() from C++ and in particular retain any existing async_context state, but where it's not obvious that a plain ->Call() would be safe at the point in question. Such callsites usually resort to node::MakeCallback(..., async_context{0, 0}), which unconditionally pushes the async_context{0, 0} and takes the required provisions for the ->Call() itself such as triggering the tick after its return, if needed. An example would be the PerformanceObserver invocation from PerformanceEntry::Notify(): this can get called when coming from JS through e.g. perf_hooks.performance.mark() and alike, but perhaps also from nghttp2 (c.f. EmitStatistics() in node_http2.cc). In the former case, a plain ->Call() would be safe and it would be desirable to retain the current async_context so that PerformanceObservers can access it resp. the associated AsyncLocalStorage. However, in the second case the additional provisions taken by node::MakeCallback() might potentially be strictly required. So PerformanceEntry::Notify() bites the bullet and invokes the PerformanceObservers through node::MakeCallback() unconditionally, thereby always rendering any possibly preexisting async_context inaccessible. Introduce the convenience node::MakeSyncCallback() for such usecases, which would basically forward to ->Call() if safe and to node::MakeCallback(..., async_context{0, 0}) otherwise. Co-Authored-By: ZauberNerd <zaubernerd@zaubernerd.de> PR-URL: #36343 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Rich Trott <rtrott@gmail.com>

It's desirable to retain async_contexts active at callsites of perf_hooks.performance.mark() and alike in the subsequent PerformanceObserver invocations such that the latter can access e.g. associated AsyncLocalStorage instances. In working towards this goal replace the node::MakeCallback(..., async_context{0, 0}) in PerformanceEntry::doNotify() by the new node::MakeSyncCallback() introduced specifically for this purpose. This change will retain the original async_context, if any, in perf_hook's observersCallback() and thus, for the subsequent doNotify() on unbuffered PerformanceObservers. Co-Authored-By: ZauberNerd <zaubernerd@zaubernerd.de> PR-URL: #36343 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Rich Trott <rtrott@gmail.com>

This reverts commit 009e418. AFAIU the discussion at [1], PerformanceObserver had been made to inherit from AsyncResource more or less as a band-aid in lack of a better async_context candidate to invoke it in. In order to enable access to AsyncLocalStores from PerformanceObservers invoked synchronously through e.g. measure() or mark(), the current async_context, if any, should be retained. Note that this is a breaking change, but - as has been commented at [1], PerformanceObserver being derived from AsyncResource is a "minor divergence from the spec" anyway, - to my knowledge this is an internal implementation detail which has never been documented and - I can't think of a good reason why existing PerformanceObserver implementations would possibly rely on it. OTOH, it's probably worthwhile to not potentially invoke before() and after() async_hooks for each and every PerformanceObserver notification. [1] #18789 Co-Authored-By: ZauberNerd <zaubernerd@zaubernerd.de> PR-URL: #36343 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Rich Trott <rtrott@gmail.com>

This test proves that the PerformanceObserver callback gets called with the async context of the callsite of performance.mark()/measure() and therefore AsyncLocalStorage can be used inside a PerformanceObserver. PR: #36343 PR-URL: #36343 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Rich Trott <rtrott@gmail.com>

Refs: #36473 Refs: GHSA-qqgx-2p2h-9c37 PR-URL: #36474 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>

ExE-Boss · 2020-12-22T13:07:17Z

Do we want to include #36549 in this?

addaleax · 2020-12-22T13:10:18Z

@ExE-Boss I’ve added that PR to the commit queue, so it should land in the next minutes, but I also don’t see any reason to rush it.

PR-URL: #36596 Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>

PR-URL: #36547 Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>

1. test addAbortSignal with invalid signal Refs: https://coverage.nodejs.org/coverage-a1509261770cb645/lib/internal/streams/add-abort-signal.js.html#L17 2. test addAbortSignal with invalid stream Refs: https://coverage.nodejs.org/coverage-a1509261770cb645/lib/internal/streams/add-abort-signal.js.html#L28 3. test addAbortSignalNoValidate with invalid signal Refs: https://coverage.nodejs.org/coverage-a1509261770cb645/lib/internal/streams/add-abort-signal.js.html#L34 4. test addAbortSignalNoValidate with aborted signal Refs: https://coverage.nodejs.org/coverage-a1509261770cb645/lib/internal/streams/add-abort-signal.js.html#L40 5. test Readable.from with invalid args Refs: https://coverage.nodejs.org/coverage-a1509261770cb645/lib/internal/streams/from.js.html#L31 PR-URL: #36538 Refs: https://coverage.nodejs.org/coverage-a1509261770cb645/lib/internal/streams/add-abort-signal.js.html#L40 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Michael Dawson <midawson@redhat.com>

V8's `tools/dev/v8gen.py` does not like being passed an empty string (`""`). PR-URL: #36594 Refs: #36099 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Ben Coe <bencoe@gmail.com> Reviewed-By: Jiawen Geng <technicalcute@gmail.com>

PR-URL: #36586 Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>

Notable changes: child_process: * (SEMVER-MINOR) add signal support to spawn (Benjamin Gruenbaum) #36432 doc: * add PoojaDurgad to collaborators (Pooja D P) #36511 lib: * (SEMVER-MINOR) support BigInt in querystring.stringify (raisinten) #36499 src: * (SEMVER-MINOR) add way to get IsolateData and allocator from Environment (Anna Henningsen) #36441 * (SEMVER-MINOR) allow preventing SetPrepareStackTraceCallback (Shelley Vohr) #36447 stream: * (SEMVER-MINOR) support abortsignal in constructor (Benjamin Gruenbaum) #36431 PR-URL: #36597

nodejs-github-bot · 2020-12-22T14:02:00Z

CI: https://ci.nodejs.org/job/node-test-pull-request/35040/
V8: https://ci.nodejs.org/job/node-test-commit-v8-linux/3632/

targos · 2020-12-22T14:02:11Z

@richardlau done
@ExE-Boss sorry, it will be in the next release

targos · 2020-12-22T15:22:44Z

Are there known issues with AIX CI? It failed twice for different reasons.

richardlau · 2020-12-22T15:38:56Z

Are there known issues with AIX CI? It failed twice for different reasons.

I'm not aware of any.

nodejs-github-bot · 2020-12-22T16:03:23Z

CI: https://ci.nodejs.org/job/node-test-pull-request/35042/ ✔️

targos · 2020-12-22T16:36:55Z

It passed the retry 🤷

targos · 2020-12-22T16:40:26Z

Release build: https://ci-release.nodejs.org/job/iojs+release/6542/

PR-URL: #36597

Notable changes: child_process: * (SEMVER-MINOR) add signal support to spawn (Benjamin Gruenbaum) #36432 doc: * add PoojaDurgad to collaborators (Pooja D P) #36511 lib: * (SEMVER-MINOR) support BigInt in querystring.stringify (raisinten) #36499 src: * (SEMVER-MINOR) add way to get IsolateData and allocator from Environment (Anna Henningsen) #36441 * (SEMVER-MINOR) allow preventing SetPrepareStackTraceCallback (Shelley Vohr) #36447 stream: * (SEMVER-MINOR) support abortsignal in constructor (Benjamin Gruenbaum) #36431 PR-URL: #36597

Refs: nodejs/node#36597

targos and others added 30 commits December 13, 2020 22:18

http: do not loop over prototype in Agent

9852ebc

Fixes: #36364 PR-URL: #36410 Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de> Reviewed-By: Ricky Zhou <0x19951125@gmail.com>

dns: refactor to use more primordials

deaafd5

PR-URL: #36314 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>

test: add SIGTRAP to test-signal-handler

d3d1f33

PR-URL: #36368 Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Evan Lucas <evanlucas@me.com>

tools: update doc tool dependencies

8ecf2f9

PR-URL: #36407 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Myles Borins <myles.borins@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>

src: use using declarations consistently

02afe58

PR-URL: #36365 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Rich Trott <rtrott@gmail.com>

deps: upgrade npm to 7.1.0

5929b08

PR-URL: #36395 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Myles Borins <myles.borins@gmail.com>

doc: reword POSIX threads text in addons.md

e331de2

PR-URL: #36436 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>

test: increase execFile abort coverage

dd705ad

Verify that if something different than Abortcontroller.signal is passed to child_process.execFile(), ERR_INVALID_ARG_TYPE is thrown. PR-URL: #36429 Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>

inspector: refactor to use more primordials

e46a46a

PR-URL: #36356 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com>

stream: support abortsignal in constructor

6ecbc1d

PR-URL: #36431 Reviewed-By: Robert Nagy <ronagy@icloud.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com>

doc: update terminology

129053f

Signed-off-by: Michael Dawson <mdawson@devrus.com> PR-URL: #36475 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>

tools: update ini in tools/node-lint-md-cli-rollup

c6e65d0

Refs: #36473 Refs: GHSA-qqgx-2p2h-9c37 PR-URL: #36474 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>

targos and others added 6 commits December 22, 2020 14:51

doc: fix AbortSignal example for stream.Readable

19c2332

PR-URL: #36596 Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>

src: remove unnecessary ToLocalChecked node_errors

d38a0ec

PR-URL: #36547 Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>

test: increase abort logic coverage

01576fb

PR-URL: #36586 Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>

targos force-pushed the v15.5.0-proposal branch from eb84150 to f978628 Compare December 22, 2020 14:00

richardlau approved these changes Dec 22, 2020

View reviewed changes

targos merged commit f978628 into v15.x Dec 22, 2020

targos added a commit that referenced this pull request Dec 22, 2020

Working on v15.5.1

689b50c

PR-URL: #36597

targos added a commit to nodejs/nodejs.org that referenced this pull request Dec 22, 2020

Blog: v15.5.0 release post

5aba7a7

Refs: nodejs/node#36597

targos deleted the v15.5.0-proposal branch December 22, 2020 19:01

targos added a commit to nodejs/nodejs.org that referenced this pull request Dec 22, 2020

Blog: v15.5.0 release post (#3589)

51f3cdf

Refs: nodejs/node#36597

RaisinTen mentioned this pull request Mar 18, 2021

Nodejs runs out of memory trying to connect to HTTPS host with self-signed certificate #37757

Closed

targos added the release Issues and PRs related to Node.js releases. label Apr 12, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

v15.5.0 release proposal #36597

v15.5.0 release proposal #36597

targos commented Dec 22, 2020

ExE-Boss commented Dec 22, 2020

addaleax commented Dec 22, 2020

nodejs-github-bot commented Dec 22, 2020 •

edited by targos

targos commented Dec 22, 2020

targos commented Dec 22, 2020

richardlau commented Dec 22, 2020

nodejs-github-bot commented Dec 22, 2020 •

edited by richardlau

targos commented Dec 22, 2020

targos commented Dec 22, 2020

v15.5.0 release proposal #36597

v15.5.0 release proposal #36597

Conversation

targos commented Dec 22, 2020

2020-12-22, Version 15.5.0 (Current), @targos

Notable Changes

Extended support for AbortSignal in child_process and stream

BigInt support in querystring.stringify()

Additions to the C++ embedder APIs

New core collaborator

Commits

Semver-minor commits

Semver-patch commits

Documentation commits

Other commits

ExE-Boss commented Dec 22, 2020

addaleax commented Dec 22, 2020

nodejs-github-bot commented Dec 22, 2020 • edited by targos

targos commented Dec 22, 2020

targos commented Dec 22, 2020

richardlau commented Dec 22, 2020

nodejs-github-bot commented Dec 22, 2020 • edited by richardlau

targos commented Dec 22, 2020

targos commented Dec 22, 2020

Extended support for `AbortSignal` in child_process and stream

BigInt support in `querystring.stringify()`

nodejs-github-bot commented Dec 22, 2020 •

edited by targos

nodejs-github-bot commented Dec 22, 2020 •

edited by richardlau