Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

benchmark: add simple https benchmark #36612

Closed
wants to merge 2 commits into from
Closed

benchmark: add simple https benchmark #36612

wants to merge 2 commits into from

Conversation

puzpuzpuz
Copy link
Member

It appears that we don't have any benchmarks for https. This PR aims to add a basic benchmark for https server implementation.

  • Adds a simple benchmark for https server based on the http simple benchmark.
  • Updates benchmarker integration for autocannon and wrk, so that they support https scheme.
  • Also adds a new HTTPS section and improves HTTP/2 section in the benchmark guide.
Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

@puzpuzpuz
benchmark: add simple https benchmark
459ad18 
Adds a simple benchmark for https server based on the http simple
benchmark. Updates benchmarker integration for autocannon and wrk,
so that they support https scheme.

Also adds a new HTTPS section and improves HTTP/2 section in
the benchmark guide.
@puzpuzpuz puzpuzpuz added benchmark Issues and PRs related to the benchmark subsystem. https Issues or PRs related to the https subsystem. labels Dec 23, 2020
@puzpuzpuz puzpuzpuz mentioned this pull request Dec 23, 2020
Closed
2 tasks
@Trott Trott added the request-ci Add this label to start a Jenkins CI on a PR. label Dec 24, 2020
@Trott
Copy link
Member

Trott commented Dec 24, 2020 •
edited

After this lands, we'll need https added to the choices in the CI benchmark job. (While we're at it, the options there are almost in alphabetical order. Should probably make it alphabetical too.) @nodejs/build

@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Dec 24, 2020
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/35058/

@puzpuzpuz puzpuzpuz added the request-ci Add this label to start a Jenkins CI on a PR. label Dec 24, 2020
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Dec 24, 2020
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Dec 24, 2020 •
edited by puzpuzpuz

CI: https://ci.nodejs.org/job/node-test-pull-request/35060/ (✅)

@aduh95 aduh95 added the commit-queue Add this label to land a pull request using GitHub Actions. label Dec 25, 2020
@github-actions github-actions bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Dec 25, 2020
@github-actions
Copy link
Contributor

Landed in 0187716...860c18b

@github-actions github-actions bot closed this Dec 25, 2020
nodejs-github-bot pushed a commit that referenced this pull request Dec 25, 2020
@puzpuzpuz @nodejs-github-bot
benchmark: add simple https benchmark
860c18b 
Adds a simple benchmark for https server based on the http simple
benchmark. Updates benchmarker integration for autocannon and wrk,
so that they support https scheme.

Also adds a new HTTPS section and improves HTTP/2 section in
the benchmark guide.

PR-URL: #36612
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
danielleadams pushed a commit that referenced this pull request Jan 12, 2021
@puzpuzpuz @danielleadams
benchmark: add simple https benchmark
7aedda9 
Adds a simple benchmark for https server based on the http simple
benchmark. Updates benchmarker integration for autocannon and wrk,
so that they support https scheme.

Also adds a new HTTPS section and improves HTTP/2 section in
the benchmark guide.

PR-URL: #36612
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
@danielleadams danielleadams mentioned this pull request Jan 12, 2021
Merged
targos pushed a commit that referenced this pull request May 1, 2021
@puzpuzpuz @targos
benchmark: add simple https benchmark
3a11ee8 
Adds a simple benchmark for https server based on the http simple
benchmark. Updates benchmarker integration for autocannon and wrk,
so that they support https scheme.

Also adds a new HTTPS section and improves HTTP/2 section in
the benchmark guide.

PR-URL: #36612
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
@danielleadams danielleadams mentioned this pull request May 3, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Trott Trott Trott approved these changes

@aduh95 aduh95 aduh95 approved these changes

Assignees
No one assigned
Labels
benchmark Issues and PRs related to the benchmark subsystem. https Issues or PRs related to the https subsystem.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@puzpuzpuz @Trott @nodejs-github-bot @aduh95