stream,zlib: do not use _stream_* anymore. #36618
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mcollina
added
dont-land-on-v10.x
request-ci
This was referenced Dec 24, 2020
github-actions
bot
removed
the
request-ci
ronag
approved these changes
Dec 24, 2020
Trott
approved these changes
Dec 24, 2020
|
@nodejs/releasers @nodejs/tsc this should go to into one of the next v14 releases. |
richardlau
approved these changes
Dec 24, 2020
There was a problem hiding this comment.
LGTM.
Do we need to add a regression test to catch the breakage (I'm assuming no existing test caught #36615)?
lpinca
approved these changes
Dec 24, 2020
benjamingr
approved these changes
Dec 24, 2020
|
@richardlau I've added a test |
|
@mcollina can you fix the lint error? |
|
@targos done |
github-actions
bot
removed
the
request-ci
richardlau
approved these changes
Dec 27, 2020
github-actions
bot
removed
the
request-ci
targos
approved these changes
Dec 28, 2020
github-actions
bot
removed
the
request-ci
Commit Queue failed- Loading data for nodejs/node/pull/36618 ✔ Done loading data for nodejs/node/pull/36618 ----------------------------------- PR info ------------------------------------ Title stream,zlib: do not use _stream_* anymore. (#36618) Author Matteo Collina (@mcollina) Branch mcollina:always-use-stream -> nodejs:master Labels dont-land-on-v10.x, dont-land-on-v12.x, lts-watch-v14.x, zlib Commits 1 - stream,zlib: do not use _stream_* anymore. Committers 1 - Matteo Collina PR-URL: https://github.com/nodejs/node/pull/36618 Reviewed-By: Robert Nagy Reviewed-By: Rich Trott Reviewed-By: Richard Lau Reviewed-By: Luigi Pinca Reviewed-By: Benjamin Gruenbaum Reviewed-By: Michaël Zasso ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/36618 Reviewed-By: Robert Nagy Reviewed-By: Rich Trott Reviewed-By: Richard Lau Reviewed-By: Luigi Pinca Reviewed-By: Benjamin Gruenbaum Reviewed-By: Michaël Zasso -------------------------------------------------------------------------------- ⚠ Commits were pushed since the last review: ⚠ - stream,zlib: do not use _stream_* anymore. ✔ Last GitHub Actions successful ℹ Last Full PR CI on 2020-12-28T17:53:03Z: https://ci.nodejs.org/job/node-test-pull-request/35126/ - Querying data for job/node-test-pull-request/35126/ ✔ Build data downloaded ✔ Last Jenkins CI successful ℹ This PR was created on Thu, 24 Dec 2020 15:29:15 GMT ✔ Approvals: 6 ✔ - Robert Nagy (@ronag): https://github.com/nodejs/node/pull/36618#pullrequestreview-558672980 ✔ - Rich Trott (@Trott) (TSC): https://github.com/nodejs/node/pull/36618#pullrequestreview-558684130 ✔ - Richard Lau (@richardlau): https://github.com/nodejs/node/pull/36618#pullrequestreview-558965185 ✔ - Luigi Pinca (@lpinca): https://github.com/nodejs/node/pull/36618#pullrequestreview-558695858 ✔ - Benjamin Gruenbaum (@benjamingr): https://github.com/nodejs/node/pull/36618#pullrequestreview-558712700 ✔ - Michaël Zasso (@targos) (TSC): https://github.com/nodejs/node/pull/36618#pullrequestreview-559085773 -------------------------------------------------------------------------------- ✔ Aborted `git node land` session in /home/runner/work/node/node/.ncuhttps://github.com/nodejs/node/actions/runs/449376978 |
|
May I get a last approval @targos? |
targos
approved these changes
Dec 28, 2020
mcollina
added
commit-queue
github-actions
bot
added
commit-queue-failed
Commit Queue failed- Loading data for nodejs/node/pull/36618 ✔ Done loading data for nodejs/node/pull/36618 ----------------------------------- PR info ------------------------------------ Title stream,zlib: do not use _stream_* anymore. (#36618) Author Matteo Collina (@mcollina) Branch mcollina:always-use-stream -> nodejs:master Labels dont-land-on-v10.x, dont-land-on-v12.x, lts-watch-v14.x, zlib Commits 1 - stream,zlib: do not use _stream_* anymore. Committers 1 - Matteo Collina PR-URL: https://github.com/nodejs/node/pull/36618 Reviewed-By: Robert Nagy Reviewed-By: Rich Trott Reviewed-By: Richard Lau Reviewed-By: Luigi Pinca Reviewed-By: Benjamin Gruenbaum Reviewed-By: Michaël Zasso ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/36618 Reviewed-By: Robert Nagy Reviewed-By: Rich Trott Reviewed-By: Richard Lau Reviewed-By: Luigi Pinca Reviewed-By: Benjamin Gruenbaum Reviewed-By: Michaël Zasso -------------------------------------------------------------------------------- ✔ Last GitHub Actions successful ℹ Last Full PR CI on 2020-12-28T19:16:44Z: https://ci.nodejs.org/job/node-test-pull-request/35126/ - Querying data for job/node-test-pull-request/35126/ ✔ Build data downloaded ✔ Last Jenkins CI successful ℹ This PR was created on Thu, 24 Dec 2020 15:29:15 GMT ✔ Approvals: 6 ✔ - Robert Nagy (@ronag): https://github.com/nodejs/node/pull/36618#pullrequestreview-558672980 ✔ - Rich Trott (@Trott) (TSC): https://github.com/nodejs/node/pull/36618#pullrequestreview-558684130 ✔ - Richard Lau (@richardlau): https://github.com/nodejs/node/pull/36618#pullrequestreview-558965185 ✔ - Luigi Pinca (@lpinca): https://github.com/nodejs/node/pull/36618#pullrequestreview-558695858 ✔ - Benjamin Gruenbaum (@benjamingr): https://github.com/nodejs/node/pull/36618#pullrequestreview-558712700 ✔ - Michaël Zasso (@targos) (TSC): https://github.com/nodejs/node/pull/36618#pullrequestreview-559319170 -------------------------------------------------------------------------------- ✔ No git cherry-pick in progress ✔ No git am in progress ✔ No git rebase in progress -------------------------------------------------------------------------------- - Bringing origin/master up to date... From https://github.com/nodejs/node * branch master -> FETCH_HEAD ✔ origin/master is now up-to-date - Downloading patch for 36618 From https://github.com/nodejs/node * branch refs/pull/36618/merge -> FETCH_HEAD ✔ Fetched commits as 053874939a60..be22d247cfc8 -------------------------------------------------------------------------------- [master ec57bf8288] stream,zlib: do not use _stream_* anymore. Author: Matteo Collina Date: Thu Dec 24 16:25:53 2020 +0100 3 files changed, 16 insertions(+), 3 deletions(-) create mode 100644 test/parallel/test-zlib-no-stream.js ✔ Patches applied -------------------------------------------------------------------------------- --------------------------------- New Message ---------------------------------- stream,zlib: do not use _stream_* anymore.https://github.com/nodejs/node/actions/runs/449646494 |
PR-URL: nodejs#36618 Reviewed-By: Robert Nagy <ronagy@icloud.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com>
aduh95
force-pushed
the
always-use-stream
branch
from
be22d24
to
e57d8af
Compare
|
Landed in e57d8af |
danielleadams
pushed a commit
that referenced
this pull request
Jan 12, 2021
PR-URL: #36618 Reviewed-By: Robert Nagy <ronagy@icloud.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com>
Merged
This was referenced Jan 22, 2021
BethGriggs
pushed a commit
that referenced
this pull request
Jan 26, 2021
PR-URL: #36618 Reviewed-By: Robert Nagy <ronagy@icloud.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com>
BethGriggs
added a commit
that referenced
this pull request
Jan 26, 2021
Merged
BethGriggs
added a commit
that referenced
this pull request
Jan 26, 2021
BethGriggs
added a commit
that referenced
this pull request
Jan 27, 2021
BethGriggs
pushed a commit
that referenced
this pull request
Jan 28, 2021
PR-URL: #36618 Reviewed-By: Robert Nagy <ronagy@icloud.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com>
BethGriggs
added a commit
that referenced
this pull request
Feb 8, 2021
Notable changes:
- **deps**:
- upgrade npm to 6.14.11 (Ruy Adorno)
(#37173)
- V8: backport dfcf1e86fac0 (Michaël Zasso)
(#37245)
- Note: Node.js is not believed to be vulnerable to CVE-2021-21148.
- **stream,zlib**: do not use \_stream\_\* anymore (Matteo Collina)
(#36618)
PR-URL: #37074
BethGriggs
added a commit
that referenced
this pull request
Feb 8, 2021
Notable changes:
- **deps**:
- upgrade npm to 6.14.11 (Ruy Adorno)
(#37173)
- V8: backport dfcf1e86fac0 (Michaël Zasso)
(#37245)
- Note: Node.js is not believed to be vulnerable to CVE-2021-21148.
- **stream,zlib**: do not use \_stream\_\* anymore (Matteo Collina)
(#36618)
PR-URL: #37074
BethGriggs
added a commit
that referenced
this pull request
Feb 9, 2021
Notable changes:
- **deps**:
- upgrade npm to 6.14.11 (Ruy Adorno)
(#37173)
- V8: backport dfcf1e86fac0 (Michaël Zasso)
(#37245)
- Note: Node.js is not believed to be vulnerable to CVE-2021-21148.
- **stream,zlib**: do not use \_stream\_\* anymore (Matteo Collina)
(#36618)
PR-URL: #37074
targos
removed
the
commit-queue-failed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In two place we still used
_stream_*, causing #36615 and potentially other issues.Note that #36615 does not impact
masterfor some independent reason.Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes