Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: correct callback parameter type for createPushResponse() #36631

Merged
merged 2 commits into from Dec 27, 2020
Merged

doc: correct callback parameter type for createPushResponse() #36631

merged 2 commits into from Dec 27, 2020

Commits on Dec 27, 2020

  1. doc: correct callback parameter type for createPushResponse() 

    Refs: nodejs#22322 (comment)

PR-URL: nodejs#36631
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    @Trott
    Trott committed Dec 27, 2020
    Configuration menu
    Copy the full SHA
    4e038d9 View commit details
    Browse the repository at this point in the history

  2. doc: alphabetize http response properties 

    All the properties are already in alphabetical order except for
createPushResponse(). Move that property to the alphabetical location in
the list.

PR-URL: nodejs#36631
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    @Trott
    Trott committed Dec 27, 2020
    Configuration menu
    Copy the full SHA
    0878d4d View commit details
    Browse the repository at this point in the history