Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

string_decoder: throw ERR_STRING_TOO_LONG for UTF-8 #36661

Closed
wants to merge 1 commit into from
Closed

string_decoder: throw ERR_STRING_TOO_LONG for UTF-8 #36661

wants to merge 1 commit into from

Commits on Dec 28, 2020

  1. string_decoder: throw ERR_STRING_TOO_LONG for UTF-8 

    String::NewFromUtf8 doesn't generate an exception in V8 when the string
is too long but is guaranteed to return an empty MaybeLocal only in
that case. Generate a Node.js exception when it happens.

Fixes: nodejs#35676
    @targos
    targos committed Dec 28, 2020
    Copy the full SHA
    3736662 View commit details
    Browse the repository at this point in the history