Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

lib: string indexOf to use primordials for http2/compat.js #36679

Closed
wants to merge 1 commit into from
Closed

lib: string indexOf to use primordials for http2/compat.js #36679

wants to merge 1 commit into from

Conversation

rchougule
Copy link
Contributor

@rchougule rchougule commented Dec 29, 2020 •
edited

StringPrototypeIncludes primordial in place of <string>.indexOf for truthy validation in if expression.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

@nodejs-github-bot nodejs-github-bot added the http2 Issues or PRs related to the http2 subsystem. label Dec 29, 2020
aduh95
aduh95 approved these changes Dec 29, 2020
View reviewed changes
lib/internal/http2/compat.js Outdated Show resolved Hide resolved
@yashLadha
Copy link
Member

Can you please squash the fixup commit. Else LGTM 👍🏽

@aduh95
Copy link
Contributor

aduh95 commented Dec 30, 2020

Note to whoever lands this: the first word of the commit message should be an imperative verb, I suggest something like http2: refactor to use primordials instead of <string>.indexOf.

Can you please squash the fixup commit. Else LGTM 👍🏽

@yashLadha This is usually done by the collaborator who lands the PR (git node land 36679 --fixupAll). They are also in charge of amending the commit message if there are typos or if it doesn't follow the commit guidelines.

@aduh95 aduh95 added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. request-ci Add this label to start a Jenkins CI on a PR. labels Dec 30, 2020
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Dec 30, 2020
@aduh95
Copy link
Contributor

aduh95 commented Dec 30, 2020

CI: https://ci.nodejs.org/job/node-test-pull-request/35141/

@aduh95 aduh95 mentioned this pull request Dec 31, 2020
Closed
@aduh95
Copy link
Contributor

aduh95 commented Dec 31, 2020

CI: https://ci.nodejs.org/job/node-test-pull-request/35169/

@yashLadha yashLadha added the request-ci Add this label to start a Jenkins CI on a PR. label Dec 31, 2020
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Dec 31, 2020
@yashLadha yashLadha added the request-ci Add this label to start a Jenkins CI on a PR. label Jan 1, 2021
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jan 1, 2021
@yashLadha
Copy link
Member

CI https://ci.nodejs.org/job/node-test-pull-request/35187/

@rchougule rchougule mentioned this pull request Jan 1, 2021
Closed
2 tasks
@Trott
Copy link
Member

Trott commented Jan 2, 2021 •
edited

Benchmark CI: https://ci.nodejs.org/view/Node.js%20benchmark/job/benchmark-node-micro-benchmarks/856/ (queued, will 404 until it starts running)

@rchougule
Copy link
Contributor Author

Benchmark CI: https://ci.nodejs.org/view/Node.js%20benchmark/job/benchmark-node-micro-benchmarks/856/ (queued, will 404 until it starts running)

Why does it say NA? or am I looking at the wrong place? 😅
image

@aduh95
Copy link
Contributor

aduh95 commented Jan 3, 2021

Why does it say NA? or am I looking at the wrong place? 😅

See #36746

@aduh95 aduh95 added the request-ci Add this label to start a Jenkins CI on a PR. label Jan 3, 2021
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jan 3, 2021
@nodejs-github-bot

This comment has been minimized.

Sign in to view
@nodejs-github-bot

This comment has been minimized.

Sign in to view
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/35270/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/35325/

@rchougule
Copy link
Contributor Author

@aduh95 can you help me understand the further steps here? Just trying to understand what's failing here. Thanks!

@aduh95
Copy link
Contributor

aduh95 commented Jan 6, 2021

can you help me understand the further steps here?

We need to have a green CI in order to land this; the failure on the CI are almost certainly unrelated to the changes introduced by this PR, I've just kicked off another one, hopefully it should be good now.

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/35334/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/35335/

@rchougule
Copy link
Contributor Author

It seems the same checks failed 😓 ... @aduh95

@yashLadha yashLadha added the request-ci Add this label to start a Jenkins CI on a PR. label Jan 8, 2021
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jan 8, 2021
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/35367/

yashLadha pushed a commit that referenced this pull request Jan 9, 2021
@rchougule @yashLadha
http2: refactor to use primordials instead of <string>.indexOf
3af175f 
PR-URL: #36679
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Zeyu Yang <himself65@outlook.com>
Reviewed-By: Pooja D P <Pooja.D.P@ibm.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
@yashLadha
Copy link
Member

Landed in 3af175f

@yashLadha yashLadha closed this Jan 9, 2021
@yashLadha
Copy link
Member

@Trott It seems that multiple PRs are failing for the 3 jobs probably a flakiness issue.

@Trott
Copy link
Member

Trott commented Jan 10, 2021

@Trott It seems that multiple PRs are failing for the 3 jobs probably a flakiness issue.

Yeah, it can be frustrating when CI is broken. If a test is known to be faulty, then a good thing to do is open a fast-track PR to add a line to the .status file telling CI to ignore the test results for that test That's what eventually happened in this case, and that got us back to yellow (and we'll be back to green once nodejs/build#2521 lands).

@Trott

This comment has been minimized.

Sign in to view
@Trott Trott mentioned this pull request Jan 11, 2021
Merged
@yashLadha
Copy link
Member

LGTM @Trott

@Trott
Copy link
Member

Trott commented Jan 11, 2021

Subsequent benchmark of a revert on CI didn't show anything of interest, so this is good.

danielleadams pushed a commit that referenced this pull request Jan 12, 2021
@rchougule @danielleadams
http2: refactor to use primordials instead of <string>.indexOf
a38ad07 
PR-URL: #36679
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Zeyu Yang <himself65@outlook.com>
Reviewed-By: Pooja D P <Pooja.D.P@ibm.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
@danielleadams danielleadams mentioned this pull request Jan 12, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jasnell jasnell jasnell approved these changes

@Trott Trott Trott approved these changes

@Lxxyx Lxxyx Lxxyx approved these changes

@himself65 himself65 himself65 approved these changes

@aduh95 aduh95 aduh95 approved these changes

@PoojaDurgad PoojaDurgad PoojaDurgad approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. http2 Issues or PRs related to the http2 subsystem.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
10 participants
@rchougule @yashLadha @aduh95 @Trott @nodejs-github-bot @jasnell @Lxxyx @himself65 @PoojaDurgad @targos