Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: document common warning types #36713

Closed
wants to merge 1 commit into from
Closed

doc: document common warning types #36713

wants to merge 1 commit into from

Conversation

jasnell
Copy link
Member

@jasnell jasnell commented Dec 31, 2020

Fixes: #24987
Signed-off-by: James M Snell jasnell@gmail.com

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • documentation is changed or added
  • commit message follows commit guidelines

@nodejs-github-bot nodejs-github-bot added doc Issues and PRs related to the documentations. process Issues and PRs related to the process subsystem. labels Dec 31, 2020
RaisinTen
RaisinTen reviewed Jan 1, 2021
View reviewed changes
doc/api/process.md Outdated Show resolved Hide resolved
Trott
Trott reviewed Jan 2, 2021
View reviewed changes
doc/api/process.md Outdated Show resolved Hide resolved
Trott
Trott reviewed Jan 2, 2021
View reviewed changes
doc/api/process.md Outdated Show resolved Hide resolved
jasnell
jasnell commented Jan 2, 2021
View reviewed changes
doc/api/process.md Outdated Show resolved Hide resolved
jasnell
jasnell commented Jan 2, 2021
View reviewed changes
doc/api/process.md Outdated Show resolved Hide resolved
@jasnell
doc: document common warning types
9d1cc32 
Fixes: nodejs#24987
Signed-off-by: James M Snell <jasnell@gmail.com>
@jasnell
Copy link
Member Author

jasnell commented Jan 3, 2021

Landed in 5499caa

@jasnell jasnell closed this Jan 3, 2021
jasnell added a commit that referenced this pull request Jan 3, 2021
@jasnell
doc: document common warning types
5499caa 
Fixes: #24987
Signed-off-by: James M Snell <jasnell@gmail.com>

PR-URL: #36713
Reviewed-By: Rich Trott <rtrott@gmail.com>
danielleadams pushed a commit that referenced this pull request Jan 12, 2021
@jasnell @danielleadams
doc: document common warning types
242ce19 
Fixes: #24987
Signed-off-by: James M Snell <jasnell@gmail.com>

PR-URL: #36713
Reviewed-By: Rich Trott <rtrott@gmail.com>
@danielleadams danielleadams mentioned this pull request Jan 12, 2021
Merged
targos pushed a commit that referenced this pull request May 1, 2021
@jasnell @targos
doc: document common warning types
bcca52c 
Fixes: #24987
Signed-off-by: James M Snell <jasnell@gmail.com>

PR-URL: #36713
Reviewed-By: Rich Trott <rtrott@gmail.com>
@danielleadams danielleadams mentioned this pull request May 3, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RaisinTen RaisinTen RaisinTen left review comments

@Trott Trott Trott approved these changes

Assignees
No one assigned
Labels
doc Issues and PRs related to the documentations. process Issues and PRs related to the process subsystem.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Request for warning documentation
4 participants
@jasnell @Trott @RaisinTen @nodejs-github-bot