Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

benchmark: fix http/headers.js with test-double #36794

Closed
wants to merge 1 commit into from
Closed

benchmark: fix http/headers.js with test-double #36794

wants to merge 1 commit into from

Commits on Jan 7, 2021

  1. benchmark: fix http/headers.js with test-double 

    The http/headers.js benchmark fails if wrk or autocannon are not
installed. This is because the benchmark exceeds the default permissible
length for HTTP headers. Reduce the largest benchmarks to fit within the
8192 default as that is what we should be optimizing for.

Fixes: nodejs#31022

PR-URL: nodejs#36794
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com>
    @Trott
    Trott committed Jan 7, 2021
    Copy the full SHA
    1e35d58 View commit details
    Browse the repository at this point in the history