Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: increase fs promise coverage #36813

Closed
wants to merge 4 commits into from
Closed

test: increase fs promise coverage #36813

wants to merge 4 commits into from

Commits on Jan 6, 2021

  1. test: increase fs promise coverage 

    1. Signal aborted while writing file
Refs: https://coverage.nodejs.org/coverage-0b6d3070a176d437/lib/internal/fs/promises.js.html#L278

2. Signal aborted on first tick
Refs: https://coverage.nodejs.org/coverage-0b6d3070a176d437/lib/internal/fs/promises.js.html#L301

3. Validate file size is withing range for reading
Refs: https://coverage.nodejs.org/coverage-0b6d3070a176d437/lib/internal/fs/promises.js.html#L312

4. Signal aborted right before buffer read
Refs: https://coverage.nodejs.org/coverage-0b6d3070a176d437/lib/internal/fs/promises.js.html#L321

5. Use fallback buffer allocation when input not buffer
Refs: https://coverage.nodejs.org/coverage-0b6d3070a176d437/lib/internal/fs/promises.js.html#L374

6. Specify symlink type
Refs: https://coverage.nodejs.org/coverage-0b6d3070a176d437/lib/internal/fs/promises.js.html#L539

7. Set modification times with lutimes
Refs: https://coverage.nodejs.org/coverage-0b6d3070a176d437/lib/internal/fs/promises.js.html#L635

8. Use fallback encoding when input is null
Refs: https://coverage.nodejs.org/coverage-0b6d3070a176d437/lib/internal/fs/promises.js.html#L665

9. Use fallback flag when input is null
Refs: https://coverage.nodejs.org/coverage-0b6d3070a176d437/lib/internal/fs/promises.js.html#L681
    @emilsivervik
    emilsivervik committed Jan 6, 2021
    Copy the full SHA
    9a75a24 View commit details
    Browse the repository at this point in the history

  2. test: fix typo 

    Co-authored-by: Richard Lau <rlau@redhat.com>
    @emilsivervik @richardlau
    emilsivervik and richardlau committed Jan 6, 2021
    Copy the full SHA
    95a48bc View commit details
    Browse the repository at this point in the history

Commits on Jan 19, 2021

  1. test: add await for rejects 

    Co-authored-by: Antoine du Hamel <duhamelantoine1995@gmail.com>
    @emilsivervik @aduh95
    emilsivervik and aduh95 committed Jan 19, 2021
    Copy the full SHA
    622ed80 View commit details
    Browse the repository at this point in the history

Commits on Jan 25, 2021

  1. test: change function to write to file 

    Co-authored-by: Darshan Sen <raisinten@gmail.com>
    @emilsivervik @RaisinTen
    emilsivervik and RaisinTen committed Jan 25, 2021
    Copy the full SHA
    937c371 View commit details
    Browse the repository at this point in the history