Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[v10.x backport] doc: add release key for Richard Lau #36835

Closed
wants to merge 1 commit into from

Conversation

kmur911
Copy link

@kmur911 kmur911 commented Jan 8, 2021

Because Richard Lau published 10.23.1 we need his public key added to the README to prevent gpg errors when people try to verify the signature.

Note: this is my first PR to this repo, I'm not sure if I should be merging the fix into this branch or somewhere else, really I want it associated with the 10.23.1 tag but I don't see one.

Because Richard Lau published 10.23.1 we need his
public key added to the README to prevent gpg
errors when people try to verify the signature.
@nodejs-github-bot nodejs-github-bot added doc Issues and PRs related to the documentations. v10.x labels Jan 8, 2021
@aduh95
Copy link
Contributor

aduh95 commented Jan 8, 2021

What you want is to backport #34397. Backporting PRs needs to follow a set of rules described in https://github.com/nodejs/node/blob/master/doc/guides/backporting-to-release-lines.md.

We may want to add some checks in the future to make sure that changes to release keys have been backported before each release.

/cc @nodejs/lts @richardlau

@aduh95 aduh95 changed the base branch from v10.x to v10.x-staging January 8, 2021 10:01
@aduh95 aduh95 changed the title doc: add richard lau pub key to 10.x for 10.23.1 [v10.x backport] doc: add release key for Richard Lau Jan 8, 2021
@richardlau
Copy link
Member

Since #34397 cherry-picks cleanly onto v10.x-staging I've done so (b8426ae). I've no idea when we'd release it -- maybe with a backport/cherry-pick of #36838?
cc @nodejs/lts

@richardlau richardlau closed this Jan 8, 2021
@kmur911 kmur911 deleted the v10.x branch January 8, 2021 18:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
doc Issues and PRs related to the documentations.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants