Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deps: update nghttp2 to 1.42.0 #36842

Closed
wants to merge 1 commit into from
Closed

Conversation

targos
Copy link
Member

@targos targos commented Jan 8, 2021

@nodejs-github-bot nodejs-github-bot added build Issues and PRs related to build files or the CI. http2 Issues or PRs related to the http2 subsystem. labels Jan 8, 2021
@targos targos added the request-ci Add this label to start a Jenkins CI on a PR. label Jan 8, 2021
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jan 8, 2021
@nodejs-github-bot
Copy link
Collaborator

@targos
Copy link
Member Author

targos commented Jan 8, 2021

/cc @nodejs/http2

Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Member

@Trott Trott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rubber stamp LGTM

@targos targos added the request-ci Add this label to start a Jenkins CI on a PR. label Jan 10, 2021
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jan 10, 2021
@nodejs-github-bot
Copy link
Collaborator

targos added a commit that referenced this pull request Jan 11, 2021
Refs: https://github.com/nghttp2/nghttp2/releases/tag/v1.42.0

PR-URL: #36842
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
@targos
Copy link
Member Author

targos commented Jan 11, 2021

Landed in 6b18987

@targos targos closed this Jan 11, 2021
@targos targos deleted the nghttp2-v1.42.0 branch January 11, 2021 07:15
danielleadams pushed a commit that referenced this pull request Jan 12, 2021
Refs: https://github.com/nghttp2/nghttp2/releases/tag/v1.42.0

PR-URL: #36842
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
@danielleadams danielleadams mentioned this pull request Jan 12, 2021
targos added a commit that referenced this pull request May 1, 2021
Refs: https://github.com/nghttp2/nghttp2/releases/tag/v1.42.0

PR-URL: #36842
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
@danielleadams danielleadams mentioned this pull request May 3, 2021
codebytere added a commit to electron/electron that referenced this pull request May 14, 2021
codebytere added a commit to electron/electron that referenced this pull request May 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build Issues and PRs related to build files or the CI. http2 Issues or PRs related to the http2 subsystem.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants