Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

lib: simplify primordials.uncurryThis #36866

Merged
merged 1 commit into from Jan 12, 2021
Merged

lib: simplify primordials.uncurryThis #36866

merged 1 commit into from Jan 12, 2021

Conversation

ExE-Boss
Copy link
Contributor

@ExE-Boss ExE-Boss commented Jan 10, 2021 •
edited

While working on #36865, it occurred to me that:

Function.prototype.call.bind(Function.prototype.bind, Function.prototype.call)

is equivalent to:

Function.prototype.bind.bind(Function.prototype.call)

except that it saves us one indirection through Function.prototype.call.

@aduh95 aduh95 added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. request-ci Add this label to start a Jenkins CI on a PR. labels Jan 10, 2021
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jan 10, 2021
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/35426/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/35432/

@ExE-Boss @aduh95
lib: simplify primordials.uncurryThis
1a0c5d5 
PR-URL: nodejs#36866
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Pooja D P <Pooja.D.P@ibm.com>
@aduh95 aduh95 force-pushed the lib/primordials/simplify-uncurry-this branch from 324ea00 to 1a0c5d5 Compare January 12, 2021 13:48
@aduh95
Copy link
Contributor

aduh95 commented Jan 12, 2021

Landed in 1a0c5d5

@aduh95 aduh95 merged commit 1a0c5d5 into nodejs:master Jan 12, 2021
@ExE-Boss ExE-Boss deleted the lib/primordials/simplify-uncurry-this branch January 12, 2021 15:14
danielleadams pushed a commit that referenced this pull request Jan 13, 2021
@ExE-Boss @danielleadams
lib: simplify primordials.uncurryThis
1db3772 
PR-URL: #36866
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Pooja D P <Pooja.D.P@ibm.com>
@danielleadams danielleadams mentioned this pull request Jan 13, 2021
Merged
targos pushed a commit that referenced this pull request May 25, 2021
@ExE-Boss @targos
lib: simplify primordials.uncurryThis
7cc1f0d 
PR-URL: #36866
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Pooja D P <Pooja.D.P@ibm.com>
targos pushed a commit that referenced this pull request May 30, 2021
@ExE-Boss @targos
lib: simplify primordials.uncurryThis
1407459 
PR-URL: #36866
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Pooja D P <Pooja.D.P@ibm.com>
targos pushed a commit that referenced this pull request Jun 5, 2021
@ExE-Boss @targos
lib: simplify primordials.uncurryThis
8cbd4cf 
PR-URL: #36866
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Pooja D P <Pooja.D.P@ibm.com>
@targos targos mentioned this pull request Jun 6, 2021
Merged
targos pushed a commit that referenced this pull request Jun 11, 2021
@ExE-Boss @targos
lib: simplify primordials.uncurryThis
6eaf357 
PR-URL: #36866
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Pooja D P <Pooja.D.P@ibm.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jasnell jasnell jasnell approved these changes

@addaleax addaleax addaleax approved these changes

@Lxxyx Lxxyx Lxxyx approved these changes

@aduh95 aduh95 aduh95 approved these changes

@PoojaDurgad PoojaDurgad PoojaDurgad approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@ExE-Boss @nodejs-github-bot @aduh95 @jasnell @addaleax @Lxxyx @PoojaDurgad