Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: fix indentation on http2 doc entry #36869

Closed
wants to merge 1 commit into from
Closed

doc: fix indentation on http2 doc entry #36869

wants to merge 1 commit into from

Conversation

Trott
Copy link
Member

@Trott Trott commented Jan 10, 2021

No description provided.

@nodejs-github-bot nodejs-github-bot added doc Issues and PRs related to the documentations. http2 Issues or PRs related to the http2 subsystem. labels Jan 10, 2021
@PoojaDurgad PoojaDurgad added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Jan 13, 2021
@Trott
doc: fix indentation on http2 doc entry
99580bd 
PR-URL: nodejs#36869
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Pooja D P <Pooja.D.P@ibm.com>
Reviewed-By: Harshitha K P <harshitha014@gmail.com>
Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com>
@Trott
Copy link
Member Author

Trott commented Jan 13, 2021

Landed in 99580bd

@Trott Trott closed this Jan 13, 2021
@Trott Trott deleted the fix-doc branch January 13, 2021 12:43
ruyadorno pushed a commit that referenced this pull request Jan 22, 2021
@Trott @ruyadorno
doc: fix indentation on http2 doc entry
02a8f52 
PR-URL: #36869
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Pooja D P <Pooja.D.P@ibm.com>
Reviewed-By: Harshitha K P <harshitha014@gmail.com>
Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com>
@ruyadorno ruyadorno mentioned this pull request Jan 22, 2021
Merged
targos pushed a commit that referenced this pull request May 1, 2021
@Trott @targos
doc: fix indentation on http2 doc entry
9a3cfa7 
PR-URL: #36869
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Pooja D P <Pooja.D.P@ibm.com>
Reviewed-By: Harshitha K P <harshitha014@gmail.com>
Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com>
@danielleadams danielleadams mentioned this pull request May 3, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@watilde watilde watilde approved these changes

@aduh95 aduh95 aduh95 approved these changes

@HarshithaKP HarshithaKP HarshithaKP approved these changes

@PoojaDurgad PoojaDurgad PoojaDurgad approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. doc Issues and PRs related to the documentations. http2 Issues or PRs related to the http2 subsystem.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@Trott @watilde @aduh95 @HarshithaKP @PoojaDurgad @nodejs-github-bot