Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[v14.x Backport] http: don't cork noop .end() #36940

Closed
wants to merge 3 commits into from
Closed

[v14.x Backport] http: don't cork noop .end() #36940

wants to merge 3 commits into from

Commits on Jan 15, 2021

  1. test: http complete response after socket double end 

    PR-URL: nodejs#36633
Fixes: nodejs#36620
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Danielle Adams <adamzdanielle@gmail.com>
(cherry picked from commit ec794f9)
    @mitsos1os
    mitsos1os committed Jan 15, 2021
    Configuration menu
    Copy the full SHA
    71aed6b View commit details
    Browse the repository at this point in the history

  2. test: assert http writable corked state after end

    @mitsos1os
    mitsos1os committed Jan 15, 2021
    Configuration menu
    Copy the full SHA
    5f944b9 View commit details
    Browse the repository at this point in the history

  3. http: don't cork .end when not needed

    @mitsos1os
    mitsos1os committed Jan 15, 2021
    Configuration menu
    Copy the full SHA
    dccef0f View commit details
    Browse the repository at this point in the history