Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: clarify maxSockets option of http.Agent #36941

Closed
wants to merge 1 commit into from
Closed

doc: clarify maxSockets option of http.Agent #36941

wants to merge 1 commit into from

Conversation

PoojaDurgad
Copy link
Contributor

fixes: #36463

@nodejs-github-bot nodejs-github-bot added doc Issues and PRs related to the documentations. http Issues or PRs related to the http subsystem. labels Jan 15, 2021
@aduh95 aduh95 added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Jan 18, 2021
jasnell pushed a commit that referenced this pull request Jan 18, 2021
@PoojaDurgad @jasnell
doc: clarify maxSockets option of http.Agent
090f0cd 
PR-URL: #36941
Fixes: #36463
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
@jasnell
Copy link
Member

jasnell commented Jan 18, 2021

Landed in 090f0cd

@jasnell jasnell closed this Jan 18, 2021
ruyadorno pushed a commit that referenced this pull request Jan 22, 2021
@PoojaDurgad @ruyadorno
doc: clarify maxSockets option of http.Agent
5693ed9 
PR-URL: #36941
Fixes: #36463
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
@ruyadorno ruyadorno mentioned this pull request Jan 22, 2021
Merged
ruyadorno pushed a commit that referenced this pull request Jan 25, 2021
@PoojaDurgad @ruyadorno
doc: clarify maxSockets option of http.Agent
7ea374b 
PR-URL: #36941
Fixes: #36463
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
targos pushed a commit that referenced this pull request May 1, 2021
@PoojaDurgad @targos
doc: clarify maxSockets option of http.Agent
385d0df 
PR-URL: #36941
Fixes: #36463
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
@danielleadams danielleadams mentioned this pull request May 3, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jasnell jasnell jasnell approved these changes

@aduh95 aduh95 aduh95 approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. doc Issues and PRs related to the documentations. http Issues or PRs related to the http subsystem.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

doc: http.Agent, reuse single socket vs new socket for each request
4 participants
@PoojaDurgad @jasnell @aduh95 @nodejs-github-bot