Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v15.7.0 proposal #37020

Merged
merged 81 commits into from Jan 26, 2021
Merged

v15.7.0 proposal #37020

merged 81 commits into from Jan 26, 2021

Commits on Jan 21, 2021

  1. doc: fix indentation on http2 doc entry

    PR-URL: #36869
    Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
    Reviewed-By: Pooja D P <Pooja.D.P@ibm.com>
    Reviewed-By: Harshitha K P <harshitha014@gmail.com>
    Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com>
    Trott authored and ruyadorno committed Jan 21, 2021
    Configuration menu
    Copy the full SHA
    02a8f52 View commit details
    Browse the repository at this point in the history
  2. fs: allow position parameter to be a BigInt in read and readSync

    Fixes: #36185
    
    PR-URL: #36190
    Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    Reviewed-By: Zeyu Yang <himself65@outlook.com>
    Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
    Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
    RaisinTen authored and ruyadorno committed Jan 21, 2021
    Configuration menu
    Copy the full SHA
    c4cdf1d View commit details
    Browse the repository at this point in the history
  3. crypto: fix WebCrypto import of RSA-PSS keys

    This patch changes GetRsaKeyDetail to work in older supported versions
    of OpenSSL.
    
    Refs: openssl/openssl#10217
    
    PR-URL: #36877
    Refs: #36188
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Filip Skokan <panva.ip@gmail.com>
    Reviewed-By: Richard Lau <rlau@redhat.com>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    tniessen authored and ruyadorno committed Jan 21, 2021
    Configuration menu
    Copy the full SHA
    0398167 View commit details
    Browse the repository at this point in the history
  4. worker: refactor to avoid unsafe array iteration

    PR-URL: #36735
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    aduh95 authored and ruyadorno committed Jan 21, 2021
    Configuration menu
    Copy the full SHA
    bf695eb View commit details
    Browse the repository at this point in the history
  5. vm: refactor to avoid unsafe array iteration

    PR-URL: #36752
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    aduh95 authored and ruyadorno committed Jan 21, 2021
    Configuration menu
    Copy the full SHA
    0d71947 View commit details
    Browse the repository at this point in the history
  6. lib: refactor source_map to avoid unsafe array iteration

    PR-URL: #36734
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Pooja D P <Pooja.D.P@ibm.com>
    aduh95 authored and ruyadorno committed Jan 21, 2021
    Configuration menu
    Copy the full SHA
    1ef92f6 View commit details
    Browse the repository at this point in the history
  7. zlib: refactor to avoid unsafe array iteration

    PR-URL: #36722
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Pooja D P <Pooja.D.P@ibm.com>
    aduh95 authored and ruyadorno committed Jan 21, 2021
    Configuration menu
    Copy the full SHA
    403b595 View commit details
    Browse the repository at this point in the history
  8. lib: refactor source_map to use more primordials

    PR-URL: #36733
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    aduh95 authored and ruyadorno committed Jan 21, 2021
    Configuration menu
    Copy the full SHA
    b86c48c View commit details
    Browse the repository at this point in the history
  9. doc: change "it's" to "its" where necessary

    PR-URL: #36913
    Reviewed-By: Richard Lau <rlau@redhat.com>
    Reviewed-By: Michaël Zasso <targos@protonmail.com>
    Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Pooja D P <Pooja.D.P@ibm.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    tniessen authored and ruyadorno committed Jan 21, 2021
    Configuration menu
    Copy the full SHA
    70cd43c View commit details
    Browse the repository at this point in the history
  10. doc: update fs.l/statSync API history for throwIfNoEntry

    PR-URL: #36882
    Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    amcasey authored and ruyadorno committed Jan 21, 2021
    Configuration menu
    Copy the full SHA
    82eccdd View commit details
    Browse the repository at this point in the history
  11. crypto: add keyObject.asymmetricKeyDetails for asymmetric keys

    This API exposes key details. It is conceptually different from the
    previously discussed keyObject.fields property since it does not give
    access to information that could compromise the security of the key, and
    the obtained information cannot be used to uniquely identify a key.
    
    The intended purpose is to determine "security properties" of keys, e.g.
    to generate a new key pair with the same parameters, or to decide
    whether a key is secure enough.
    
    closes #30045
    
    PR-URL: #36188
    Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
    Reviewed-By: Tobias Nießen <tniessen@tnie.de>
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    panva authored and ruyadorno committed Jan 21, 2021
    Configuration menu
    Copy the full SHA
    1149af6 View commit details
    Browse the repository at this point in the history
  12. doc: wrap TOC in a <details> tag

    PR-URL: #36896
    Fixes: #36885
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
    Mattia Pontonio authored and ruyadorno committed Jan 21, 2021
    Configuration menu
    Copy the full SHA
    f99b38f View commit details
    Browse the repository at this point in the history
  13. doc: remove unnecessary contributing.md section

    Remove "How to Contribute in Issues". This is not Node.js-specific and
    is likely to cause many readers to tune out. If we want to include this
    kind of how-all-issue-trackers-are-intended-to-work information, let's
    link to an external source. But I think it's OK to simply remove it.
    
    Refs: nodejs/TSC#864 (comment)
    
    PR-URL: #36891
    Reviewed-By: Michaël Zasso <targos@protonmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Michael Dawson <midawson@redhat.com>
    Trott authored and ruyadorno committed Jan 21, 2021
    Configuration menu
    Copy the full SHA
    5cbf638 View commit details
    Browse the repository at this point in the history
  14. crypto: fix randomInt bias

    Co-authored-by: Andrey Pechkurov <apechkurov@gmail.com>
    
    PR-URL: #36894
    Refs: #34600
    Reviewed-By: Andrey Pechkurov <apechkurov@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    tniessen authored and ruyadorno committed Jan 21, 2021
    Configuration menu
    Copy the full SHA
    b7d8e61 View commit details
    Browse the repository at this point in the history
  15. doc: update tls test to use better terminology

    Given the effort to change the master branch to main,
    this may make sense as part of removing other references
    to the offending wording as well.
    
    Signed-off-by: Michael Dawson <mdawson@devrus.com>
    
    PR-URL: #36851
    Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    mhdawson authored and ruyadorno committed Jan 21, 2021
    Configuration menu
    Copy the full SHA
    e73b107 View commit details
    Browse the repository at this point in the history
  16. tls: use recently added matching SecureContext in default SNICallback

    PR-URL: #36072
    Fixes: #34110
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
    mkrawczuk authored and ruyadorno committed Jan 21, 2021
    Configuration menu
    Copy the full SHA
    864b97b View commit details
    Browse the repository at this point in the history
  17. doc: add miladfarca to collaborators

    PR-URL: #36934
    Reviewed-By: Michael Dawson <midawson@redhat.com>
    Reviewed-By: Richard Lau <rlau@redhat.com>
    Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de>
    Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    Reviewed-By: Pooja D P <Pooja.D.P@ibm.com>
    miladfarca authored and ruyadorno committed Jan 21, 2021
    Configuration menu
    Copy the full SHA
    80c84a1 View commit details
    Browse the repository at this point in the history
  18. doc: add alternative version links to the packages page

    PR-URL: #36915
    Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
    Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
    panva authored and ruyadorno committed Jan 21, 2021
    Configuration menu
    Copy the full SHA
    22e29cc View commit details
    Browse the repository at this point in the history
  19. test: fix variable name for non-RSA keys

    PR-URL: #36912
    Reviewed-By: Filip Skokan <panva.ip@gmail.com>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    tniessen authored and ruyadorno committed Jan 21, 2021
    Configuration menu
    Copy the full SHA
    30b2aac View commit details
    Browse the repository at this point in the history
  20. test: check mustCall errors in test-fs-read-type

    PR-URL: #36914
    Refs: #36190
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Richard Lau <rlau@redhat.com>
    Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    tniessen authored and ruyadorno committed Jan 21, 2021
    Configuration menu
    Copy the full SHA
    c2ec15a View commit details
    Browse the repository at this point in the history
  21. http2: refactor to avoid unsafe array iteration

    PR-URL: #36700
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    aduh95 authored and ruyadorno committed Jan 21, 2021
    Configuration menu
    Copy the full SHA
    f5b8e7b View commit details
    Browse the repository at this point in the history
  22. doc: fixup typo in metadata entry

    PR-URL: #36947
    Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
    Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
    jasnell authored and ruyadorno committed Jan 21, 2021
    Configuration menu
    Copy the full SHA
    aa3bc74 View commit details
    Browse the repository at this point in the history
  23. doc: add iansu to collaborators

    PR-URL: #36951
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    Reviewed-By: Myles Borins <myles.borins@gmail.com>
    iansu authored and ruyadorno committed Jan 21, 2021
    Configuration menu
    Copy the full SHA
    5a9a07e View commit details
    Browse the repository at this point in the history
  24. tools: add support for top-level await syntax in linter

    PR-URL: #36911
    Reviewed-By: Michaël Zasso <targos@protonmail.com>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    aduh95 authored and ruyadorno committed Jan 21, 2021
    Configuration menu
    Copy the full SHA
    8dc8adc View commit details
    Browse the repository at this point in the history
  25. doc: use ESM syntax for WASI example

    PR-URL: #36848
    Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Guy Bedford <guybedford@gmail.com>
    aduh95 authored and ruyadorno committed Jan 21, 2021
    Configuration menu
    Copy the full SHA
    707b973 View commit details
    Browse the repository at this point in the history
  26. doc: remove resolving-a-bug-report from contributing docs

    This section isn't particularly useful in this context and contributes
    to making the document longer and less effective. This is part of a
    larger effort to make the contributing docs brief, informative, and
    friendly.
    
    Refs: nodejs/TSC#864 (comment)
    
    PR-URL: #36905
    Reviewed-By: Michaël Zasso <targos@protonmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Tobias Nießen <tniessen@tnie.de>
    Trott authored and ruyadorno committed Jan 21, 2021
    1 Configuration menu
    Copy the full SHA
    7a79441 View commit details
    Browse the repository at this point in the history
  27. doc: remove issue template duplication from contributing docs

    The replicated issue template is out of date. There isn't much reason to
    replicate it here anyway, so let's remove it and describe what the user
    should do briefly.
    
    PR-URL: #36908
    Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com>
    Reviewed-By: Pooja D P <Pooja.D.P@ibm.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
    Trott authored and ruyadorno committed Jan 21, 2021
    Configuration menu
    Copy the full SHA
    eaf378a View commit details
    Browse the repository at this point in the history
  28. http: cleanup ClientRequest oncreate

    PR-URL: #36862
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
    Reviewed-By: Daniele Belardi <dwon.dnl@gmail.com>
    ronag authored and ruyadorno committed Jan 21, 2021
    Configuration menu
    Copy the full SHA
    80051ab View commit details
    Browse the repository at this point in the history
  29. http: refactor ClientRequest destroy

    PR-URL: #36863
    Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
    ronag authored and ruyadorno committed Jan 21, 2021
    Configuration menu
    Copy the full SHA
    aa7243e View commit details
    Browse the repository at this point in the history
  30. test: fixup flaky test-crypto-x509 on windows

    PR-URL: #36966
    Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    jasnell authored and ruyadorno committed Jan 21, 2021
    Configuration menu
    Copy the full SHA
    99c1590 View commit details
    Browse the repository at this point in the history
  31. doc: fix invalid HTML in doc template

    Move the script tag for dark mode support inside the body tag.
    
    PR-URL: #36930
    Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
    Reviewed-By: Richard Lau <rlau@redhat.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Trott authored and ruyadorno committed Jan 21, 2021
    Configuration menu
    Copy the full SHA
    3ea37c2 View commit details
    Browse the repository at this point in the history
  32. url: expose urlToHttpOptions utility

    PR-URL: #35960
    Fixes: #34349
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Michaël Zasso <targos@protonmail.com>
    ZYSzys authored and ruyadorno committed Jan 21, 2021
    Configuration menu
    Copy the full SHA
    64fed31 View commit details
    Browse the repository at this point in the history
  33. lib: refactor primordials.makeSafe to use more primordials

    PR-URL: #36865
    Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
    ExE-Boss authored and ruyadorno committed Jan 21, 2021
    Configuration menu
    Copy the full SHA
    850d357 View commit details
    Browse the repository at this point in the history
  34. lib: expose primordials object

    Expose the internal `primordials` object to help with Node.js core
    development.
    
    ```console
    $ node --expose-internals -r internal/test/binding lib/fs.js
    (node:5299) internal/test/binding: These APIs are for internal testing
    only. Do not use them.
    (Use `node --trace-warnings ...` to show where the warning was created)
    ```
    
    PR-URL: #36872
    Reviewed-By: Bradley Farias <bradley.meck@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    aduh95 authored and ruyadorno committed Jan 21, 2021
    Configuration menu
    Copy the full SHA
    f2ac4bb View commit details
    Browse the repository at this point in the history
  35. Revert "test: mark test-cluster-bind-privileged-port flaky on arm"

    This reverts commit a45a404.
    
    Solved by marking ports <1024 as privileged on Docker containers.
    
    Ref: #36850
    Ref: #36847
    Ref: nodejs/build#2521
    
    PR-URL: #36884
    Refs: #36850
    Refs: #36847
    Refs: nodejs/build#2521
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
    Reviewed-By: Richard Lau <rlau@redhat.com>
    Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com>
    Reviewed-By: Ash Cripps <acripps@redhat.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    Reviewed-By: Michael Dawson <midawson@redhat.com>
    rvagg authored and ruyadorno committed Jan 21, 2021
    Configuration menu
    Copy the full SHA
    8a82415 View commit details
    Browse the repository at this point in the history
  36. test: improve coverage at lib/internal/vm/module.js

    PR-URL: #36898
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: Michael Dawson <midawson@redhat.com>
    juanarbol authored and ruyadorno committed Jan 21, 2021
    Configuration menu
    Copy the full SHA
    f589bb2 View commit details
    Browse the repository at this point in the history
  37. url: align url format behavior with browsers

    Fixes: #36887
    
    PR-URL: #36903
    Reviewed-By: Michaël Zasso <targos@protonmail.com>
    Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
    Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
    Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com>
    Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com>
    Lxxyx authored and ruyadorno committed Jan 21, 2021
    Configuration menu
    Copy the full SHA
    889654d View commit details
    Browse the repository at this point in the history
  38. doc: improve perf_hooks docs

    PR-URL: #36909
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
    juanarbol authored and ruyadorno committed Jan 21, 2021
    Configuration menu
    Copy the full SHA
    8cf280d View commit details
    Browse the repository at this point in the history
  39. test: improve coverage on worker threads

    PR-URL: #36910
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
    juanarbol authored and ruyadorno committed Jan 21, 2021
    Configuration menu
    Copy the full SHA
    3bbe9a5 View commit details
    Browse the repository at this point in the history
  40. test: skip internet for test-npm-install

    Disabling any internet-required features (namely audit and
    update-notifer) in order for the test to work without an internet
    connection.
    
    - Fixes: #36895
    
    PR-URL: #36933
    Reviewed-By: Richard Lau <rlau@redhat.com>
    Reviewed-By: Michael Dawson <midawson@redhat.com>
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Myles Borins <myles.borins@gmail.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    ruyadorno committed Jan 21, 2021
    Configuration menu
    Copy the full SHA
    c7dd9c8 View commit details
    Browse the repository at this point in the history
  41. doc: fix percentile range in perf_hooks.md

    The value accepted by histogram.percentile may be below 1 too.
    
    PR-URL: #36938
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
    RaisinTen authored and ruyadorno committed Jan 21, 2021
    Configuration menu
    Copy the full SHA
    af0f0a0 View commit details
    Browse the repository at this point in the history
  42. test: improve coverage for Module getters

    PR-URL: #36950
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
    juanarbol authored and ruyadorno committed Jan 21, 2021
    Configuration menu
    Copy the full SHA
    ba87be0 View commit details
    Browse the repository at this point in the history
  43. buffer: add base64url encoding option

    PR-URL: #36952
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
    panva authored and ruyadorno committed Jan 21, 2021
    Configuration menu
    Copy the full SHA
    832cd01 View commit details
    Browse the repository at this point in the history
  44. deps: upgrade npm to 7.4.2

    PR-URL: #36953
    Reviewed-By: Myles Borins <myles.borins@gmail.com>
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: Michaël Zasso <targos@protonmail.com>
    ruyadorno committed Jan 21, 2021
    Configuration menu
    Copy the full SHA
    6f773fb View commit details
    Browse the repository at this point in the history
  45. tools: update ESLint to 7.18.0

    Update ESLint to 7.18.0
    
    PR-URL: #36955
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
    Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com>
    Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: Michaël Zasso <targos@protonmail.com>
    cjihrig authored and ruyadorno committed Jan 21, 2021
    Configuration menu
    Copy the full SHA
    8e02b53 View commit details
    Browse the repository at this point in the history
  46. doc: fix grammar and link to QUIC in changelog

    PR-URL: #36959
    Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    Reviewed-By: Pooja D P <Pooja.D.P@ibm.com>
    Reviewed-By: Harshitha K P <harshitha014@gmail.com>
    dandv authored and ruyadorno committed Jan 21, 2021
    Configuration menu
    Copy the full SHA
    120db2c View commit details
    Browse the repository at this point in the history
  47. doc: fix crypto.generateKeySync aes allowed length list

    PR-URL: #36928
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Tobias Nießen <tniessen@tnie.de>
    panva authored and ruyadorno committed Jan 21, 2021
    Configuration menu
    Copy the full SHA
    48b6781 View commit details
    Browse the repository at this point in the history

Commits on Jan 25, 2021

  1. deps: V8: cherry-pick fe191e8d05cc

    Original commit message:
    
        [coverage] optional chaining coverage
    
        Implement coverage tracking for optional chains.
    
        Bug: v8:10060
        Change-Id: I4f29eda64b6d859939f5f58f4fabead649905795
        Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2573013
        Reviewed-by: Leszek Swirski <leszeks@chromium.org>
        Reviewed-by: Toon Verwaest <verwaest@chromium.org>
        Reviewed-by: Gus Caplan <snek@chromium.org>
        Reviewed-by: Sigurd Schneider <sigurds@chromium.org>
        Commit-Queue: Benjamin Coe <bencoe@google.com>
        Cr-Commit-Position: refs/heads/master@{#72075}
    
    Refs: v8/v8@fe191e8
    
    PR-URL: #36956
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    Reviewed-By: Michaël Zasso <targos@protonmail.com>
    bcoe authored and ruyadorno committed Jan 25, 2021
    Configuration menu
    Copy the full SHA
    ca479b9 View commit details
    Browse the repository at this point in the history
  2. doc: fix module.isPreloading documentation

    Fixes: #36775
    
    PR-URL: #36944
    Refs: #36263
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    aduh95 authored and ruyadorno committed Jan 25, 2021
    Configuration menu
    Copy the full SHA
    d2d9ad7 View commit details
    Browse the repository at this point in the history
  3. events: remove error listener on signal abort

    Fixes: #36949
    
    PR-URL: #36969
    Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
    Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Lxxyx authored and ruyadorno committed Jan 25, 2021
    Configuration menu
    Copy the full SHA
    dc596d0 View commit details
    Browse the repository at this point in the history
  4. doc: remove pull-requests.md preamble

    Refs: nodejs/TSC#864 (comment)
    
    PR-URL: #36960
    Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Tobias Nießen <tniessen@tnie.de>
    Trott authored and ruyadorno committed Jan 25, 2021
    Configuration menu
    Copy the full SHA
    f3637d5 View commit details
    Browse the repository at this point in the history
  5. doc: clarify maxSockets option of http.Agent

    PR-URL: #36941
    Fixes: #36463
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
    PoojaDurgad authored and ruyadorno committed Jan 25, 2021
    Configuration menu
    Copy the full SHA
    7ea374b View commit details
    Browse the repository at this point in the history
  6. module: simplify tryStatSync with throwIfNoEntry option

    PR-URL: #36971
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    aduh95 authored and ruyadorno committed Jan 25, 2021
    Configuration menu
    Copy the full SHA
    5290d63 View commit details
    Browse the repository at this point in the history
  7. doc: add performance notes for fs.readFile

    Issue #25741 discusses a number of
    performance considerations for fs.readFile, which was changed in Node.js
    10.x to split discreet chunk reads over multiple event loop turns. While
    the fs.readFile() operation is certainly slower than it was pre 10.x,
    it's unlikely to be faster. Document the performance consideration and
    link back to the issue for more in depth analysis.
    
    Signed-off-by: James M Snell <jasnell@gmail.com>
    Fixes: #25741
    
    PR-URL: #36880
    Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
    jasnell authored and ruyadorno committed Jan 25, 2021
    Configuration menu
    Copy the full SHA
    93fc295 View commit details
    Browse the repository at this point in the history
  8. repl: refactor to avoid unsafe array iteration

    PR-URL: #36663
    Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    RaisinTen authored and ruyadorno committed Jan 25, 2021
    Configuration menu
    Copy the full SHA
    9951dae View commit details
    Browse the repository at this point in the history
  9. perf_hooks: throw ERR_INVALID_ARG_VALUE if histogram.percentile param…

    … is NaN
    
    Fixes: #36936
    
    PR-URL: #36937
    Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Lxxyx authored and ruyadorno committed Jan 25, 2021
    Configuration menu
    Copy the full SHA
    3f75a60 View commit details
    Browse the repository at this point in the history
  10. test: remove unused ecdhPeerKey

    This commit removed ecdhPeerKey from test-webcrypto-wrap-unwrap.js which
    seems to be unsued.
    
    PR-URL: #36942
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    danbev authored and ruyadorno committed Jan 25, 2021
    Configuration menu
    Copy the full SHA
    98369aa View commit details
    Browse the repository at this point in the history
  11. test: fix warning in test_environment.cc

    ```
    warning log:
    ../test/cctest/test_environment.cc: In constructor   \
    ‘RedirectStdErr::RedirectStdErr(const char*)’:
    ../test/cctest/test_environment.cc:77:12: warning:   \
    ignoring return value of ‘FILE* freopen(const char*, \
    const char*, FILE*)’, declared with attribute
    warn_unused_result [-Wunused-result]
         freopen(filename_, "w", stderr);
         ~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~
    ```
    
    PR-URL: #36846
    Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    RaisinTen authored and ruyadorno committed Jan 25, 2021
    Configuration menu
    Copy the full SHA
    8d49ce9 View commit details
    Browse the repository at this point in the history
  12. os: performance improvement in vector allocation

    We were using the result vector with an object which is not a primitive
    data type, and going with the constructor allocation pattern it creates
    a size of that vector and also initializes the spaces with the data type
    as well which is in our case is `Local<Value>`. It leads to waste of
    some CPU cycles and instead we just wanted to have some reserved space
    in our vector.
    
    We can use `reserve` method on vector to reserve some space for the
    vector but doesn't initialize the value since we are anyways doing it in
    the following loop.
    
    PR-URL: #36748
    Reviewed-By: Robert Nagy <ronagy@icloud.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    yashLadha authored and ruyadorno committed Jan 25, 2021
    Configuration menu
    Copy the full SHA
    89a7941 View commit details
    Browse the repository at this point in the history
  13. test: increase buffer list coverage

    1. test consuming BufferList which has strings with > 1 items
    Refs: https://coverage.nodejs.org/coverage-0b6d3070a176d437/lib/internal/streams/buffer_list.js.html#L116
    
    2. test consuming BufferList with > 1 items
    Refs: https://coverage.nodejs.org/coverage-0b6d3070a176d437/lib/internal/streams/buffer_list.js.html#L152
    
    PR-URL: #36688
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    emilsivervik authored and ruyadorno committed Jan 25, 2021
    Configuration menu
    Copy the full SHA
    2f1f1da View commit details
    Browse the repository at this point in the history
  14. test,benchmark: stop requiring URL and URLSearchParams

    Since the URL and URLSearchParams classes are available in the
    global object, there is no need to require them from 'url'.
    
    PR-URL: #36927
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Michaël Zasso <targos@protonmail.com>
    RaisinTen authored and ruyadorno committed Jan 25, 2021
    Configuration menu
    Copy the full SHA
    fada6b0 View commit details
    Browse the repository at this point in the history
  15. buffer: introduce Blob

    The `Blob` object is an immutable data buffer. This is a first step
    towards alignment with the `Blob` Web API.
    
    Signed-off-by: James M Snell <jasnell@gmail.com>
    
    PR-URL: #36811
    Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
    Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
    Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
    jasnell authored and ruyadorno committed Jan 25, 2021
    Configuration menu
    Copy the full SHA
    775b34b View commit details
    Browse the repository at this point in the history
  16. test: add wpt tests for Blob

    PR-URL: #36811
    Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
    Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
    Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
    targos authored and ruyadorno committed Jan 25, 2021
    Configuration menu
    Copy the full SHA
    e69c4a9 View commit details
    Browse the repository at this point in the history
  17. http: abortIncoming only on socket close

    Don't call abortIncombin twice for same socket, i.e. both during
    'end' and 'close'.
    
    PR-URL: #36821
    Reviewed-By: James M Snell <jasnell@gmail.com>
    ronag authored and ruyadorno committed Jan 25, 2021
    Configuration menu
    Copy the full SHA
    f07e1c9 View commit details
    Browse the repository at this point in the history
  18. src: use BaseObject::kInternalFieldCount in X509Certificate constructor

    Use defined constant instead of hard-coding the field count
    
    PR-URL: #36892
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    joyeecheung authored and ruyadorno committed Jan 25, 2021
    Configuration menu
    Copy the full SHA
    d549985 View commit details
    Browse the repository at this point in the history
  19. doc: fix typo in http.server.requestTimout docs

    PR-URL: #36987
    Reviewed-By: Richard Lau <rlau@redhat.com>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
    alexbs authored and ruyadorno committed Jan 25, 2021
    Configuration menu
    Copy the full SHA
    4d5273b View commit details
    Browse the repository at this point in the history
  20. src: replace push_back with emplace_back in debug_utils

    This prevents potential temporary object constructions.
    
    PR-URL: #36897
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
    RaisinTen authored and ruyadorno committed Jan 25, 2021
    Configuration menu
    Copy the full SHA
    a5ffdae View commit details
    Browse the repository at this point in the history
  21. http: attach request as res.req

    This change makes it possible for userland http-related modules
    to pave over edge cases that require referencing the original request
    when handling a response--making a "Lodash for HTTP" library possible.
    More information and research in #28673
    
    Fixes: #28673
    
    PR-URL: #36505
    Reviewed-By: Robert Nagy <ronagy@icloud.com>
    ianstormtaylor authored and ruyadorno committed Jan 25, 2021
    Configuration menu
    Copy the full SHA
    70ee7dc View commit details
    Browse the repository at this point in the history
  22. build: fix compiling against openssl with no-psk

    Node 15 prior to this commit will not compile if openssl is built with
    no-psk. Compiling emits an error like this:
    
    ```
    crypto_tls.cc:(.text+0x4c27): undefined reference to
    `node::crypto::TLSWrap::SetCACerts(node::crypto::SecureContext*)'
    ```
    
    Blame on crypto_tls.cc shows the file was created in a refactor. Before
    that refactor SetCACerts was defined outside OPENSSL_NO_PSK ifndef.
    
    PR-URL: #36881
    Fixes: #36464
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Richard Lau <rlau@redhat.com>
    Caleb ツ Everett authored and ruyadorno committed Jan 25, 2021
    Configuration menu
    Copy the full SHA
    7ce7404 View commit details
    Browse the repository at this point in the history
  23. lib: remove non used getter in lib/perf_hooks.js

    PR-URL: #36907
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
    juanarbol authored and ruyadorno committed Jan 25, 2021
    Configuration menu
    Copy the full SHA
    743dd8f View commit details
    Browse the repository at this point in the history
  24. test: mark flaky tests on IBM i

    PR-URL: #36986
    Refs: #34410
    Refs: #36925
    Refs: #36929
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Michael Dawson <midawson@redhat.com>
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    richardlau authored and ruyadorno committed Jan 25, 2021
    Configuration menu
    Copy the full SHA
    7acea78 View commit details
    Browse the repository at this point in the history
  25. doc: add @RaisinTen to collaborators

    Fixes: #36833
    PR-URL: #36998
    Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>
    Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
    Reviewed-By: Beth Griggs <bgriggs@redhat.com>
    Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
    Reviewed-By: Yash Ladha <yash@yashladha.in>
    RaisinTen authored and ruyadorno committed Jan 25, 2021
    Configuration menu
    Copy the full SHA
    a2559b9 View commit details
    Browse the repository at this point in the history
  26. tools,doc: list the stability status of each API

    Fixes: #23723
    
    PR-URL: #36223
    Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
    Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    Reviewed-By: Myles Borins <myles.borins@gmail.com>
    Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
    Lxxyx authored and ruyadorno committed Jan 25, 2021
    Configuration menu
    Copy the full SHA
    17bdcd9 View commit details
    Browse the repository at this point in the history
  27. util: prefer Reflect.ownKeys(…)

    PR-URL: #36740
    Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
    ExE-Boss authored and ruyadorno committed Jan 25, 2021
    Configuration menu
    Copy the full SHA
    f270417 View commit details
    Browse the repository at this point in the history
  28. src: use BaseObject::kInteralFieldCount in Blob

    Instead of hard-coding the field count.
    
    PR-URL: #36991
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
    joyeecheung authored and ruyadorno committed Jan 25, 2021
    Configuration menu
    Copy the full SHA
    868d3b2 View commit details
    Browse the repository at this point in the history
  29. deps: update ICU to 68.2

    Refs: https://github.com/unicode-org/icu/releases/tag/release-68-2
    
    PR-URL: #36980
    Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
    Reviewed-By: Richard Lau <rlau@redhat.com>
    Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
    Reviewed-By: Beth Griggs <bgriggs@redhat.com>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    targos authored and ruyadorno committed Jan 25, 2021
    Configuration menu
    Copy the full SHA
    ef3a5f6 View commit details
    Browse the repository at this point in the history
  30. doc: fix maintaining ICU guide

    PR-URL: #36980
    Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
    Reviewed-By: Richard Lau <rlau@redhat.com>
    Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
    Reviewed-By: Beth Griggs <bgriggs@redhat.com>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    targos authored and ruyadorno committed Jan 25, 2021
    Configuration menu
    Copy the full SHA
    4b952d8 View commit details
    Browse the repository at this point in the history
  31. tools: cleanup old ICU version-specific fixes

    Our current minimum ICU is 67, so we don't need to support those anymore
    
    PR-URL: #36980
    Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
    Reviewed-By: Richard Lau <rlau@redhat.com>
    Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
    Reviewed-By: Beth Griggs <bgriggs@redhat.com>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    targos authored and ruyadorno committed Jan 25, 2021
    Configuration menu
    Copy the full SHA
    6ef54bb View commit details
    Browse the repository at this point in the history
  32. lib: refactor to use validateArray

    PR-URL: #36982
    Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Lxxyx authored and ruyadorno committed Jan 25, 2021
    Configuration menu
    Copy the full SHA
    8aeba3c View commit details
    Browse the repository at this point in the history
  33. deps: upgrade npm to 7.4.3

    PR-URL: #37018
    Reviewed-By: Myles Borins <myles.borins@gmail.com>
    Reviewed-By: Beth Griggs <bgriggs@redhat.com>
    Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
    ruyadorno committed Jan 25, 2021
    Configuration menu
    Copy the full SHA
    e52e860 View commit details
    Browse the repository at this point in the history
  34. 2021-01-26, Version 15.7.0 (Current)

    PR-URL: #37020
    
    Notable changes:
    
    * buffer:
      * introduce Blob (James M Snell) [#36811](#36811)
      * add base64url encoding option (Filip Skokan) [#36952](#36952)
    * doc:
      * add @iansu to collaborators (Ian Sutherland) [#36951](#36951)
      * add @RaisinTen to collaborators (Darshan Sen) [#36998](#36998)
      * add @miladfarca to collaborators (Milad Fa) [#36934](#36934)
    * fs:
      * allow position parameter to be a BigInt in read and readSync (raisinten) [#36190](#36190)
    * http:
      * attach request as res.req (Ian Storm Taylor) [#36505](#36505)
      * expose urlToHttpOptions utility (Yongsheng Zhang) [#35960](#35960)
    ruyadorno committed Jan 25, 2021
    Configuration menu
    Copy the full SHA
    2c0edbc View commit details
    Browse the repository at this point in the history