Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: add missing ARIA label for button #37031

Merged
merged 1 commit into from Jan 24, 2021
Merged

doc: add missing ARIA label for button #37031

merged 1 commit into from Jan 24, 2021

Commits on Jan 24, 2021

  1. doc: add missing ARIA label for button 

    The button for toggling light mode and dark mode has no text display.
Screen readers will read it as simply "button", making it not useful.
Add an aria-label attribute so it gets a better description.

PR-URL: nodejs#37031
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
    @Trott
    Trott committed Jan 24, 2021
    Configuration menu
    Copy the full SHA
    835b85d View commit details
    Browse the repository at this point in the history