Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: list Unsupported Directory Import resolve err #37032

Closed
wants to merge 3 commits into from

Conversation

guybedford
Copy link
Contributor

This updates the documentation of the resolver specification to include the Unsupported Directory Import in ths list of errors provided at the top of the specification, to ensure this list remains exhaustive of all the errors that might be thrown by the resolver.

@nodejs-github-bot nodejs-github-bot added the doc Issues and PRs related to the documentations. label Jan 23, 2021
@guybedford
Copy link
Contributor Author

@nodejs/modules

doc/api/esm.md Outdated Show resolved Hide resolved
Copy link
Member

@Trott Trott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with spelling fix.

Co-authored-by: Rich Trott <rtrott@gmail.com>
guybedford added a commit that referenced this pull request Jan 25, 2021
PR-URL: #37032
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@guybedford
Copy link
Contributor Author

Landed in efa6e1d.

@guybedford guybedford closed this Jan 25, 2021
@guybedford guybedford deleted the list-unsupported-dir-import branch January 25, 2021 11:05
targos pushed a commit that referenced this pull request Feb 2, 2021
PR-URL: #37032
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@targos targos mentioned this pull request Feb 2, 2021
targos pushed a commit that referenced this pull request May 1, 2021
PR-URL: #37032
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@danielleadams danielleadams mentioned this pull request May 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
doc Issues and PRs related to the documentations.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants