Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fs: change default value of position in read and readSync #37101

Closed
wants to merge 4 commits into from
Closed

fs: change default value of position in read and readSync #37101

wants to merge 4 commits into from

Commits on Mar 31, 2021

  1. fs: change default value of position in read and readSync 

    Since the docs mention that `position` in `read` and `readSync` should
be an `integer` or a `bigint`, the functions should rather accept what
is actually fed into `read`, i.e., `-1` instead of any nullish value.
    @RaisinTen
    RaisinTen committed Mar 31, 2021
    Configuration menu
    Copy the full SHA
    446bdb6 View commit details
    Browse the repository at this point in the history

Commits on Apr 1, 2021

  1. fixup! fs: change default value of position in read and readSync

    @RaisinTen
    RaisinTen committed Apr 1, 2021
    Configuration menu
    Copy the full SHA
    44dfe5d View commit details
    Browse the repository at this point in the history

Commits on Apr 2, 2021

  1. Revert "fixup! fs: change default value of position in read and readS… 

    …ync"

This reverts commit 44dfe5d.
    @RaisinTen
    RaisinTen committed Apr 2, 2021
    Configuration menu
    Copy the full SHA
    42a31d1 View commit details
    Browse the repository at this point in the history

  2. use default parameter

    @RaisinTen
    RaisinTen committed Apr 2, 2021
    Configuration menu
    Copy the full SHA
    9342709 View commit details
    Browse the repository at this point in the history