Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

src: expose BaseObject::kInternalFieldCount in post-mortem metadata #37111

Closed
wants to merge 1 commit into from
Closed

src: expose BaseObject::kInternalFieldCount in post-mortem metadata #37111

wants to merge 1 commit into from

Conversation

joyeecheung
Copy link
Member

@joyeecheung joyeecheung commented Jan 28, 2021 •
edited

So that the debugger does not have to hard-code the number of
internal fields of BaseObjects.

Refs: #36943

@joyeecheung
src: expose BaseObject::kInternalFieldCount in post-mortem metadata
91f1c3b 
So that the debugger does not have to hard-code the number of
internal fields of BaseObjects.
@nodejs-github-bot nodejs-github-bot added the c++ Issues and PRs that require attention from people who are familiar with C++. label Jan 28, 2021
@joyeecheung joyeecheung mentioned this pull request Jan 28, 2021
Closed
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/35800/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/35832/

@joyeecheung
Copy link
Member Author

Landed in 638fb48

@joyeecheung joyeecheung closed this Feb 2, 2021
joyeecheung added a commit that referenced this pull request Feb 2, 2021
@joyeecheung
src: expose BaseObject::kInternalFieldCount in post-mortem metadata
638fb48 
So that the debugger does not have to hard-code the number of
internal fields of BaseObjects.

PR-URL: #37111
Refs: #36943
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
targos pushed a commit that referenced this pull request Feb 2, 2021
@joyeecheung @targos
src: expose BaseObject::kInternalFieldCount in post-mortem metadata
a26dfb3 
So that the debugger does not have to hard-code the number of
internal fields of BaseObjects.

PR-URL: #37111
Refs: #36943
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@targos targos mentioned this pull request Feb 2, 2021
Merged
targos pushed a commit that referenced this pull request May 1, 2021
@joyeecheung @targos
src: expose BaseObject::kInternalFieldCount in post-mortem metadata
1ecdb66 
So that the debugger does not have to hard-code the number of
internal fields of BaseObjects.

PR-URL: #37111
Refs: #36943
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@danielleadams danielleadams mentioned this pull request May 3, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jasnell jasnell jasnell approved these changes

@Trott Trott Trott approved these changes

@cjihrig cjihrig cjihrig approved these changes

Assignees
No one assigned
Labels
c++ Issues and PRs that require attention from people who are familiar with C++.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@joyeecheung @nodejs-github-bot @jasnell @Trott @cjihrig