fs: remove permissive rmdir recursive #37216

aduh95 · 2021-02-03T19:25:14Z

To follow the plan invoked in #35562 (comment).

This removes permissive behaviour of fs.rmdir(path, { recursive: true }), and add a runtime warning for all use of recursive option with rmdir (currently, the warning is emitted only if path isn't a directory).

iansu · 2021-02-03T19:34:48Z

Hey, thanks for doing this. A couple of initial thoughts:

In terms of the new behaviour of rmdir we should probably just put it back to what it was before the recursive option was introduced. I haven't had a chance to go back and look at that code yet but that might help with your question about what error to throw.
We want this change to go into Node 16 but I'm not sure how to make that happen. I think the semver-major label you've applied will do that but I'm not 100% sure.

bcoe · 2021-02-06T17:32:33Z

@aduh95, just had a conversation with @iansu in slack. I dug up this summary of the conversation we had with the TSC:

#35494 (comment)

My temptation is that we continue supporting rmdir(path, {recursive: true}), but that it throws on a missing or file path (this brings us in alignment with APIs in Deno, Python, and I believe C#).

If we then later decide it's silly to maintain both implementations, we can later deprecate the recursive option.

I think there's a danger of removing recursive completely breaking the world for people in Node 16, whereas moving towards being stricter will break far fewer people, and bring us closer to the APIs on other platforms.

aduh95 · 2021-02-07T17:32:11Z

@bcoe That was my understanding as well, and I believe this PR is doing what you described above: the recursive option is still there, but throws if the path is not a directory.

iansu · 2021-02-07T18:23:14Z

@aduh95 Sorry for sending you off in the wrong direction. I do think it's worth considering if we want to also print a deprecation warning for any use of rmdir recursive in Node 16. That might be a bit more controversial though so I think that's best discussed in a followup issue or PR.

bcoe · 2021-02-08T18:46:26Z

I do think it's worth considering if we want to also print a deprecation warning for any use of rmdir recursive in Node 16

@iansu this sounds reasonable to me, it might honestly be worth bringing up to the TSC, i.e., do we want to permanently support the rm helper, and a recursive option on rmdir, or do we want to nudge people towards rm.

aduh95 · 2021-02-08T22:53:05Z

it might honestly be worth bringing up to the TSC

I agree! This PR is marked semver-major, that means it needs at least two approvals from TSC members. Before pinging them, I'd like to make sure the work I've done aligns with plan we can agree on. It seems to me there are two things conflicting and I'm not sure I've got it right:

Deprecation status of recursive option: do we want to remove the option for Node.js 17 in favor of fs.rm? I would say that yes, we should align with RMDIR(1), which doesn't have a recursive option.
Permissive behaviour of fs.rmdir(path, {recursive:true}): we want to get rid of it, but is it worth it if we are planning to remove the recursive option anyway?

Do you think it's a good summary?

My temptation is that we continue supporting rmdir(path, {recursive: true}), but that it throws on a missing or file path (this brings us in alignment with APIs in Deno, Python, and I believe C#).

If we want to align with the other APIs, shouldn't we want to remove the option instead?

Deno doesn't have a rmdir API AFAICT, Deno.remove has a recursive option but is more analogous to fs.rm.
Python doesn't have a recursive option it seems: https://docs.python.org/3/library/os.html#os.rmdir.
C# RmDir doesn't have a recursive option either: https://docs.microsoft.com/en-us/dotnet/api/microsoft.visualbasic.filesystem.rmdir?view=net-5.0

If that's OK with you, I'm going to open another PR that adds a runtime warning for all uses of recursive option with rmdir[Sync] to nudge people to move to fs.rm instead, as it seems the "correct" way of action.

bcoe

👍 with one nit, mind adding a comment above the blocks of your test cases, describing each?

test/parallel/test-fs-rmdir-recursive-throws-not-found.js

aduh95 · 2021-02-17T22:31:28Z

I've rebased on top of master to solve the conflict, and also changed deprecation status from End-of-Life to Documentation only: indeed the permissive behavior is EOL, but my understanding is that the recursive option is still deprecated, and we want to remove it in a future version of Node.js. /cc @bcoe @jasnell in case you'd want to retract your approval.

bcoe · 2021-02-18T01:54:58Z

doc/api/deprecations.md

 if `path` does not exist or is a file.
-Use `fs.rm(path, { recursive: true, force: true })` instead.
+Use `fs.rm(path, { recursive: true, force: true })`,


This still mainly refers to the permissive behavior, which is removed in v16.0.0.

Wondering if it would get the point across better if we went with:

`fs.rmdir(path, { recursive: true })`, `fs.rmdirSync(path, { recursive:true })` will be removed in the next major, use Use `fs.rm(path, { recursive: true, force: true })`, etc.

I'm 👍 with this decision as long as the TSC is supportive -- avoid keeping both API surfaces.

I don't think we want to say it will be removed in 17.x. "a future version" is sufficient. "the next version" is more specific than we've been in the past, and we've been known to kick things to subsequent majors for various reasons.

Oh, wait, it says "a future version" now. Cool.

bcoe

Left a nit regarding the wording of the deprecation notice, given that we're leaning towards removing recursive entirely in v17.0.0.

bcoe · 2021-02-18T17:30:01Z

@mhdawson would it be possible to put this on a @nodejs/tsc agenda for visibility, I feel @aduh95 has proposed a good path forward:

remove the permissive behavior from rs.rmdir in v16 (as discussed).
documentation only deprecation of rs.rmdir(path, {recursive: true}) in v16.
In v17 recursive behavior is dropped from rmdir entirely, in favor of fs.rm.

doc/api/fs.md

aduh95 · 2021-02-18T18:26:32Z

remove the permissive behavior from rs.rmdir in v16 (as discussed).

documentation only deprecation of rs.rmdir(path, {recursive: true}) in v16.

In v17 recursive behavior is dropped from rmdir entirely, in favor of fs.rm.

I think we would need to go through a runtime deprecation first, so either:

runtime deprecate + remove permissive behavior:

remove the permissive behavior from rs.rmdir in v16 (as discussed).
runtime deprecation of rs.rmdir(path, {recursive: true}) in v16.
In v17 recursive behavior is dropped from rmdir entirely, in favor of fs.rm.

remove permissive behavior, deprecate later (that's the path taken by this PR):

remove the permissive behavior from rs.rmdir in v16 (as discussed).
doc-only deprecation of rs.rmdir(path, {recursive: true}) in v16.
runtime deprecation of rs.rmdir(path, {recursive: true}) in v17.
In v18 recursive behavior is dropped from rmdir entirely, in favor of fs.rm.

runtime deprecate while keeping permissive behavior (that's the path taken by fs: runtime deprecate rmdir recursive option #37302):

DO NOT remove the permissive behavior from rs.rmdir, instead runtime deprecate all use of rs.rmdir(path, {recursive: true}) in v16.
In v17 recursive behavior is dropped from rmdir entirely, in favor of fs.rm.

I feel the latter is the "less breaking path", as it avoids introducing a breaking change, but on the other hand the permissive behavior may be quite surprising to new users. No strong opinions though, I think all three paths are reasonable.

iansu · 2021-02-18T19:10:35Z

@aduh95 I think I'm leaning towards option 1. If we are going to remove the recursive functionality from rmdir I'd prefer to do it as quickly as possible. I think the longer it stays the harder it will be to remove it fully.

Trott · 2021-03-18T16:19:07Z

CITGM (queued): https://ci.nodejs.org/view/Node.js-citgm/job/citgm-smoker/2648/

nodejs-github-bot · 2021-03-18T16:19:35Z

CI: https://ci.nodejs.org/job/node-test-pull-request/36781/

mhdawson

LGTM as following previously agreed plan

nodejs-github-bot · 2021-03-19T18:50:22Z

CI: https://ci.nodejs.org/job/node-test-pull-request/36816/

nodejs-github-bot · 2021-03-19T20:36:14Z

CI: https://ci.nodejs.org/job/node-test-pull-request/36824/

nodejs-github-bot · 2021-03-19T23:12:34Z

CI: https://ci.nodejs.org/job/node-test-pull-request/36830/

nodejs-github-bot · 2021-03-20T00:09:35Z

CI: https://ci.nodejs.org/job/node-test-pull-request/36834/

nodejs-github-bot · 2021-03-20T07:24:24Z

CI: https://ci.nodejs.org/job/node-test-pull-request/36838/

nodejs-github-bot · 2021-03-20T08:02:04Z

CI: https://ci.nodejs.org/job/node-test-pull-request/36844/

nodejs-github-bot · 2021-03-20T14:57:26Z

CI: https://ci.nodejs.org/job/node-test-pull-request/36857/

PR-URL: nodejs#37216 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Ben Coe <bencoe@gmail.com> Reviewed-By: Ian Sutherland <ian@iansutherland.ca> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Michael Dawson <midawson@redhat.com>

aduh95 · 2021-03-20T18:18:21Z

Landed in 9948036

Notable Changes: Deprecations and Removals - **(SEMVER-MAJOR)** **fs**: remove permissive rmdir recursive (Antoine du Hamel) [#37216] - **(SEMVER-MAJOR)** **fs**: runtime deprecate rmdir recursive option (Antoine du Hamel) [#37302] - **(SEMVER-MAJOR)** **lib**: runtime deprecate access to process.binding('http_parser') (James M Snell) [#37813] - **(SEMVER-MAJOR)** **lib**: runtime deprecate access to process.binding('url') (James M Snell) [#37799] - **(SEMVER-MAJOR)** **lib**: make process.binding('util') return only type checkers (Anna Henningsen) [#37819] - **(SEMVER-MAJOR)** **lib**: runtime deprecate access to process.binding('crypto') (James M Snell) [#37790] - **(SEMVER-MAJOR)** **lib**: runtime deprecate access to process.binding('signal_wrap') (James M Snell) [#37800] - **(SEMVER-MAJOR)** **lib**: runtime deprecate access to process.binding('v8') (James M Snell) [#37789] - **(SEMVER-MAJOR)** **lib**: runtime deprecate access to process.binding('async_wrap') (James M Snell) [#37576] - **(SEMVER-MAJOR)** **module**: remove module.createRequireFromPath (Antoine du Hamel) [#37201] - **(SEMVER-MAJOR)** **module**: runtime deprecate subpath folder mappings (Antoine du Hamel) [#37215] - **(SEMVER-MAJOR)** **module**: runtime deprecate "main" index and extension lookups (Antoine du Hamel) [#37206] - **(SEMVER-MAJOR)** **module**: runtime deprecate invalid package.json main entries (Antoine du Hamel) [#37204] - **(SEMVER-MAJOR)** **process**: runtime deprecate changing process.config (James M Snell) [#36902] Stable Timers Promises API: The Timers Promises API provides an alternative set of timer functions that return Promise objects. Added in Node.js v15.0.0, in this release they graduate from experimental status to stable. Contributed by James Snell - [#38112] Toolchain and Compiler Upgrades: Node.js v16.0.0 will be the first release where we ship prebuilt binaries for Apple Silicon. While we’ll be providing separate tarballs for the Intel (`darwin-x64`) and ARM (`darwin-arm64`) architectures the macOS installer (`.pkg`) will be shipped as a ‘fat’ (multi-architecture) binary. - **(SEMVER-MAJOR)** **build**: remove support for Python 2 (Christian Clauss) [#36691] - **(SEMVER-MAJOR)** **build**: default PYTHON to python3 in Makefile (Michaël Zasso) [#37764] - **build**: update Makefile to support fat binary (Ash Cripps) [#37861] - **(SEMVER-MAJOR)** **build**: enable ASLR (PIE) on OS X (woodfairy) [#35704] - **build**: warn for gcc versions earlier than 8.3.0 (Richard Lau) [#37935] - **(SEMVER-MAJOR)** **doc**: update minimum supported Xcode to 11 (Michaël Zasso) [#37872] - **(SEMVER-MAJOR)** **doc**: update minimum supported GCC to 8.3 (Michaël Zasso) [#37871] - **(SEMVER-MAJOR)** **doc**: update AIX to GCC8 for v16.x (Ash Cripps) [#37677] - **tools**: set arch in Distribution.xml (Ash Cripps) [#38261] V8 9.0: The V8 JavaScript engine is updated to V8 9.0, including performance tweaks and improvements. This update also brings the ECMAScript RegExp Match Indices, which provide the start and end indices of the captured string. The indices array is available via the `.indices` property on match objects when the regular expression has the `/d` flag. Contributed by Michaël Zasso - [#37587] Other Notable Changes: - **(SEMVER-MINOR)** **assert**: graduate assert.match and assert.doesNotMatch (James M Snell) [#38111] - **(SEMVER-MAJOR)** **buffer**: expose btoa and atob as globals (James M Snell) [#37786] - **deps**: update llhttp to 6.0.0 (Fedor Indutny) [#38277] - **deps**: upgrade npm to 7.10.0 (Ruy Adorno) [#38254] - **(SEMVER-MAJOR)** **deps**: bump minimum ICU version to 68 (Michaël Zasso) [#37330] - **(SEMVER-MINOR)** **http**: add http.ClientRequest.getRawHeaderNames() (simov) [#37660] - **(SEMVER-MAJOR)** **lib,src**: update cluster to use Parent (Michael Dawson) [#36478] - **(SEMVER-MINOR)** **module**: add support for `node:`‑prefixed `require(…)` calls (ExE Boss) [#37246] - **(SEMVER-MINOR)** **perf_hooks**: add histogram option to timerify (James M Snell) [#37475] - **(SEMVER-MINOR)** **repl**: add auto‑completion for `node:`‑prefixed `require(…)` calls (ExE Boss) [#37246] - **(SEMVER-MINOR)** **util**: add getSystemErrorMap() impl (eladkeyshawn) [#38101] Semver-Major Commits: - **async_hooks**: add thisArg to AsyncResource.bind (James M Snell) [#36782] - **buffer**: expose btoa and atob as globals (James M Snell) [#37786] - **build**: remove support for Python 2 (Christian Clauss) [#36691] - **build**: default PYTHON to python3 in Makefile (Michaël Zasso) [#37764] - **build**: update Makefile to support fat binary (Ash Cripps) [#37861] - **build**: reset embedder string to "-node.0" (Michaël Zasso) [#37587] - **build**: include minimal V8 headers in distribution (Michaël Zasso) [#37570] - **build**: reset embedder string to "-node.0" (Michaël Zasso) [#37330] - **build**: reset embedder string to "-node.0" (Michaël Zasso) [#36139] - **build**: use C++11 ABI with libstdc++ (Anna Henningsen) [#36634] - **build**: enable ASLR (PIE) on OS X (woodfairy) [#35704] - **build**: reset embedder string to "-node.0" (Michaël Zasso) [#35700] - **deps**: V8: cherry-pick 1648e050cade (Michaël Zasso) [#37587] - **deps**: silence irrelevant V8 warnings (Michaël Zasso) [#37587] - **deps**: fix V8 build issue with inline methods (Jiawen Geng) [#35415] - **deps**: make v8.h compatible with VS2015 (Joao Reis) [#32116] - **deps**: V8: forward declaration of `Rtl\*FunctionTable` (Refael Ackermann) [#32116] - **deps**: V8: patch register-arm64.h (Refael Ackermann) [#32116] - **deps**: V8: un-cherry-pick bd019bd (Refael Ackermann) [#32116] - **deps**: update V8 to 9.0.257.11 (Michaël Zasso) [#37587] - **deps**: bump minimum ICU version to 68 (Michaël Zasso) [#37330] - **deps**: V8: cherry-pick 8957d4677aa7 (Michaël Zasso) [#37330] - **deps**: V8: backport a11395433dbd (Michaël Zasso) [#37330] - **deps**: V8: cherry-pick deb0813166f3 (Michaël Zasso) [#36139] - **deps**: V8: cherry-pick 9a6a22874c81 (Michaël Zasso) [#36139] - **deps**: silence irrelevant V8 warning (Michaël Zasso) [#37330] - **deps**: workaround stod() limitations on SmartOS (Colin Ihrig) [#37330] - **deps**: fix V8 build issue with inline methods (Jiawen Geng) [#35415] - **deps**: patch V8 to run on Xcode 8 (Mary Marchini) [#32116] - **deps**: make v8.h compatible with VS2015 (Joao Reis) [#32116] - **deps**: V8: forward declaration of `Rtl\*FunctionTable` (Refael Ackermann) [#32116] - **deps**: V8: patch register-arm64.h (Refael Ackermann) [#32116] - **deps**: patch V8 to run on older XCode versions (Ujjwal Sharma) [#32116] - **deps**: V8: un-cherry-pick bd019bd (Refael Ackermann) [#32116] - **deps**: update V8 to 8.9.255.19 (Michaël Zasso) [#37330] - **deps**: V8: cherry-pick deb0813166f3 (Michaël Zasso) [#36139] - **deps**: V8: cherry-pick 9a6a22874c81 (Michaël Zasso) [#36139] - **deps**: V8: cherry-pick 2059ee813359 (Michaël Zasso) [#36139] - **deps**: V8: cherry-pick bde7ee5473d6 (Michaël Zasso) [#36139] - **deps**: V8: cherry-pick 9a712984025e (Michaël Zasso) [#36139] - **deps**: V8: cherry-pick 0b96e5b0bfb2 (Michaël Zasso) [#36139] - **deps**: V8: cherry-pick fbb28902e049 (Michaël Zasso) [#36139] - **deps**: V8: cherry-pick 821fb3883a8e (Michaël Zasso) [#35700] - **deps**: workaround stod() limitations on SmartOS (Colin Ihrig) [#36139] - **deps**: fix V8 build issue with inline methods (Jiawen Geng) [#35415] - **deps**: patch V8 to run on Xcode 8 (Mary Marchini) [#32116] - **deps**: V8: silence irrelevant warnings (Michaël Zasso) [#32116] - **deps**: make v8.h compatible with VS2015 (Joao Reis) [#32116] - **deps**: V8: forward declaration of `Rtl\*FunctionTable` (Refael Ackermann) [#32116] - **deps**: V8: patch register-arm64.h (Refael Ackermann) [#32116] - **deps**: patch V8 to run on older XCode versions (Ujjwal Sharma) [#32116] - **deps**: V8: un-cherry-pick bd019bd (Refael Ackermann) [#32116] - **deps**: update V8 to 8.8.278.17 (Michaël Zasso) [#36139] - **deps**: V8: cherry-pick 821fb3883a8e (Michaël Zasso) [#35700] - **deps**: V8: cherry-pick 45e49775f5a3 (Michaël Zasso) [#35700] - **deps**: V8: cherry-pick 7b3a27b7ae65 (Michaël Zasso) [#35700] - **deps**: V8: cherry-pick d76abfed3512 (Michaël Zasso) [#35415] - **deps**: fix V8 build issue with inline methods (Jiawen Geng) [#35415] - **deps**: update V8 postmortem metadata script (Colin Ihrig) [#35415] - **deps**: update V8 postmortem metadata script (Colin Ihrig) [#33579] - **deps**: patch V8 to run on Xcode 8 (Mary Marchini) [#32116] - **deps**: V8: silence irrelevant warnings (Michaël Zasso) [#32116] - **deps**: make v8.h compatible with VS2015 (Joao Reis) [#32116] - **deps**: V8: forward declaration of `Rtl\*FunctionTable` (Refael Ackermann) [#32116] - **deps**: V8: patch register-arm64.h (Refael Ackermann) [#32116] - **deps**: patch V8 to run on older XCode versions (Ujjwal Sharma) [#32116] - **deps**: V8: un-cherry-pick bd019bd (Refael Ackermann) [#32116] - **deps**: update V8 to 8.7.220 (Michaël Zasso) [#35700] - **dns**: use url module instead of punycode for IDNA (Antoine du Hamel) [#35091] - **doc**: update minimum supported Xcode to 11 (Michaël Zasso) [#37872] - **doc**: update minimum supported GCC to 8.3 (Michaël Zasso) [#37871] - **doc**: update AIX to GCC8 for v16.x (Ash Cripps) [#37677] - **doc**: fixup http.IncomingMessage deprecation code (Guy Bedford) [#36917] - **doc**: add http.IncomingMessage#connection (Pranshu Srivastava) [#33768] - **events**: change EventTarget handler exception behavior (Nitzan Uziely) [#37237] - **fs**: remove permissive rmdir recursive (Antoine du Hamel) [#37216] - **fs**: add validation for fd and path (Dylan Elliott) [#35187] - **fs**: runtime deprecate rmdir recursive option (Antoine du Hamel) [#37302] - **fs**: fix flag and mode validation (James M Snell) [#37480] - **http**: use objects with null prototype in Agent (Michaël Zasso) [#36409] - **lib**: runtime deprecate access to process.binding('http_parser') (James M Snell) [#37813] - **lib**: runtime deprecate access to process.binding('url') (James M Snell) [#37799] - **lib**: make process.binding('util') return only type checkers (Anna Henningsen) [#37819] - **lib**: runtime deprecate access to process.binding('crypto') (James M Snell) [#37790] - **lib**: runtime deprecate access to process.binding('signal_wrap') (James M Snell) [#37800] - **lib**: runtime deprecate access to process.binding('v8') (James M Snell) [#37789] - **lib**: aggregate errors to avoid error swallowing (Antoine du Hamel) [#37460] - **lib**: load v8_prof_processor dependencies as ESM (Michaël Zasso) [#37587] - **lib**: runtime deprecate access to process.binding('async_wrap') (James M Snell) [#37576] - **lib**: remove usage of url.parse (raisinten) [#36853] - **lib**: add error handling for input stream (rexagod) [#31603] - **lib,src**: update cluster to use Parent (Michael Dawson) [#36478] - **module**: runtime deprecate subpath folder mappings (Antoine du Hamel) [#37215] - **module**: runtime deprecate "main" index and extension lookups (Antoine du Hamel) [#37206] - **module**: runtime deprecate invalid package.json main entries (Antoine du Hamel) [#37204] - **module**: remove module.createRequireFromPath (Antoine du Hamel) [#37201] - **module**: only set cache when finding module succeeds (Yongsheng Zhang) [#36642] - **perf_hooks**: make performance a global (James M Snell) [#37970] - **perf_hooks**: complete overhaul of the implementation (James M Snell) [#37136] - **process**: disallow adding options to process.allowedNodeEnvironmentFlags (Antoine du Hamel) [#36660] - **process**: runtime deprecate changing process.config (James M Snell) [#36902] - **readline**: cursorTo throw error on NaN (Zijian Liu) [#36379] - **src**: use non-deprecated GetCreationContext from V8 (Michaël Zasso) [#37587] - **src**: remove V8_FT_ADAPTOR for V8 update (Colin Ihrig) [#37587] - **src**: use non-deprecated V8 module APIs (Michaël Zasso) [#37587] - **src**: update NODE_MODULE_VERSION to 93 (Michaël Zasso) [#37587] - **src**: use non-deprecated V8 module and script APIs (Michaël Zasso) [#37330] - **src**: update NODE_MODULE_VERSION to 92 (Michaël Zasso) [#37330] - **src**: update NODE_MODULE_VERSION to 91 (Michaël Zasso) [#36139] - **src**: mark internally exported functions as explicitly internal (Tyler Ang-Wanek) [#37000] - **src**: inline AsyncCleanupHookHandle in headers (Tyler Ang-Wanek) [#37000] - **src**: fix v8 api deprecation (Jiawen Geng) [#35700] - **src**: update NODE_MODULE_VERSION to 90 (Michaël Zasso) [#35700] - **src**: clean up embedder API (Anna Henningsen) [#35897] - **test**: mark test-return-on-exit as flaky (Michaël Zasso) [#36139] - **test**: mark WASI's test-return-on-exit as flaky (Colin Ihrig) [#36139] - **tools**: update V8 gypfiles for 9.0 (Michaël Zasso) [#37587] - **tools**: update V8 gypfiles for 8.9 (Michaël Zasso) [#37330] - **tools**: update V8 gypfiles for 8.8 (Michaël Zasso) [#36139] - **tools**: update V8 gypfiles for 8.7 (Michaël Zasso) [#35700] - **worker**: send correct error status for worker init (Yash Ladha) [#36242] PR-URL: #37678

Notable changes: Deprecations and Removals: - **(SEMVER-MAJOR)** **fs**: remove permissive rmdir recursive (Antoine du Hamel) [#37216] - **(SEMVER-MAJOR)** **fs**: runtime deprecate rmdir recursive option (Antoine du Hamel) [#37302] - **(SEMVER-MAJOR)** **lib**: runtime deprecate access to process.binding('http_parser') (James M Snell) [#37813] - **(SEMVER-MAJOR)** **lib**: runtime deprecate access to process.binding('url') (James M Snell) [#37799] - **(SEMVER-MAJOR)** **lib**: make process.binding('util') return only type checkers (Anna Henningsen) [#37819] - **(SEMVER-MAJOR)** **lib**: runtime deprecate access to process.binding('crypto') (James M Snell) [#37790] - **(SEMVER-MAJOR)** **lib**: runtime deprecate access to process.binding('signal_wrap') (James M Snell) [#37800] - **(SEMVER-MAJOR)** **lib**: runtime deprecate access to process.binding('v8') (James M Snell) [#37789] - **(SEMVER-MAJOR)** **lib**: runtime deprecate access to process.binding('async_wrap') (James M Snell) [#37576] - **(SEMVER-MAJOR)** **module**: remove module.createRequireFromPath (Antoine du Hamel) [#37201] - **(SEMVER-MAJOR)** **module**: runtime deprecate subpath folder mappings (Antoine du Hamel) [#37215] - **(SEMVER-MAJOR)** **module**: runtime deprecate "main" index and extension lookups (Antoine du Hamel) [#37206] - **(SEMVER-MAJOR)** **module**: runtime deprecate invalid package.json main entries (Antoine du Hamel) [#37204] - **(SEMVER-MAJOR)** **process**: runtime deprecate changing process.config (James M Snell) [#36902] Stable Timers Promises API: The Timers Promises API provides an alternative set of timer functions that return Promise objects. Added in Node.js v15.0.0, in this release they graduate from experimental status to stable. Contributed by James Snell - [#38112] Toolchain and Compiler Upgrades: Node.js v16.0.0 will be the first release where we ship prebuilt binaries for Apple Silicon. While we’ll be providing separate tarballs for the Intel (`darwin-x64`) and ARM (`darwin-arm64`) architectures the macOS installer (`.pkg`) will be shipped as a ‘fat’ (multi-architecture) binary. - **(SEMVER-MAJOR)** **build**: remove support for Python 2 (Christian Clauss) [#36691] - **(SEMVER-MAJOR)** **build**: default PYTHON to python3 in Makefile (Michaël Zasso) [#37764] - **build**: update Makefile to support fat binary (Ash Cripps) [#37861] - **(SEMVER-MAJOR)** **build**: enable ASLR (PIE) on OS X (woodfairy) [#35704] - **build**: warn for gcc versions earlier than 8.3.0 (Richard Lau) [#37935] - **(SEMVER-MAJOR)** **doc**: update minimum supported Xcode to 11 (Michaël Zasso) [#37872] - **(SEMVER-MAJOR)** **doc**: update minimum supported GCC to 8.3 (Michaël Zasso) [#37871] - **(SEMVER-MAJOR)** **doc**: update AIX to GCC8 for v16.x (Ash Cripps) [#37677] - **tools**: set arch in Distribution.xml (Ash Cripps) [#38261] V8 9.0: The V8 JavaScript engine is updated to V8 9.0, including performance tweaks and improvements. This update also brings the ECMAScript RegExp Match Indices, which provide the start and end indices of the captured string. The indices array is available via the `.indices` property on match objects when the regular expression has the `/d` flag. Contributed by Michaël Zasso - [#37587] Other Notable Changes: - **(SEMVER-MINOR)** **assert**: graduate assert.match and assert.doesNotMatch (James M Snell) [#38111] - **(SEMVER-MAJOR)** **buffer**: expose btoa and atob as globals (James M Snell) [#37786] - **(SEMVER-MAJOR)** **deps**: bump minimum ICU version to 68 (Michaël Zasso) [#37330] - **deps**: update ICU to 69.1 (Michaël Zasso) [#38178] - **deps**: update llhttp to 6.0.0 (Fedor Indutny) [#38277] - **deps**: upgrade npm to 7.10.0 (Ruy Adorno) [#38254] - **(SEMVER-MINOR)** **http**: add http.ClientRequest.getRawHeaderNames() (simov) [#37660] - **(SEMVER-MAJOR)** **lib,src**: update cluster to use Parent (Michael Dawson) [#36478] - **(SEMVER-MINOR)** **module**: add support for `node:`‑prefixed `require(…)` calls (ExE Boss) [#37246] - **(SEMVER-MINOR)** **perf_hooks**: add histogram option to timerify (James M Snell) [#37475] - **(SEMVER-MINOR)** **repl**: add auto‑completion for `node:`‑prefixed `require(…)` calls (ExE Boss) [#37246] - **(SEMVER-MINOR)** **util**: add getSystemErrorMap() impl (eladkeyshawn) [#38101] Semver-Major Commits: - **(SEMVER-MAJOR)** **async_hooks**: add thisArg to AsyncResource.bind (James M Snell) [#36782] - **(SEMVER-MAJOR)** **buffer**: expose btoa and atob as globals (James M Snell) [#37786] - **(SEMVER-MAJOR)** **build**: remove support for Python 2 (Christian Clauss) [#36691] - **(SEMVER-MAJOR)** **build**: default PYTHON to python3 in Makefile (Michaël Zasso) [#37764] - **(SEMVER-MAJOR)** **build**: update Makefile to support fat binary (Ash Cripps) [#37861] - **(SEMVER-MAJOR)** **build**: include minimal V8 headers in distribution (Michaël Zasso) [#37570] - **(SEMVER-MAJOR)** **build**: use C++11 ABI with libstdc++ (Anna Henningsen) [#36634] - **(SEMVER-MAJOR)** **build**: enable ASLR (PIE) on OS X (woodfairy) [#35704] - **(SEMVER-MAJOR)** **deps**: update V8 to 9.0.257.11 (Michaël Zasso) [#37587] - **(SEMVER-MAJOR)** **deps**: bump minimum ICU version to 68 (Michaël Zasso) [#37330] - **(SEMVER-MAJOR)** **deps**: update V8 to 8.9.255.19 (Michaël Zasso) [#37330] - **(SEMVER-MAJOR)** **deps**: update V8 to 8.8.278.17 (Michaël Zasso) [#36139] - **(SEMVER-MAJOR)** **deps**: update V8 to 8.7.220 (Michaël Zasso) [#35700] - **(SEMVER-MAJOR)** **dns**: use url module instead of punycode for IDNA (Antoine du Hamel) [#35091] - **(SEMVER-MAJOR)** **doc**: update minimum supported Xcode to 11 (Michaël Zasso) [#37872] - **(SEMVER-MAJOR)** **doc**: update minimum supported GCC to 8.3 (Michaël Zasso) [#37871] - **(SEMVER-MAJOR)** **doc**: update AIX to GCC8 for v16.x (Ash Cripps) [#37677] - **(SEMVER-MAJOR)** **doc**: add http.IncomingMessage#connection (Pranshu Srivastava) [#33768] - **(SEMVER-MAJOR)** **events**: change EventTarget handler exception behavior (Nitzan Uziely) [#37237] - **(SEMVER-MAJOR)** **fs**: remove permissive rmdir recursive (Antoine du Hamel) [#37216] - **(SEMVER-MAJOR)** **fs**: add validation for fd and path (Dylan Elliott) [#35187] - **(SEMVER-MAJOR)** **fs**: runtime deprecate rmdir recursive option (Antoine du Hamel) [#37302] - **(SEMVER-MAJOR)** **fs**: fix flag and mode validation (James M Snell) [#37480] - **(SEMVER-MAJOR)** **http**: use objects with null prototype in Agent (Michaël Zasso) [#36409] - **(SEMVER-MAJOR)** **lib**: runtime deprecate access to process.binding('http_parser') (James M Snell) [#37813] - **(SEMVER-MAJOR)** **lib**: runtime deprecate access to process.binding('url') (James M Snell) [#37799] - **(SEMVER-MAJOR)** **lib**: make process.binding('util') return only type checkers (Anna Henningsen) [#37819] - **(SEMVER-MAJOR)** **lib**: runtime deprecate access to process.binding('crypto') (James M Snell) [#37790] - **(SEMVER-MAJOR)** **lib**: runtime deprecate access to process.binding('signal_wrap') (James M Snell) [#37800] - **(SEMVER-MAJOR)** **lib**: runtime deprecate access to process.binding('v8') (James M Snell) [#37789] - **(SEMVER-MAJOR)** **lib**: aggregate errors to avoid error swallowing (Antoine du Hamel) [#37460] - **(SEMVER-MAJOR)** **lib**: runtime deprecate access to process.binding('async_wrap') (James M Snell) [#37576] - **(SEMVER-MAJOR)** **lib**: remove usage of url.parse (raisinten) [#36853] - **(SEMVER-MAJOR)** **lib**: add error handling for input stream (rexagod) [#31603] - **(SEMVER-MAJOR)** **lib,src**: update cluster to use Parent (Michael Dawson) [#36478] - **(SEMVER-MAJOR)** **module**: runtime deprecate subpath folder mappings (Antoine du Hamel) [#37215] - **(SEMVER-MAJOR)** **module**: runtime deprecate "main" index and extension lookups (Antoine du Hamel) [#37206] - **(SEMVER-MAJOR)** **module**: runtime deprecate invalid package.json main entries (Antoine du Hamel) [#37204] - **(SEMVER-MAJOR)** **module**: remove module.createRequireFromPath (Antoine du Hamel) [#37201] - **(SEMVER-MAJOR)** **module**: only set cache when finding module succeeds (Yongsheng Zhang) [#36642] - **(SEMVER-MAJOR)** **perf_hooks**: make performance a global (James M Snell) [#37970] - **(SEMVER-MAJOR)** **perf_hooks**: complete overhaul of the implementation (James M Snell) [#37136] - **(SEMVER-MAJOR)** **process**: disallow adding options to process.allowedNodeEnvironmentFlags (Antoine du Hamel) [#36660] - **(SEMVER-MAJOR)** **process**: runtime deprecate changing process.config (James M Snell) [#36902] - **(SEMVER-MAJOR)** **readline**: cursorTo throw error on NaN (Zijian Liu) [#36379] - **(SEMVER-MAJOR)** **src**: mark internally exported functions as explicitly internal (Tyler Ang-Wanek) [#37000] - **(SEMVER-MAJOR)** **src**: inline AsyncCleanupHookHandle in headers (Tyler Ang-Wanek) [#37000] - **(SEMVER-MAJOR)** **src**: clean up embedder API (Anna Henningsen) [#35897] - **(SEMVER-MAJOR)** **worker**: send correct error status for worker init (Yash Ladha) [#36242] PR-URL: #37678

nodejs/node#37216

in Node 16, this throws an error if `folderName` DNE nodejs/node#37216

nodejs/node#37216 In the future version of node, rmdirSync fails when the directory does not exist This change make sure our script doesn't break after we upgrade node.

in Node 16, this throws an error if `folderName` DNE nodejs/node#37216

aduh95 added wip Issues and PRs that are still a work in progress. fs Issues and PRs related to the fs subsystem / file system. semver-major PRs that contain breaking changes and should be released in the next major version. deprecations Issues and PRs related to deprecations. labels Feb 3, 2021

aduh95 requested review from bcoe and iansu February 3, 2021 19:25

aduh95 removed the wip Issues and PRs that are still a work in progress. label Feb 4, 2021

aduh95 force-pushed the rmdir-recursive-DEP0147 branch from f445dfd to 6b821a9 Compare February 8, 2021 11:25

aduh95 added the wip Issues and PRs that are still a work in progress. label Feb 8, 2021

aduh95 mentioned this pull request Feb 9, 2021

fs: runtime deprecate rmdir recursive option #37302

Merged

aduh95 force-pushed the rmdir-recursive-DEP0147 branch from 6b821a9 to a896cbe Compare February 9, 2021 22:25

jasnell approved these changes Feb 14, 2021

View reviewed changes

bcoe approved these changes Feb 17, 2021

View reviewed changes

test/parallel/test-fs-rmdir-recursive-throws-not-found.js Show resolved Hide resolved

aduh95 force-pushed the rmdir-recursive-DEP0147 branch from a896cbe to e14cb2f Compare February 17, 2021 22:24

bcoe reviewed Feb 18, 2021

View reviewed changes

bcoe suggested changes Feb 18, 2021

View reviewed changes

bcoe approved these changes Feb 18, 2021

View reviewed changes

iansu reviewed Feb 18, 2021

View reviewed changes

doc/api/fs.md Show resolved Hide resolved

aduh95 added the tsc-agenda Issues and PRs to discuss during the meetings of the TSC. label Feb 18, 2021

iansu approved these changes Feb 18, 2021

View reviewed changes

Trott added the needs-citgm PRs that need a CITGM CI run. label Mar 18, 2021

mhdawson approved these changes Mar 18, 2021

View reviewed changes

aduh95 force-pushed the rmdir-recursive-DEP0147 branch from ed11b0e to cc39f06 Compare March 19, 2021 18:32

aduh95 added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Mar 19, 2021

aduh95 force-pushed the rmdir-recursive-DEP0147 branch from c0bd783 to 9948036 Compare March 20, 2021 18:17

aduh95 merged commit 9948036 into nodejs:master Mar 20, 2021

aduh95 deleted the rmdir-recursive-DEP0147 branch March 20, 2021 18:18

BethGriggs mentioned this pull request Apr 6, 2021

2021-04-20, Version 16.0.0 (Current) #37678

Merged

codebytere added a commit to electron/electron that referenced this pull request Jun 7, 2021

spec: fix failing asar test

0885330

nodejs/node#37216

codebytere added a commit to electron/electron that referenced this pull request Jun 8, 2021

spec: fix failing asar test

e6ae8c9

nodejs/node#37216

codebytere added a commit to electron/electron that referenced this pull request Jun 9, 2021

spec: fix failing asar test

96723b6

nodejs/node#37216

codebytere added a commit to electron/electron that referenced this pull request Jun 10, 2021

spec: fix failing asar test

01d5379

nodejs/node#37216

flotwig added a commit to cypress-io/cypress-example-recipes that referenced this pull request Nov 10, 2021

fix: ignore ENOENT on recursive rmdir

da8b648

in Node 16, this throws an error if `folderName` DNE nodejs/node#37216

aralovelace mentioned this pull request Mar 8, 2022

Add check if the directory exist ably/ably-ui#155

Merged

9 tasks

Mahesh-Prem pushed a commit to Mahesh-Prem/cypress that referenced this pull request Oct 15, 2023

fix: ignore ENOENT on recursive rmdir

5e00128

in Node 16, this throws an error if `folderName` DNE nodejs/node#37216

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fs: remove permissive rmdir recursive #37216

fs: remove permissive rmdir recursive #37216

aduh95 commented Feb 3, 2021 •

edited

iansu commented Feb 3, 2021

bcoe commented Feb 6, 2021

aduh95 commented Feb 7, 2021

iansu commented Feb 7, 2021

bcoe commented Feb 8, 2021

aduh95 commented Feb 8, 2021

bcoe left a comment

aduh95 commented Feb 17, 2021

bcoe Feb 18, 2021

Trott Mar 18, 2021

Trott Mar 18, 2021

bcoe left a comment

bcoe commented Feb 18, 2021

aduh95 commented Feb 18, 2021

iansu commented Feb 18, 2021

Trott commented Mar 18, 2021 •

edited

nodejs-github-bot commented Mar 18, 2021

mhdawson left a comment

nodejs-github-bot commented Mar 19, 2021

nodejs-github-bot commented Mar 19, 2021

nodejs-github-bot commented Mar 19, 2021

nodejs-github-bot commented Mar 20, 2021

nodejs-github-bot commented Mar 20, 2021

nodejs-github-bot commented Mar 20, 2021

nodejs-github-bot commented Mar 20, 2021

aduh95 commented Mar 20, 2021

fs: remove permissive rmdir recursive #37216

fs: remove permissive rmdir recursive #37216

Conversation

aduh95 commented Feb 3, 2021 • edited

iansu commented Feb 3, 2021

bcoe commented Feb 6, 2021

aduh95 commented Feb 7, 2021

iansu commented Feb 7, 2021

bcoe commented Feb 8, 2021

aduh95 commented Feb 8, 2021

bcoe left a comment

Choose a reason for hiding this comment

aduh95 commented Feb 17, 2021

bcoe Feb 18, 2021

Choose a reason for hiding this comment

Trott Mar 18, 2021

Choose a reason for hiding this comment

Trott Mar 18, 2021

Choose a reason for hiding this comment

bcoe left a comment

Choose a reason for hiding this comment

bcoe commented Feb 18, 2021

aduh95 commented Feb 18, 2021

iansu commented Feb 18, 2021

Trott commented Mar 18, 2021 • edited

nodejs-github-bot commented Mar 18, 2021

mhdawson left a comment

Choose a reason for hiding this comment

nodejs-github-bot commented Mar 19, 2021

nodejs-github-bot commented Mar 19, 2021

nodejs-github-bot commented Mar 19, 2021

nodejs-github-bot commented Mar 20, 2021

nodejs-github-bot commented Mar 20, 2021

nodejs-github-bot commented Mar 20, 2021

nodejs-github-bot commented Mar 20, 2021

aduh95 commented Mar 20, 2021

aduh95 commented Feb 3, 2021 •

edited

Trott commented Mar 18, 2021 •

edited