Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

deps: cherry-pick f4376ec801e1ded from V8 upstream #37225

Closed
wants to merge 2 commits into from
Closed

deps: cherry-pick f4376ec801e1ded from V8 upstream #37225

wants to merge 2 commits into from

Commits on Feb 8, 2021

  1. deps: cherry-pick f4376ec801e1ded from V8 upstream 

        Original commit message:
      [heap] Make maximum regular code object size a runtime value.

      Executable V8 pages include 3 reserved OS pages: one for the writable
      header and two as guards. On systems with 64k OS pages, the amount of
      allocatable space left for objects can then be quite smaller than the
      page size, only 64k for each 256k page.

      This means regular code objects cannot be larger than 64k, while the
      maximum regular object size is fixed to 128k, half of the page size. As
      a result code object never reach this limit and we can end up filling
      regular pages with few large code objects.

      To fix this, we change the maximum code object size to be runtime value,
      set to half of the allocatable space per page. On systems with 64k OS
      pages, the limit will be 32k.

      Alternatively, we could increase the V8 page size to 512k on Arm64 linux
      so we wouldn't waste code space. However, systems with 4k OS pages are
      more common, and those with 64k pages tend to have more memory available
      so we should be able to live with it.

      Bug: v8:10808
      Change-Id: I5d807e7a3df89f1e9c648899e9ba2f8e2648264c
      Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2460809
      Reviewed-by: Igor Sheludko <ishell@chromium.org>
      Reviewed-by: Georg Neis <neis@chromium.org>
      Reviewed-by: Ulan Degenbaev <ulan@chromium.org>
      Commit-Queue: Pierre Langlois <pierre.langlois@arm.com>
      Cr-Commit-Position: refs/heads/master@{#70569}

Refs: nodejs/help#3202
    @danbev
    danbev committed Feb 8, 2021
    Configuration menu
    Copy the full SHA
    ce35789 View commit details
    Browse the repository at this point in the history

  2. test: add arm64 arch to test-worker-prof status 

    This commit adds arm64 to test-worker-prof status as this seems to be
flaky on arm64 in addition to arm.
    @danbev
    danbev committed Feb 8, 2021
    Configuration menu
    Copy the full SHA
    c44140c View commit details
    Browse the repository at this point in the history