Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deps: V8: workaround for darwin arm64 code page decommit failures #37276

Closed
wants to merge 2 commits into from

Commits on Feb 8, 2021

  1. deps: V8: Workaround MacOS 11.2 code page decommit failures

    [mac][wasm] Work around MacOS 11.2 code page decommit failures
    
    MacOS 11.2 refuses to set "no access" permissions on memory that
    we previously used for JIT-compiled code. It is still unclear
    whether this is WAI on the part of the kernel. In the meantime,
    as a workaround, we use madvise(..., MADV_FREE_REUSABLE) instead
    of mprotect(..., NONE) when discarding code pages. This is inspired
    by what Chromium's gin platform does.
    
    Fixed: v8:11389
    Change-Id: I866586932573b4253002436ae5eee4e0411c45fc
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2679688
    Commit-Queue: Jakob Kummerow <jkummerow@chromium.org>
    Commit-Queue: Michael Lippautz <mlippautz@chromium.org>
    Auto-Submit: Jakob Kummerow <jkummerow@chromium.org>
    Reviewed-by: Michael Lippautz <mlippautz@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#72559}
    
    
    Related issue
    nodejs#37061
    matinzd committed Feb 8, 2021
    Configuration menu
    Copy the full SHA
    b5563f6 View commit details
    Browse the repository at this point in the history

Commits on Feb 9, 2021

  1. bump: v8: v8_embedder_string to 25

    matinzd committed Feb 9, 2021
    Configuration menu
    Copy the full SHA
    45dee7d View commit details
    Browse the repository at this point in the history