Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[v10.x] Reland npm 6.14.11 #37278

Closed
wants to merge 2 commits into from
Closed

[v10.x] Reland npm 6.14.11 #37278

wants to merge 2 commits into from

Conversation

richardlau
Copy link
Member

The first commit reverts the previous npm 6.14.11 update, which did not correctly report itself as npm 6.14.11. The second commit cherry-picks #37173. This PR has been opened to provide commit metadata for both.

cc @nodejs/releasers @nodejs/npm

richardlau and others added 2 commits February 8, 2021 15:45
@richardlau
Revert "deps: upgrade npm to 6.14.11"
7e28768 
This reverts commit cc6b695.
@ruyadorno @richardlau
deps: upgrade npm to 6.14.11
54617f3 
PR-URL: nodejs#37173
Reviewed-By: Myles Borins <myles.borins@gmail.com>
Reviewed-By: Beth Griggs <bgriggs@redhat.com>
@nodejs-github-bot nodejs-github-bot added npm Issues and PRs related to the npm client dependency or the npm registry. v10.x labels Feb 8, 2021
@richardlau richardlau mentioned this pull request Feb 8, 2021
Merged
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/36013/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/36018/

@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Feb 8, 2021 •
edited by richardlau

CI: https://ci.nodejs.org/job/node-test-pull-request/36021/ (✔️)

richardlau added a commit that referenced this pull request Feb 9, 2021
@richardlau
Revert "deps: upgrade npm to 6.14.11"
7b7fb43 
This reverts commit cc6b695.

PR-URL: #37278
Reviewed-By: Beth Griggs <bgriggs@redhat.com>
Reviewed-By: Ruy Adorno <ruyadorno@github.com>
richardlau pushed a commit that referenced this pull request Feb 9, 2021
@ruyadorno @richardlau
deps: upgrade npm to 6.14.11
fe2c980 
PR-URL: #37173
Reviewed-By: Myles Borins <myles.borins@gmail.com>
Reviewed-By: Beth Griggs <bgriggs@redhat.com>

Backport-PR-URL: #37278

Reviewed-By: Beth Griggs <bgriggs@redhat.com>
Reviewed-By: Ruy Adorno <ruyadorno@github.com>
@richardlau
Copy link
Member Author

Landed in 1c6fbd6...fe2c980.

@richardlau richardlau closed this Feb 9, 2021
@richardlau richardlau deleted the reland-npm-10.x branch February 9, 2021 14:50
@richardlau richardlau mentioned this pull request Feb 9, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ruyadorno ruyadorno ruyadorno approved these changes

@BethGriggs BethGriggs BethGriggs approved these changes

Assignees
No one assigned
Labels
npm Issues and PRs related to the npm client dependency or the npm registry.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@richardlau @nodejs-github-bot @ruyadorno @BethGriggs