deps: V8: cherry-pick beebee4f80ff

common.gypi

@@ -36,7 +36,7 @@
 
     # Reset this number to 0 on major V8 upgrades.
     # Increment by one for each non-official patch applied to deps/v8.
-    'v8_embedder_string': '-node.18',
+    'v8_embedder_string': '-node.19',
 
     ##### V8 defaults for Node.js #####
 

deps/v8/src/profiler/profiler-listener.cc

@@ -113,7 +113,8 @@ void ProfilerListener::CodeCreateEvent(LogEventsAndTags tag,
     // profiler as is stored on the code object, except that we transform source
     // positions to line numbers here, because we only care about attributing
     // ticks to a given line.
-    for (SourcePositionTableIterator it(abstract_code->source_position_table());
+    for (SourcePositionTableIterator it(
+             handle(abstract_code->source_position_table(), isolate_));
          !it.done(); it.Advance()) {
       int position = it.source_position().ScriptOffset();
       int inlining_id = it.source_position().InliningId();

test/addons/cpu-profiler-crash/binding.cc

@@ -0,0 +1,16 @@
+#include "node.h"
+#include "v8.h"
+#include "v8-profiler.h"
+
+static void StartCpuProfiler(const v8::FunctionCallbackInfo<v8::Value>& args) {
+  v8::CpuProfiler* profiler = v8::CpuProfiler::New(args.GetIsolate());
+  v8::Local<v8::String> profile_title = v8::String::NewFromUtf8(
+    args.GetIsolate(),
+    "testing",
+    v8::NewStringType::kInternalized).ToLocalChecked();
+  profiler->StartProfiling(profile_title, true);
+}
+
+NODE_MODULE_INIT(/* exports, module, context */) {
+  NODE_SET_METHOD(exports, "startCpuProfiler", StartCpuProfiler);
+}

test/addons/cpu-profiler-crash/binding.gyp

@@ -0,0 +1,9 @@
+{
+  'targets': [
+    {
+      'target_name': 'binding',
+      'sources': [ 'binding.cc' ],
+      'includes': ['../common.gypi'],
+    }
+  ]
+}

test/addons/cpu-profiler-crash/test.js

@@ -0,0 +1,20 @@
+'use strict';
+
+// This test crashes most of the time unless the v8 patch:
+// https://github.com/v8/v8/commit/beebee4f80ff2eb91187ef1e8fa00b8ff82a20b3
+// is applied.
+const common = require('../../common');
+const bindings = require(`./build/${common.buildType}/binding`);
+
+function fn() { setImmediate(fn); }
+setInterval(function() {
+  for (let i = 0; i < 1000000; i++)
+    fn();
+  clearInterval(this);
+  setTimeout(process.reallyExit, 2000);
+}, 0);
+
+
+setTimeout(() => {
+  bindings.startCpuProfiler();
+}, 1000);