Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

node-api: force env shutdown deferring behavior #37303

Closed
wants to merge 5 commits into from
Closed

node-api: force env shutdown deferring behavior #37303

wants to merge 5 commits into from

Commits on Feb 18, 2021

  1. node-api: force env shutdown deferring behavior 

    The finalizer normally never gets called while a reference is strong.
However, during environment shutdown all finalizers must get called. In
order to unify the deferring behavior with that of a regular
finalization, we must force the reference to be weak when we call its
finalizer during environment shutdown.

Fixes: nodejs#37236
Co-authored-by: Chengzhong Wu <legendecas@gmail.com>
    @legendecas @gabrielschulhof
    2 people authored and gabrielschulhof committed Feb 18, 2021
    Configuration menu
    Copy the full SHA
    4cf6a26 View commit details
    Browse the repository at this point in the history

  2. add test

    @gabrielschulhof
    Gabriel Schulhof authored and gabrielschulhof committed Feb 18, 2021
    Configuration menu
    Copy the full SHA
    167bb7f View commit details
    Browse the repository at this point in the history

  3. heed the linter

    @gabrielschulhof
    Gabriel Schulhof authored and gabrielschulhof committed Feb 18, 2021
    Configuration menu
    Copy the full SHA
    9f723be View commit details
    Browse the repository at this point in the history

  4. handle the case where the reference is not deleted in its destructor

    @gabrielschulhof
    Gabriel Schulhof authored and gabrielschulhof committed Feb 18, 2021
    Configuration menu
    Copy the full SHA
    df5463b View commit details
    Browse the repository at this point in the history

  5. put the _finalize_ran = true back in the else body

    @gabrielschulhof
    Gabriel Schulhof authored and gabrielschulhof committed Feb 18, 2021
    Configuration menu
    Copy the full SHA
    21e5b1d View commit details
    Browse the repository at this point in the history