Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

src: fix more MSVC warnings #37334

Closed
wants to merge 4 commits into from
Closed

src: fix more MSVC warnings #37334

wants to merge 4 commits into from

Commits on Feb 12, 2021

  1. src: avoid implicit type conversions (take 2) 

    This fixes more C4244 MSVC warnings in the code base.

Refs: nodejs#37149
    @targos
    targos committed Feb 12, 2021
    Copy the full SHA
    c0a9289 View commit details
    Browse the repository at this point in the history

  2. src: disable unfixable MSVC warnings 

    The following warnings are disabled:
- C4065 in node_revert.h: there are no security reversions on the master
  branch.
- C4003 in base64-inl.h: a macro is used four times, only once without
  parameters.
    @targos
    targos committed Feb 12, 2021
    Copy the full SHA
    6e89d73 View commit details
    Browse the repository at this point in the history

  3. src: fix ETW_WRITE_EMPTY_EVENT macro 

    A comment was written before the last line, hiding a check.
    @targos
    targos committed Feb 12, 2021
    Copy the full SHA
    4f94dbc View commit details
    Browse the repository at this point in the history

  4. fixup! src: fix ETW_WRITE_EMPTY_EVENT macro

    @targos
    targos committed Feb 12, 2021
    Copy the full SHA
    8d9cac8 View commit details
    Browse the repository at this point in the history