Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

errors: remove experimental from --enable-source-maps #37362

Closed
wants to merge 6 commits into from
Closed

errors: remove experimental from --enable-source-maps #37362

Changes from 4 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
d3e4f67
errors: remove experimental from --enable-source-maps
bcoe Feb 13, 2021
f1a0bf2
docs: document changes
bcoe Feb 13, 2021
8aca13d
fix link ordering
bcoe Feb 14, 2021
71c0a04
actually fix linting
bcoe Feb 14, 2021
3cc1702
meta: address review
bcoe Feb 15, 2021
8599d05
Update doc/api/cli.md
bcoe Feb 19, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
16 changes: 12 additions & 4 deletions doc/api/cli.md
View file
Open in desktop
Expand Up @@ -192,14 +192,21 @@ Enable FIPS-compliant crypto at startup. (Requires Node.js to be built with
### `--enable-source-maps`
<!-- YAML
added: v12.12.0
changes:
- version: REPLACEME
pr-url: https://github.com/nodejs/node/pull/37362
description: remove note about experimental status.
bcoe marked this conversation as resolved.
Show resolved Hide resolved
-->

> Stability: 1 - Experimental
Enable [Source Map v3][] support for stack traces.

Enable experimental Source Map v3 support for stack traces.
When using a transpiler, such as TypeScript, strack traces thrown by an
application reference the transpiled code, not the original source position.
`--enable-source-maps` enables caching of Source Maps and makes a best
effort to report stack traces relative to the original source file.

Currently, overriding `Error.prepareStackTrace` is ignored when the
`--enable-source-maps` flag is set.
Overriding `Error.prepareStackTrace` prevents `--enable-source-maps` from
modifiying the stack trace.

### `--experimental-abortcontroller`
<!-- YAML
Expand Down Expand Up @@ -1690,6 +1697,7 @@ $ node --max-old-space-size=1536 index.js
[REPL]: repl.md
[ScriptCoverage]: https://chromedevtools.github.io/devtools-protocol/tot/Profiler#type-ScriptCoverage
[Source Map]: https://sourcemaps.info/spec.html
[Source Map v3]: https://sourcemaps.info/spec.html
bcoe marked this conversation as resolved.
Show resolved Hide resolved
[Subresource Integrity]: https://developer.mozilla.org/en-US/docs/Web/Security/Subresource_Integrity
[V8 JavaScript code coverage]: https://v8project.blogspot.com/2017/12/javascript-code-coverage.html
[`--openssl-config`]: #cli_openssl_config_file
Expand Down