Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v15.9.0 proposal #37405

Closed
wants to merge 108 commits into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
108 commits
Select commit Hold shift + click to select a range
d2a487e
Revert "stream: fix .end() error propagation"
mcollina Jan 25, 2021
67c9a8e
doc: improve promise terminology
benjamingr Feb 2, 2021
9946c11
src: read exactly two tokens from Linux THP sysfs config
jayaddison Jan 25, 2021
13fe17c
test: split heap snapshot limit tests
Trott Feb 2, 2021
dc84c18
tls: add ability to get cert/peer cert as X509Certificate object
jasnell Jan 26, 2021
011910b
crypto: add keyObject.export() 'jwk' format option
panva Jan 26, 2021
e63b380
deps: upgrade npm to 7.5.2
ruyadorno Feb 2, 2021
1fea051
stream: improve Readable.from error handling
benjamingr Jan 31, 2021
ff02e5e
doc: fix 404 links in module.md
aduh95 Feb 3, 2021
3f815d9
doc: fix pr-url for DEP0148
aduh95 Feb 3, 2021
745aad7
tools: update ESLint to 7.19.0
cjihrig Jan 31, 2021
bfe0b46
src: simplify calls to BN_bin2bn in prime gen
tniessen Feb 1, 2021
4ebe38b
timers: introduce setInterval async iterator
Linkgoron Jan 30, 2021
5157525
test: remove flaky designation for test-http2-large-file
Trott Jan 31, 2021
b87c0d6
doc: fix typo in cli.md
0xkalvin Feb 3, 2021
4cdc5ea
http: fix ClientRequest unhandled errors
ronag Jan 16, 2021
48ce1eb
src: fix warning in string_search.h
RaisinTen Jan 30, 2021
eb08afd
doc: fix typo in globals.md
RaisinTen Feb 4, 2021
eb7ec1b
timers: remove flaky setInterval test
Feb 4, 2021
c377834
repl: refactor to avoid unsafe array iteration
aduh95 Feb 2, 2021
52c40c7
doc: fix CHANGELOG_ARCHIVE table of contents
aduh95 Feb 4, 2021
5906e85
doc: fix version number for DEP006
aduh95 Feb 4, 2021
acd087d
fs: add AbortSignal support to watch
benjamingr Feb 2, 2021
2a5f67b
src: refactor bookkeeping of bootstrap status
joyeecheung Jan 28, 2021
337b4e7
src: put (de)serialization code into node_snapshotable.h/cc
joyeecheung Jan 28, 2021
8a25405
doc: fix accommodate typos
cjihrig Feb 4, 2021
66a14d3
vm: add importModuleDynamically option to compileFunction
devsnek Sep 25, 2020
655d196
fs: use a default callback for fs.close()
jasnell Feb 1, 2021
0702d60
doc: fix webcrypto HMAC generateKey example
panva Feb 3, 2021
596bfb3
doc: mention CryptoKey in port.postMessage()
panva Feb 3, 2021
aebe532
doc: consistent webcrypto `node.keyObject` format
panva Feb 3, 2021
760f126
doc: mark Certificate methods as static, add missing KeyObject.from
panva Feb 3, 2021
3e2746f
crypto: remove webcrypto "DSA" JWK Key Type operations
panva Feb 3, 2021
48a634e
test: rename n-api to node-api
Feb 3, 2021
c302450
fs: allow passing negative zero fd
RaisinTen Jan 29, 2021
3fee5b2
repl: add auto‑completion for dynamic import calls
ExE-Boss Feb 2, 2021
dc38dd2
timers: fix unsafe array iteration
RaisinTen Feb 4, 2021
9dac99a
crypto: fix and simplify prime option validation
tniessen Feb 1, 2021
acabe08
lib: add weak event handlers
benjamingr Feb 4, 2021
354df9e
src: use make_shared for safe allocation
yashLadha Jan 30, 2021
a6053dc
src: add context for TODO comment in env.cc
yashLadha Jan 30, 2021
20c65b0
deps: V8: backport dfcf1e86fac0
targos Feb 7, 2021
eb0daae
tools: fix d8 macOS build
targos Feb 3, 2021
3079a78
src: avoid implicit type conversions
targos Jan 30, 2021
54d36b0
src: rename binding_data_name to type_name in BindingData
joyeecheung Jan 28, 2021
1a9bcdf
src: refactor v8 binding
joyeecheung Jan 28, 2021
d8d851a
tools: bump remark-present-lint-node from 2.0.0 to 2.0.1
Trott Feb 8, 2021
ebf3597
doc: rename N-API to Node-API
Feb 7, 2021
7c51cec
util: use assert for unreachable code
Trott Feb 6, 2021
7da1c9b
doc: use sentence case for headers in BUILDING.md
Trott Feb 6, 2021
47c4f1f
doc: use sentence case in README headers
Trott Feb 6, 2021
0e887ca
doc: fix typo in console.md
marsonya Feb 8, 2021
5a4288e
doc: fix typo in crypto.md
marsonya Feb 8, 2021
cd50e93
doc: warn about using strings as inputs in crypto
tniessen Feb 6, 2021
a693baa
module: use optional chaining in cjs/loader.js
RaisinTen Feb 5, 2021
55fd6b6
crypto: avoid infinite loops in prime generation
tniessen Feb 3, 2021
8483de4
test: only run prime test with supported OpenSSL
tniessen Feb 5, 2021
f6f9af6
lib: fix WebIDL `object` and dictionary type conversion
ExE-Boss Jan 24, 2021
6db5e79
tools: add GitHub Action linter for pr-url
aduh95 Feb 4, 2021
d1c1724
deps: upgrade npm to 7.5.3
ruyadorno Feb 8, 2021
85bed2e
doc: fix misnamed SHASUMS256.txt name in README.md
marsonya Feb 7, 2021
e28ea89
crypto: fix subtle.importKey JWK OKP public key import
panva Feb 6, 2021
42cc33c
src: add mutex to ManagedEVPPKey class
danbev Jan 7, 2021
061939d
node-api: allow retrieval of add-on file name
Feb 3, 2021
d63ac28
http: explain the unused argument in IncomingMessage._read
Ayase-252 Feb 8, 2021
f5d1bf9
http: explain the possibilty of refactor unused argument
Ayase-252 Feb 10, 2021
e28fa6c
src: fix return type of method in string_search.h
RaisinTen Feb 1, 2021
3464c9f
doc: discourage error event
benjamingr Feb 7, 2021
50e81ba
deps: V8: cherry-pick 0c8b6e415c30
matinzd Feb 8, 2021
facf3a5
doc: fix description of hasSubscribers
tniessen Feb 11, 2021
7d8fd3f
doc: refactor fs docs structure
jasnell Feb 1, 2021
d96a97a
module: make synthetic module evaluation steps return a Promise to su…
dandclark Feb 9, 2021
1ff375b
tools: avoid pending deprecation in doc generator
targos Feb 7, 2021
8487184
child_process: fix bad abort signal leak
Feb 6, 2021
15804e0
errors: align source-map stacks with spec
bcoe Feb 6, 2021
1fc8307
test: re-implement promises.setInterval() test robustly
Trott Feb 4, 2021
d0f1ff5
async_hooks: set unhandledRejection async context
Feb 7, 2021
fbcab10
url: move `URLSearchParams` method definitions
ExE-Boss Jan 6, 2021
676f696
url: fix definitions of `URL`/`SearchParams` methods and accessors
ExE-Boss Jan 5, 2021
a483c28
tools: fix lint-pr-url message
aduh95 Feb 10, 2021
cdd2fe5
doc: fix typo in /api/dns.md
marsonya Feb 10, 2021
804e7ae
doc: add version metadata for packages features
aduh95 Feb 9, 2021
f253cb9
doc: fix typo in buffer.md
marsonya Feb 7, 2021
85b1476
doc: fix typo in deprecations.md
marsonya Feb 8, 2021
c4faa39
perf_hooks: introduce createHistogram
jasnell Jan 30, 2021
610b29b
doc: fix performanceEntry.flags style format
chengcyber Feb 8, 2021
189ce39
doc: apply sentence case to release doc headers
Trott Feb 13, 2021
62b2648
doc: apply sentence-consistently in C++ style guide
Trott Feb 13, 2021
392c86d
doc: use sentence case in benchmark doc
Trott Feb 13, 2021
1e99175
doc: alphabetize crypto.* methods
Trott Feb 13, 2021
3db1b30
meta: update README releases section
Feb 11, 2021
e2a2bab
doc: link PACKAGE_EXPORTS_RESOLVE to ESM section
ugultopu Jan 30, 2021
f5e4625
doc: fix backticks in crypto API docs
tniessen Feb 8, 2021
c188466
doc: fix quotes in stream docs
tniessen Feb 8, 2021
dd054ca
doc: optimize HTML rendering
aduh95 Feb 9, 2021
c160d88
buffer: add @@toStringTag to Blob
cjihrig Feb 12, 2021
b2b6411
tools: update ESLint to 7.20.0
cjihrig Feb 12, 2021
88d3f74
fs: add fsPromises.watch()
jasnell Feb 1, 2021
799b2d5
policy: fix cascade getting scope
bmeck Feb 9, 2021
6d53e79
repl: refactor to avoid unsafe array iteration
aduh95 Feb 12, 2021
05a16e7
worker: refactor to avoid unsafe array iteration
aduh95 Feb 12, 2021
c0eadef
deps: upgrade to libuv 1.41.0
cjihrig Feb 13, 2021
b09d21b
test: enable no-restricted-syntax rule for test-timers-promisified
Trott Feb 13, 2021
d808db2
doc: add dmabupt to collaborators
dmabupt Feb 15, 2021
c6198fd
lib: simplify check in child_process
RaisinTen Feb 14, 2021
2e1f1c6
tools: refactor prefer-primordials
aduh95 Nov 7, 2020
b5692b4
test: fix test-doctool-html
aduh95 Feb 16, 2021
5133659
2021-02-16, Version 15.9.0 (Current)
danielleadams Feb 16, 2021
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Jump to
The table of contents is too big for display.
Diff view
Diff view
  •  
  •  
  •  
1 change: 1 addition & 0 deletions .eslintrc.js
Expand Up @@ -54,6 +54,7 @@ module.exports = {
{
files: [
'doc/api/esm.md',
'doc/api/fs.md',
'doc/api/module.md',
'doc/api/modules.md',
'doc/api/packages.md',
Expand Down
9 changes: 9 additions & 0 deletions .github/workflows/linters.yml
Expand Up @@ -98,3 +98,12 @@ jobs:
- uses: mszostok/codeowners-validator@v0.4.0
with:
checks: "files,duppatterns"
lint-pr-url:
if: ${{ github.event.pull_request }}
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v2
with:
fetch-depth: 2
# GH Actions squashes all PR commits, HEAD^ refers to the base branch.
- run: git diff HEAD^ HEAD -G"pr-url:" -- "*.md" | ./tools/lint-pr-url.mjs ${{ github.event.pull_request.html_url }}
6 changes: 3 additions & 3 deletions BUILDING.md
Expand Up @@ -8,7 +8,7 @@ If you can reproduce a test failure, search for it in the
[Node.js issue tracker](https://github.com/nodejs/node/issues) or
file a new issue.

## Table of Contents
## Table of contents

* [Supported platforms](#supported-platforms)
* [Input](#input)
Expand Down Expand Up @@ -309,7 +309,7 @@ To install this version of Node.js into a system directory:
[sudo] make install
```

#### Running Tests
#### Running tests

To verify the build:

Expand Down Expand Up @@ -379,7 +379,7 @@ You can use
[node-code-ide-configs](https://github.com/nodejs/node-code-ide-configs)
to run/debug tests, if your IDE configs are present.

#### Running Coverage
#### Running coverage

It's good practice to ensure any code you add or change is covered by tests.
You can do so by running the test suite with coverage enabled:
Expand Down
3 changes: 2 additions & 1 deletion CHANGELOG.md
Expand Up @@ -32,7 +32,8 @@ release.
</tr>
<tr>
<td valign="top">
<b><a href="doc/changelogs/CHANGELOG_V15.md#15.8.0">15.8.0</a></b><br/>
<b><a href="doc/changelogs/CHANGELOG_V15.md#15.9.0">15.9.0</a></b><br/>
<a href="doc/changelogs/CHANGELOG_V15.md#15.8.0">15.8.0</a><br/>
<a href="doc/changelogs/CHANGELOG_V15.md#15.7.0">15.7.0</a><br/>
<a href="doc/changelogs/CHANGELOG_V15.md#15.6.0">15.6.0</a><br/>
<a href="doc/changelogs/CHANGELOG_V15.md#15.5.1">15.5.1</a><br/>
Expand Down
30 changes: 16 additions & 14 deletions README.md
Expand Up @@ -18,7 +18,7 @@ The Node.js project uses an [open governance model](./GOVERNANCE.md). The

**This project is bound by a [Code of Conduct][].**

# Table of Contents
# Table of contents

* [Support](#support)
* [Release Types](#release-types)
Expand All @@ -41,11 +41,11 @@ The Node.js project uses an [open governance model](./GOVERNANCE.md). The
Looking for help? Check out the
[instructions for getting support](.github/SUPPORT.md).

## Release Types
## Release types

* **Current**: Under active development. Code for the Current release is in the
branch for its major version number (for example,
[v10.x](https://github.com/nodejs/node/tree/v10.x)). Node.js releases a new
[v15.x](https://github.com/nodejs/node/tree/v15.x)). Node.js releases a new
major version every 6 months, allowing for breaking changes. This happens in
April and October every year. Releases appearing each October have a support
life of 8 months. Releases appearing each April convert to LTS (see below)
Expand All @@ -69,29 +69,29 @@ For more information, see the
Binaries, installers, and source tarballs are available at
<https://nodejs.org/en/download/>.

#### Current and LTS Releases
#### Current and LTS releases
<https://nodejs.org/download/release/>

The [latest](https://nodejs.org/download/release/latest/) directory is an
alias for the latest Current release. The latest-_codename_ directory is an
alias for the latest release from an LTS line. For example, the
[latest-carbon](https://nodejs.org/download/release/latest-carbon/) directory
contains the latest Carbon (Node.js 8) release.
[latest-fermium](https://nodejs.org/download/release/latest-fermium/) directory
contains the latest Fermium (Node.js 14) release.

#### Nightly Releases
#### Nightly releases
<https://nodejs.org/download/nightly/>

Each directory name and filename contains a date (in UTC) and the commit
SHA at the HEAD of the release.

#### API Documentation
#### API documentation

Documentation for the latest Current release is at <https://nodejs.org/api/>.
Version-specific documentation is available in each release directory in the
_docs_ subdirectory. Version-specific documentation is also at
<https://nodejs.org/download/docs/>.

### Verifying Binaries
### Verifying binaries

Download directories contain a `SHASUMS256.txt` file with SHA checksums for the
files.
Expand All @@ -111,7 +111,7 @@ $ grep node-vx.y.z.tar.gz SHASUMS256.txt | sha256sum -c -

For Current and LTS, the GPG detached signature of `SHASUMS256.txt` is in
`SHASUMS256.txt.sig`. You can use it with `gpg` to verify the integrity of
`SHASUM256.txt`. You will first need to import
`SHASUMS256.txt`. You will first need to import
[the GPG keys of individuals authorized to create releases](#release-keys). To
import the keys:

Expand Down Expand Up @@ -147,7 +147,7 @@ For information on reporting security vulnerabilities in Node.js, see
* [Strategic Initiatives][]
* [Technical values and prioritization][]

## Current Project Team Members
## Current project team members

For information about the governance of the Node.js project, see
[GOVERNANCE.md](./GOVERNANCE.md).
Expand Down Expand Up @@ -194,7 +194,7 @@ For information about the governance of the Node.js project, see
* [Trott](https://github.com/Trott) -
**Rich Trott** &lt;rtrott@gmail.com&gt; (he/him)

### TSC Emeriti
### TSC emeriti

* [addaleax](https://github.com/addaleax) -
**Anna Henningsen** &lt;anna@addaleax.net&gt; (she/her)
Expand Down Expand Up @@ -289,6 +289,8 @@ For information about the governance of the Node.js project, see
**David Carlier** &lt;devnexen@gmail.com&gt;
* [devsnek](https://github.com/devsnek) -
**Gus Caplan** &lt;me@gus.host&gt; (they/them)
* [dmabupt](https://github.com/dmabupt) -
**Xu Meng** &lt;dmabupt@gmail.com&gt; (he/him)
* [dnlup](https://github.com/dnlup)
**Daniele Belardi** &lt;dwon.dnl@gmail.com&gt; (he/him)
* [edsadr](https://github.com/edsadr) -
Expand Down Expand Up @@ -454,7 +456,7 @@ For information about the governance of the Node.js project, see
* [ZYSzys](https://github.com/ZYSzys) -
**Yongsheng Zhang** &lt;zyszys98@gmail.com&gt; (he/him)

### Collaborator Emeriti
### Collaborator emeriti

* [andrasq](https://github.com/andrasq) -
**Andras** &lt;andras@kinvey.com&gt;
Expand Down Expand Up @@ -594,7 +596,7 @@ maintaining the Node.js project.
* [RaisinTen](https://github.com/RaisinTen) -
**Darshan Sen** &lt;raisinten@gmail.com&gt;

### Release Keys
### Release keys

Primary GPG keys for Node.js Releasers (some Releasers sign with subkeys):

Expand Down
2 changes: 1 addition & 1 deletion common.gypi
Expand Up @@ -36,7 +36,7 @@

# Reset this number to 0 on major V8 upgrades.
# Increment by one for each non-official patch applied to deps/v8.
'v8_embedder_string': '-node.23',
'v8_embedder_string': '-node.25',

##### V8 defaults for Node.js #####

Expand Down
54 changes: 54 additions & 0 deletions deps/npm/CHANGELOG.md
@@ -1,3 +1,57 @@
## v7.5.3 (2021-02-08)

### BUG FIXES

* [`df596bf4c`](https://github.com/npm/cli/commit/df596bf4c10d6917672579cc38800f5e846002bc)
fix(publish): follow all configs for registry auth check
[#2602](https://github.com/npm/cli/issues/2602)
([@wraithgar](https://github.com/wraithgar))
* [`6d7afb03c`](https://github.com/npm/cli/commit/6d7afb03cd7602b60e709516711a2f94cd61ff25)
[#2613](https://github.com/npm/cli/issues/2613)
install script: pass -q to curl calls to disable user .curlrc files
([@nlf](https://github.com/nlf))

### DEPENDENCIES

* [`3294fed6f`](https://github.com/npm/cli/commit/3294fed6f18626516978c21fac5f28ecfdb58124)
`pacote@11.2.5`
* prevent infinite recursion in git dep preparation
* [`0f7a3a87c`](https://github.com/npm/cli/commit/0f7a3a87c12e30bdd2cdab596ca6511de787c969)
`read-package-json-fast@2.0.1`
* avoid duplicating optionalDependencies as dependencies in package.json
* [`6f46b0f7f`](https://github.com/npm/cli/commit/6f46b0f7fef9891e6de4af3547c70a67cb3a7a13)
`init-package-json@2.0.2`
* [`df4f65acc`](https://github.com/npm/cli/commit/df4f65acc4ceaf15db4c227670e80f94584c055c)
`@npmcli/arborist@2.2.0`
* [`7038c2ff4`](https://github.com/npm/cli/commit/7038c2ff49022f8babd495d1b831b5c82d6aed05)
`@npmcli/run-script@1.8.2`
* [`54cd4c87a`](https://github.com/npm/cli/commit/54cd4c87a71c9381519d8ac52e306096066dc92e)
`libnpmversion@1.0.8`
* [`9ab36aae4`](https://github.com/npm/cli/commit/9ab36aae429784df754211d5f086a515012b9bdd)
`graceful-fs@4.2.5`
* [`e1822cf27`](https://github.com/npm/cli/commit/e1822cf277336728f1d5696ffe0db3ea6e700d9e)
`@npmcli/installed-package-contents@1.0.7`

## v7.5.2 (2021-02-02)

### BUG FIXES

* [`37613e4e6`](https://github.com/npm/cli/commit/37613e4e686e4891210acaabc9c23f41456eda3f)
[#2395](https://github.com/npm/cli/issues/2395)
[#2329](https://github.com/npm/cli/issues/2329)
fix(exec): use latest version when possible
([@wraithgar](https://github.com/wraithgar))
* [`567c9bd03`](https://github.com/npm/cli/commit/567c9bd03a7669111fbba6eb6d1f12ed7cad5a1b)
fix(lib/npm): do not clobber config.execPath
([@wraithgar](https://github.com/wraithgar))

### DEPENDENCIES

* [`643709706`](https://github.com/npm/cli/commit/64370970653af5c8d7a2be2c2144e355aa6431b0)
`@npmcli/config@1.2.9` ([@isaacs](https://github.com/isaacs))
* [`4c6be4a`](https://github.com/npm/config/commit/4c6be4a66a3e89ae607e08172b8543b588a95fb5) Restore npm v6 behavior with `INIT_CWD`
* [`bbebc66`](https://github.com/npm/config/commit/bbebc668888f71dba57959682364b6ff26ff4fac) Do not set the `PREFIX` environment variable

## v7.5.1 (2021-02-01

### BUG FIXES
Expand Down
4 changes: 2 additions & 2 deletions deps/npm/README.md
Expand Up @@ -15,7 +15,7 @@
You can download & install **`npm`** directly from [**npmjs**.com](https://npmjs.com/) using our custom `install.sh` script:

```bash
curl -L https://www.npmjs.com/install.sh | sh
curl -qL https://www.npmjs.com/install.sh | sh
```

#### Node Version Managers
Expand Down Expand Up @@ -50,4 +50,4 @@ npm <command>
### Acknowledgments

* `npm` is configured to use the **npm Public Registry** at [https://registry.npmjs.org](https://registry.npmjs.org) by default; Usage of this registry is subject to **Terms of Use** available at [https://npmjs.com/policies/terms](https://npmjs.com/policies/terms)
* You can configure `npm` to use any other compatible registry you prefer. You can read more about configuring third-party registries [here](https://docs.npmjs.com/cli/v7/using-npm/registry)
* You can configure `npm` to use any other compatible registry you prefer. You can read more about configuring third-party registries [here](https://docs.npmjs.com/cli/v7/using-npm/registry)
2 changes: 1 addition & 1 deletion deps/npm/docs/output/commands/npm-ls.html
Expand Up @@ -159,7 +159,7 @@ <h3 id="description">Description</h3>
the results to only the paths to the packages named. Note that nested
packages will <em>also</em> show the paths to the specified packages. For
example, running <code>npm ls promzard</code> in npm’s source tree will show:</p>
<pre lang="bash"><code>npm@7.5.1 /path/to/npm
<pre lang="bash"><code>npm@7.5.3 /path/to/npm
└─┬ init-package-json@0.0.4
└── promzard@0.1.5
</code></pre>
Expand Down
2 changes: 1 addition & 1 deletion deps/npm/docs/output/commands/npm.html
Expand Up @@ -148,7 +148,7 @@ <h2 id="table-of-contents">Table of contents</h2>
<pre lang="bash"><code>npm &lt;command&gt; [args]
</code></pre>
<h3 id="version">Version</h3>
<p>7.5.1</p>
<p>7.5.3</p>
<h3 id="description">Description</h3>
<p>npm is the package manager for the Node JavaScript platform. It puts
modules in place so that node can find them, and manages dependency
Expand Down
14 changes: 11 additions & 3 deletions deps/npm/lib/exec.js
Expand Up @@ -169,8 +169,12 @@ const exec = async args => {
return await readPackageJson(pj)
} catch (er) {}
}
// Force preferOnline to true so we are making sure to pull in the latest
// This is especially useful if the user didn't give us a version, and
// they expect to be running @latest
return await pacote.manifest(p, {
...npm.flatOptions,
preferOnline: true,
})
}))

Expand All @@ -193,9 +197,13 @@ const exec = async args => {
const arb = new Arborist({ ...npm.flatOptions, path: installDir })
const tree = await arb.loadActual()

// any that don't match the manifest we have, install them
// add installDir/node_modules/.bin to pathArr
const add = manis.filter(mani => manifestMissing(tree, mani))
// at this point, we have to ensure that we get the exact same
// version, because it's something that has only ever been installed
// by npm exec in the cache install directory
const add = manis.filter(mani => manifestMissing(tree, {
...mani,
_from: `${mani.name}@${mani.version}`,
}))
.map(mani => mani._from)
.sort((a, b) => a.localeCompare(b))

Expand Down