v15.9.0 proposal #37406
Merged
v15.9.0 proposal #37406
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PR-URL: #37181 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Zijian Liu <lxxyxzj@gmail.com> Reviewed-By: Darshan Sen <raisinten@gmail.com>
There was an unexpected and hard-to-spot issue here: the /sys/kernel/mm/transparent_hugepage/enabled file contains three entries, and the std::ifstream reader was reading two values on each loop iteration, resulting in incorrect behaviour. Fixes: #37064 PR-URL: #37065 Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
test/parallel/test-heapsnapshot-near-heap-limit.js is timing out in CI on low-memory and slow-CPU devices. Split off the worker test to its own test file to allow the test to finish in time. Refs: #36961 PR-URL: #37189 Reviewed-By: Ash Cripps <acripps@redhat.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Filip Skokan <panva.ip@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Richard Lau <rlau@redhat.com>
Signed-off-by: James M Snell <jasnell@gmail.com> PR-URL: #37070 Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Filip Skokan <panva.ip@gmail.com>
Adds [JWK](https://tools.ietf.org/html/rfc7517) keyObject.export format option. Supported key types: `ec`, `rsa`, `ed25519`, `ed448`, `x25519`, `x448`, and symmetric keys, resulting in JWK `kty` (Key Type) values `EC`, `RSA`, `OKP`, and `oct`. `rsa-pss` is not supported since the JWK format does not support PSS Parameters. `EC` JWK curves supported are `P-256`, `secp256k1`, `P-384`, and `P-521` PR-URL: #37081 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de>
PR-URL: #37191 Reviewed-By: Myles Borins <myles.borins@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
PR-URL: #37158 Reviewed-By: Robert Nagy <ronagy@icloud.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
PR-URL: #37202 Reviewed-By: Zijian Liu <lxxyxzj@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Beth Griggs <bgriggs@redhat.com> Reviewed-By: Darshan Sen <raisinten@gmail.com>
PR-URL: #37205 Reviewed-By: Beth Griggs <bgriggs@redhat.com> Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Pooja D P <Pooja.D.P@ibm.com> Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: Zijian Liu <lxxyxzj@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Update ESLint to 7.19.0 PR-URL: #37159 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
PR-URL: #37169 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
Added setInterval async generator to timers\promises. Utilises async generators to provide an iterator compatible with `for await`. Co-Authored-By: Fabian Cook <hello@fabiancook.dev> fix message PR-URL: #37153 Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
This seems to have stopped happening, possibly because it only ever happened on win2008 and that went eol last year. Closes: #22327 PR-URL: #37156 Fixes: #22327 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Stephen Belanger <admin@stephenbelanger.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: James M Snell <jasnell@gmail.com>
PR-URL: #37214 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
PR-URL: #37228 Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Zijian Liu <lxxyxzj@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
PR-URL: #37227 Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
PR-URL: #37188 Reviewed-By: Zijian Liu <lxxyxzj@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Darshan Sen <raisinten@gmail.com>
PR-URL: #37232 Refs: https://github.com/nodejs/node/blob/master/doc/changelogs/CHANGELOG_ARCHIVE.md#0.8.0 Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Beth Griggs <bgriggs@redhat.com>
PR-URL: #37231 Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Pooja D P <Pooja.D.P@ibm.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
This patch 1. Refactors the bootstrap routine of the main instance so that when --no-node-snapshot is used, Environment::InitializeMainContext() will only be called once (previously it would be called twice, which was harmless for now but not ideal). 2. Mark the number of BaseObjects in RunBootstrapping() when creating the Environment from scratch and in InitializeMainContext() when the Environment is deserialized. Previously the marking was done in the Environment constructor and InitializeMainContext() respectively for the cctest which was incorrect because the cctest never uses an Environment that's not bootstrapped. Also renames the mark to base_object_created_after_bootstrap to reflect what it's intended for. PR-URL: #37113 Refs: #36943 Reviewed-By: James M Snell <jasnell@gmail.com>
PR-URL: #37229 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Michael Dawson <midawson@redhat.com> Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com> Reviewed-By: Pooja D P <Pooja.D.P@ibm.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Darshan Sen <raisinten@gmail.com>
The `fs.close()` function requires a callback. Most often the only thing that callback does is check and rethrow the error if one occurs. To eliminate common boilerplate, make the callback optional with a default that checks and rethrows the error as an uncaught exception. Signed-off-by: James M Snell <jasnell@gmail.com> PR-URL: #37174 Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Zijian Liu <lxxyxzj@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
PR-URL: #37197 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de>
PR-URL: #37196 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de>
This comment has been minimized.
This comment has been minimized.
danielleadams
force-pushed
the
v15.9.0-proposal
branch
from
5133659
to
889ffde
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
targos
requested changes
Feb 17, 2021
danielleadams
force-pushed
the
v15.9.0-proposal
branch
from
889ffde
to
b471267
Compare
PR-URL: #37406 Notable Changes: * crypto: * add keyObject.export() jwk format option (Filip Skokan) #37081 * deps: * upgrade to libuv 1.41.0 (Colin Ihrig) #37360 * doc: * add dmabupt to collaborators (Xu Meng) #37377 * refactor fs docs structure (James M Snell) #37170 * fs: * add fsPromises.watch() (James M Snell) #37179 * use a default callback for fs.close() (James M Snell) #37174 * add AbortSignal support to watch (Benjamin Gruenbaum) #37190 * perf_hooks: * introduce createHistogram (James M Snell) #37155 * stream: * improve Readable.from error handling (Benjamin Gruenbaum) #37158 * timers: * introduce setInterval async iterator (linkgoron) #37153 * tls: * add ability to get cert/peer cert as X509Certificate object (James M Snell) #37070
danielleadams
force-pushed
the
v15.9.0-proposal
branch
from
b471267
to
877f66e
Compare
|
@targos fixed, and added 👍🏼 |
targos
approved these changes
Feb 17, 2021
This comment has been minimized.
This comment has been minimized.
richardlau
approved these changes
Feb 17, 2021
This comment has been minimized.
This comment has been minimized.
codebytere
approved these changes
Feb 17, 2021
BethGriggs
approved these changes
Feb 17, 2021
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
danielleadams
added a commit
that referenced
this pull request
Feb 18, 2021
PR-URL: #37406 Notable Changes: * crypto: * add keyObject.export() jwk format option (Filip Skokan) #37081 * deps: * upgrade to libuv 1.41.0 (Colin Ihrig) #37360 * doc: * add dmabupt to collaborators (Xu Meng) #37377 * refactor fs docs structure (James M Snell) #37170 * fs: * add fsPromises.watch() (James M Snell) #37179 * use a default callback for fs.close() (James M Snell) #37174 * add AbortSignal support to watch (Benjamin Gruenbaum) #37190 * perf_hooks: * introduce createHistogram (James M Snell) #37155 * stream: * improve Readable.from error handling (Benjamin Gruenbaum) #37158 * timers: * introduce setInterval async iterator (linkgoron) #37153 * tls: * add ability to get cert/peer cert as X509Certificate object (James M Snell) #37070
danielleadams
pushed a commit
to danielleadams/nodejs.org
that referenced
this pull request
Feb 18, 2021
danielleadams
added a commit
to nodejs/nodejs.org
that referenced
this pull request
Feb 18, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
2021-02-17, Version 15.9.0 (Current), @danielleadams
Notable Changes
Commits
d0f1ff53ff] - async_hooks: set unhandledRejection async context (Sajal Khandelwal) #37281c160d88c9e] - buffer: add @@toStringTag to Blob (Colin Ihrig) #373368487184457] - child_process: fix bad abort signal leak (Nitzan Uziely) #37257e28ea89b1a] - crypto: fix subtle.importKey JWK OKP public key import (Filip Skokan) #3725555fd6b6611] - crypto: avoid infinite loops in prime generation (Tobias Nießen) #372129dac99a11a] - crypto: fix and simplify prime option validation (Tobias Nießen) #371643e2746ff63] - crypto: remove webcrypto "DSA" JWK Key Type operations (Filip Skokan) #37203011910b424] - (SEMVER-MINOR) crypto: add keyObject.export() 'jwk' format option (Filip Skokan) #37081c0eadef495] - deps: upgrade to libuv 1.41.0 (Colin Ihrig) #3736050e81ba0b8] - deps: V8: cherry-pick 0c8b6e415c30 (Matin Zadehdolatabad) #37276d1c1724c69] - deps: upgrade npm to 7.5.3 (Ruy Adorno) #3728320c65b00c2] - deps: V8: backport dfcf1e86fac0 (Michaël Zasso) #37245e63b380f76] - deps: upgrade npm to 7.5.2 (Ruy Adorno) #37191d808db2732] - doc: add dmabupt to collaborators (Xu Meng) #37377dd054ca37f] - doc: optimize HTML rendering (Antoine du Hamel) #37301c188466a18] - doc: fix quotes in stream docs (Tobias Nießen) #37269f5e4625468] - doc: fix backticks in crypto API docs (Tobias Nießen) #37269e2a2bab44e] - doc: link PACKAGE_EXPORTS_RESOLVE to ESM section (Utku Gultopu) #371351e99175e01] - doc: alphabetize crypto.* methods (Rich Trott) #37353392c86d38b] - doc: use sentence case in benchmark doc (Rich Trott) #3735162b2648a96] - doc: apply sentence-consistently in C++ style guide (Rich Trott) #37350189ce399da] - doc: apply sentence case to release doc headers (Rich Trott) #37349610b29b8bd] - doc: fix performanceEntry.flags style format (Cheng Liu) #3727485b1476f1d] - doc: fix typo in deprecations.md (marsonya) #37282f253cb9303] - doc: fix typo in buffer.md (marsonya) #37268804e7ae713] - doc: add version metadata for packages features (Antoine du Hamel) #37289cdd2fe5651] - doc: fix typo in /api/dns.md (marsonya) #373127d8fd3f576] - doc: refactor fs docs structure (James M Snell) #37170facf3a5c23] - doc: fix description of hasSubscribers (Tobias Nießen) #373243464c9f007] - doc: discourage error event (Benjamin Gruenbaum) #3726485bed2ec26] - doc: fix misnamed SHASUMS256.txt name in README.md (marsonya) #37260cd50e93307] - doc: warn about using strings as inputs in crypto (Tobias Nießen) #372485a4288ebb6] - doc: fix typo in crypto.md (marsonya) #372790e887caf32] - doc: fix typo in console.md (marsonya) #3727947c4f1fc54] - doc: use sentence case in README headers (Rich Trott) #372517da1c9b219] - doc: use sentence case for headers in BUILDING.md (Rich Trott) #37250ebf3597db1] - doc: rename N-API to Node-API (Gabriel Schulhof) #37259760f126adb] - doc: mark Certificate methods as static, add missing KeyObject.from (Filip Skokan) #37198aebe532967] - doc: consistent webcryptonode.keyObjectformat (Filip Skokan) #37200596bfb36a0] - doc: mention CryptoKey in port.postMessage() (Filip Skokan) #371960702d60def] - doc: fix webcrypto HMAC generateKey example (Filip Skokan) #371978a254058f5] - doc: fix accommodate typos (Colin Ihrig) #372295906e85ce2] - doc: fix version number for DEP006 (Antoine du Hamel) #3723152c40c7a48] - doc: fix CHANGELOG_ARCHIVE table of contents (Antoine du Hamel) #37232eb08afdf24] - doc: fix typo in globals.md (Darshan Sen) #37228b87c0d6c16] - doc: fix typo in cli.md (Kalvin Vasconcellos) #372143f815d93bf] - doc: fix pr-url for DEP0148 (Antoine du Hamel) #37205ff02e5e12c] - doc: fix 404 links in module.md (Antoine du Hamel) #3720267c9a8e176] - doc: improve promise terminology (Benjamin Gruenbaum) #3718115804e0b3f] - errors: align source-map stacks with spec (Benjamin Coe) #3725288d3f74c85] - (SEMVER-MINOR) fs: add fsPromises.watch() (James M Snell) #37179c30245072a] - fs: allow passing negative zero fd (Darshan Sen) #37123655d19638a] - (SEMVER-MINOR) fs: use a default callback for fs.close() (James M Snell) #37174acd087dffb] - (SEMVER-MINOR) fs: add AbortSignal support to watch (Benjamin Gruenbaum) #37190f5d1bf9d0e] - http: explain the possibilty of refactor unused argument (Qingyu Deng) #37275d63ac28a9a] - http: explain the unused argument in IncomingMessage._read (Qingyu Deng) #372754cdc5ea823] - http: fix ClientRequest unhandled errors (Robert Nagy) #36970c6198fddc7] - lib: simplify check in child_process (Darshan Sen) #37367f6f9af6a59] - lib: fix WebIDLobjectand dictionary type conversion (ExE Boss) #37047acabe08b10] - lib: add weak event handlers (Benjamin Gruenbaum) #366073db1b30732] - meta: update README releases section (Zuzana Svetlikova) #37318d96a97a2b9] - module: make synthetic module evaluation steps return a Promise to support top level await (Daniel Clark) #37300a693baa0cb] - module: use optional chaining in cjs/loader.js (Darshan Sen) #37238061939d2f6] - (SEMVER-MINOR) node-api: allow retrieval of add-on file name (Gabriel Schulhof) #37195c4faa39768] - (SEMVER-MINOR) perf_hooks: introduce createHistogram (James M Snell) #37155799b2d5275] - policy: fix cascade getting scope (Bradley Meck) #372986d53e797d7] - repl: refactor to avoid unsafe array iteration (Antoine du Hamel) #373453fee5b2219] - repl: add auto‑completion for dynamic import calls (ExE Boss) #37178c3778343aa] - repl: refactor to avoid unsafe array iteration (Antoine du Hamel) #37188e28fa6c3fc] - src: fix return type of method in string_search.h (Darshan Sen) #3716742cc33cc48] - src: add mutex to ManagedEVPPKey class (Daniel Bevenius) #368251a9bcdf1d9] - src: refactor v8 binding (Joyee Cheung) #3711254d36b00af] - src: rename binding_data_name to type_name in BindingData (Joyee Cheung) #371123079a78428] - src: avoid implicit type conversions (Michaël Zasso) #37149a6053dc14a] - src: add context for TODO comment in env.cc (Yash Ladha) #37140354df9e8a1] - src: use make_shared for safe allocation (Yash Ladha) #37139337b4e7540] - src: put (de)serialization code into node_snapshotable.h/cc (Joyee Cheung) #371142a5f67b381] - src: refactor bookkeeping of bootstrap status (Joyee Cheung) #3711348ce1eb364] - src: fix warning in string_search.h (Darshan Sen) #37146bfe0b46d92] - src: simplify calls to BN_bin2bn in prime gen (Tobias Nießen) #371699946c1137e] - src: read exactly two tokens from Linux THP sysfs config (James Addison) #370651fea05149a] - (SEMVER-MINOR) stream: improve Readable.from error handling (Benjamin Gruenbaum) #37158d2a487e640] - Revert "stream: fix .end() error propagation" (Matteo Collina) #37060b5692b4b06] - test: fix test-doctool-html (Antoine du Hamel) #37397b09d21b06b] - test: enable no-restricted-syntax rule for test-timers-promisified (Rich Trott) #373571fc8307138] - test: re-implement promises.setInterval() test robustly (Rich Trott) #372308483de4da8] - test: only run prime test with supported OpenSSL (Tobias Nießen) #3721248a634e514] - test: rename n-api to node-api (Gabriel Schulhof) #3721751575252f5] - test: remove flaky designation for test-http2-large-file (Rich Trott) #3715613fe17c4ef] - test: split heap snapshot limit tests (Rich Trott) #37189dc38dd2c6f] - timers: fix unsafe array iteration (Darshan Sen) #37223eb7ec1b257] - timers: remove flaky setInterval test (Nitzan Uziely) #372274ebe38b212] - (SEMVER-MINOR) timers: introduce setInterval async iterator (linkgoron) #37153dc84c181c3] - (SEMVER-MINOR) tls: add ability to get cert/peer cert as X509Certificate object (James M Snell) #370702e1f1c6f3c] - tools: refactor prefer-primordials (Antoine du Hamel) #36018b2b64113b1] - tools: update ESLint to 7.20.0 (Colin Ihrig) #37339a483c284f3] - tools: fix lint-pr-url message (Antoine du Hamel) #373041ff375beb3] - tools: avoid pending deprecation in doc generator (Michaël Zasso) #372676db5e7958a] - tools: add GitHub Action linter for pr-url (Antoine du Hamel) #37221d8d851ac5c] - tools: bump remark-present-lint-node from 2.0.0 to 2.0.1 (Rich Trott) #37270eb0daaedf9] - tools: fix d8 macOS build (Michaël Zasso) #37211745aad73dc] - tools: update ESLint to 7.19.0 (Colin Ihrig) #37159676f696a99] - url: fix definitions ofURL/SearchParamsmethods and accessors (ExE Boss) #36799fbcab109de] - url: moveURLSearchParamsmethod definitions (ExE Boss) #367997c51cecbca] - util: use assert for unreachable code (Rich Trott) #3724966a14d3992] - vm: add importModuleDynamically option to compileFunction (Gus Caplan) #3543105a16e7259] - worker: refactor to avoid unsafe array iteration (Antoine du Hamel) #37346