Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: add url.resolve replacement example #37501

Merged
merged 1 commit into from Feb 26, 2021
Merged

doc: add url.resolve replacement example #37501

merged 1 commit into from Feb 26, 2021

Conversation

aduh95
Copy link
Contributor

@aduh95 aduh95 commented Feb 24, 2021

Fixes: #37492

@nodejs-github-bot nodejs-github-bot added doc Issues and PRs related to the documentations. url Issues and PRs related to the legacy built-in url module. labels Feb 24, 2021
@aduh95 aduh95 mentioned this pull request Feb 24, 2021
Closed
@aduh95 aduh95 added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Feb 24, 2021
@aduh95
doc: add url.resolve replacement example
5d240c5 
Fixes: nodejs#37492

PR-URL: nodejs#37501
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
@aduh95 aduh95 merged commit 5d240c5 into nodejs:master Feb 26, 2021
@aduh95
Copy link
Contributor Author

aduh95 commented Feb 26, 2021

Landed in 5d240c5

@aduh95 aduh95 deleted the url-resolve-whatwg branch February 26, 2021 15:36
targos pushed a commit that referenced this pull request Feb 28, 2021
@aduh95 @targos
doc: add url.resolve replacement example
0fac27d 
Fixes: #37492

PR-URL: #37501
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
@targos targos mentioned this pull request Mar 2, 2021
Merged
targos pushed a commit that referenced this pull request May 1, 2021
@aduh95 @targos
doc: add url.resolve replacement example
ff1990c 
Fixes: #37492

PR-URL: #37501
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
@danielleadams danielleadams mentioned this pull request May 3, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jasnell jasnell jasnell approved these changes

@marsonya marsonya marsonya approved these changes

@RaisinTen RaisinTen RaisinTen approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. doc Issues and PRs related to the documentations. url Issues and PRs related to the legacy built-in url module.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Please un-deprecate url.resolve
5 participants
@aduh95 @jasnell @marsonya @RaisinTen @nodejs-github-bot