Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: apply sentence case to headers in doc/guides #37506

Merged
merged 1 commit into from Feb 27, 2021
Merged

doc: apply sentence case to headers in doc/guides #37506

merged 1 commit into from Feb 27, 2021

Conversation

marsonya
Copy link
Member

changes as per doc styling guidelines

@nodejs-github-bot nodejs-github-bot added the doc Issues and PRs related to the documentations. label Feb 24, 2021
@Trott
Copy link
Member

Trott commented Feb 24, 2021

Optional nit: It would be good for this and the other PR with the same commit message to specify the files changed. It can be in the commit body if there's no room in the first line.

@marsonya
Copy link
Member Author

Optional nit: It would be good for this and the other PR with the same commit message to specify the files changed. It can be in the commit body if there's no room in the first line.

Sure. I will specify file description in comit message/body.

PR-URL: #37506
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Pooja D P <Pooja.D.P@ibm.com>
Reviewed-By: Harshitha K P <harshitha014@gmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
@Trott Trott merged commit 0486cb8 into nodejs:master Feb 27, 2021
@Trott
Copy link
Member

Trott commented Feb 27, 2021

Landed in 0486cb8

targos pushed a commit that referenced this pull request Feb 28, 2021
PR-URL: #37506
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Pooja D P <Pooja.D.P@ibm.com>
Reviewed-By: Harshitha K P <harshitha014@gmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
targos pushed a commit that referenced this pull request May 1, 2021
PR-URL: #37506
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Pooja D P <Pooja.D.P@ibm.com>
Reviewed-By: Harshitha K P <harshitha014@gmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
@danielleadams danielleadams mentioned this pull request May 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
doc Issues and PRs related to the documentations.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants