Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: revise objections section of collaborator guide #37525

Merged
merged 1 commit into from Mar 1, 2021

Commits on Mar 1, 2021

  1. doc: revise objections section of collaborator guide

    The bold text is overused in this section. This change removes it. It
    also changes some wording: PR -> pull request, can -> may in a rare
    instance where "may" is the right choice in our docs, etc. (The
    recommendation to avoid "may" is because "may" implies permission rather
    than just ability. Yes, I'm probably the one that changed it from "may"
    in the first place.)
    
    PR-URL: nodejs#37525
    Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
    Reviewed-By: Michaël Zasso <targos@protonmail.com>
    Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
    Reviewed-By: Darshan Sen <raisinten@gmail.com>
    Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de>
    Trott committed Mar 1, 2021
    Configuration menu
    Copy the full SHA
    be1cc51 View commit details
    Browse the repository at this point in the history