Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[v12.x backport] deps: V8: cherry-pick beebee4f80ff #37578

Closed

Commits on Mar 2, 2021

  1. deps: V8: cherry-pick beebee4f80ff

    Original commit message:
    ```
    cpu-profiler: Use Handle version of SourcePositionTableIterator
    
    The surrounding code can trigger an allocation through InliningStack
    which can eventually end up allocating a line ends array.
    
    This is fine as-is because the existing iterator code makes a copy
    of the byte array. It just triggers the no_gc dcheck in debug mode.
    
    Fixed: v8:10778
    Change-Id: Ic8c502767ec6c3d3b1f5e84df60638bd2fc6be75
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2339102
    Auto-Submit: Peter Marshall <petermarshall@chromium.org>
    Commit-Queue: Tobias Tebbi <tebbi@chromium.org>
    Reviewed-by: Tobias Tebbi <tebbi@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#69247}
    ```
    
    Refs: v8/v8@beebee4
    
    PR-URL: nodejs#37293
    Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
    Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
    Reviewed-By: Richard Lau <rlau@redhat.com>
    psmarshall authored and juanarbol committed Mar 2, 2021
    Configuration menu
    Copy the full SHA
    8d3fc8d View commit details
    Browse the repository at this point in the history
  2. test: add cpu-profiler-crash test

    This test is added as it usually crashes without applying the v8 patch:
    v8/v8@beebee4
    
    PR-URL: nodejs#37293
    Refs: v8/v8@beebee4
    Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
    Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
    Reviewed-By: Richard Lau <rlau@redhat.com>
    santigimeno authored and juanarbol committed Mar 2, 2021
    Configuration menu
    Copy the full SHA
    a6eae67 View commit details
    Browse the repository at this point in the history