Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fs: improve fsPromises writeFile performance #37610

Merged
merged 2 commits into from Mar 13, 2021
Merged

fs: improve fsPromises writeFile performance #37610

merged 2 commits into from Mar 13, 2021
+78 −2

Commits on Mar 13, 2021

  1. fs: improve fsPromises writeFile performance 

    Increase the write chunk size in fsPromises writeFile
to improve performance.

PR-URL: nodejs#37610
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
    @Linkgoron @aduh95
    Linkgoron authored and aduh95 committed Mar 13, 2021
    Copy the full SHA
    e1ce7f1 View commit details
    Browse the repository at this point in the history

  2. benchmark: add benchmark for fsPromises.writeFile 

    added fs.promises.writeFile benchmark

PR-URL: nodejs#37610
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
    @Linkgoron @aduh95
    Linkgoron authored and aduh95 committed Mar 13, 2021
    Copy the full SHA
    a97f01e View commit details
    Browse the repository at this point in the history