Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

node-api: stop ref gc during environment teardown #37616

Closed
wants to merge 3 commits into from
Closed

node-api: stop ref gc during environment teardown #37616

wants to merge 3 commits into from

Commits on Mar 6, 2021

  1. add test

    @gabrielschulhof
    gabrielschulhof committed Mar 6, 2021
    Configuration menu
    Copy the full SHA
    26fed3f View commit details
    Browse the repository at this point in the history

  2. node-api: stop ref gc during environment teardown 

    A gc may happen during environment teardown. Thus, during finalization
initiated by environment teardown we must remove the V8 finalizer
before calling the Node-API finalizer.

Fixes: nodejs#37236
PR-URL: nodejs#37616
    @gabrielschulhof
    gabrielschulhof committed Mar 6, 2021
    Configuration menu
    Copy the full SHA
    8eb03c4 View commit details
    Browse the repository at this point in the history

Commits on Mar 12, 2021

  1. add requested comment

    @gabrielschulhof
    gabrielschulhof committed Mar 12, 2021
    Configuration menu
    Copy the full SHA
    4c2131c View commit details
    Browse the repository at this point in the history