Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: document that module.evaluate fulfills as undefined #37663

Closed
wants to merge 1 commit into from
Closed

doc: document that module.evaluate fulfills as undefined #37663

wants to merge 1 commit into from

Conversation

jasnell
Copy link
Member

@jasnell jasnell commented Mar 9, 2021

Fixes: #37453
Signed-off-by: James M Snell jasnell@gmail.com

@jasnell
doc: document that module.evaluate fulfills as undefined
8f8d47f 
Fixes: nodejs#37453
Signed-off-by: James M Snell <jasnell@gmail.com>
@nodejs-github-bot nodejs-github-bot added doc Issues and PRs related to the documentations. vm Issues and PRs related to the vm subsystem. labels Mar 9, 2021
@jasnell jasnell added the fast-track PRs that do not need to wait for 48 hours to land. label Mar 9, 2021
@jasnell
Copy link
Member Author

jasnell commented Mar 9, 2021 •
edited

fast-track? please 👍🏻

@jasnell
Copy link
Member Author

jasnell commented Mar 9, 2021

Landed in 16151be

@jasnell jasnell closed this Mar 9, 2021
jasnell added a commit that referenced this pull request Mar 9, 2021
@jasnell
doc: document that module.evaluate fulfills as undefined
16151be 
Fixes: #37453
Signed-off-by: James M Snell <jasnell@gmail.com>

PR-URL: #37663
Reviewed-By: Gus Caplan <me@gus.host>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
danielleadams pushed a commit that referenced this pull request Mar 16, 2021
@jasnell @danielleadams
doc: document that module.evaluate fulfills as undefined
60d8afa 
Fixes: #37453
Signed-off-by: James M Snell <jasnell@gmail.com>

PR-URL: #37663
Reviewed-By: Gus Caplan <me@gus.host>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
@danielleadams danielleadams mentioned this pull request Mar 16, 2021
Merged
targos pushed a commit that referenced this pull request May 1, 2021
@jasnell @targos
doc: document that module.evaluate fulfills as undefined
5ef2a8d 
Fixes: #37453
Signed-off-by: James M Snell <jasnell@gmail.com>

PR-URL: #37663
Reviewed-By: Gus Caplan <me@gus.host>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
@danielleadams danielleadams mentioned this pull request May 3, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@devsnek devsnek devsnek approved these changes

@marsonya marsonya marsonya approved these changes

@RaisinTen RaisinTen RaisinTen approved these changes

Assignees
No one assigned
Labels
doc Issues and PRs related to the documentations. fast-track PRs that do not need to wait for 48 hours to land. vm Issues and PRs related to the vm subsystem.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Cannot return value from a SourceTextModule to the caller
5 participants
@jasnell @devsnek @marsonya @RaisinTen @nodejs-github-bot