deps: update to cjs-module-lexer@1.1.0 #37712
Conversation
|
@nodejs/modules |
richardlau
added
lts-watch-v12.x
semver-minor
|
Wasn't there a reference the the cjs-module-lexer version in the docs somewhere that needs to be updated? |
|
@richardlau yes there is, thanks for remembering, added. |
|
Should we have a |
|
@aduh95 I'm open to any tooling here, although in theory this project shouldn't be updated too often due to the risk of compatibility divergence between Node.js versions. |
|
As v12.x is now in maintenance I think the odds of doing a Semver-Minor is quite low. Would you consider this Semver-Minor from a Node.js perspective (adding new features) or Semver-Patch (Fixing broken experience)? |
|
@MylesBorins this is broken experience if you read the changes to the lexer. It is about some babel output etc. not correctly being processed. |
|
@bmeck with that in mind I think while it was Semver-Minor for the lexer the update should be considered Semver-Patch for Node.js and we should backport and include in the next 12.x maintenance release. Thoughts folks? |
|
I think especially given #37718 it should be back ported if it isn't a feature addition. Having 14 and 12 go out of sync over this would be very strange to me. |
We want to put out #37603 in a 12.x release and that's semver-minor. There are also some (3 as of now) open semver-minor v12.x backports: https://github.com/nodejs/node/pulls?q=is%3Apr+is%3Aopen+label%3Av12.x+label%3Asemver-minor |
PR-URL: #37712 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Myles Borins <myles.borins@gmail.com> Reviewed-By: Bradley Farias <bradley.meck@gmail.com> Reviewed-By: Geoffrey Booth <webmaster@geoffreybooth.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com>
|
Landed in 10a8dc0. |
PR-URL: #37712 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Myles Borins <myles.borins@gmail.com> Reviewed-By: Bradley Farias <bradley.meck@gmail.com> Reviewed-By: Geoffrey Booth <webmaster@geoffreybooth.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com>
PR-URL: #37766 Notable changes: * crypto: * add optional callback to crypto.sign and crypto.verify (Filip Skokan) #37500 * support JWK objects in create\*Key (Filip Skokan) #37254 * deps: * update to cjs-module-lexer@1.1.0 (Guy Bedford) #37712 * switch openssl to quictls/openssl (James M Snell) #37601 * fs: * improve fsPromises writeFile performance (Nitzan Uziely) #37610 * improve fsPromises readFile performance (Nitzan Uziely) #37608 * lib: * implement AbortSignal.abort() (James M Snell) #37693 * node-api: * define version 8 (Gabriel Schulhof) #37652 * worker: * add setEnvironmentData/getEnvironmentData (James M Snell) #37486
PR-URL: #37766 Notable changes: * crypto: * add optional callback to crypto.sign and crypto.verify (Filip Skokan) #37500 * support JWK objects in create\*Key (Filip Skokan) #37254 * deps: * update to cjs-module-lexer@1.1.0 (Guy Bedford) #37712 * switch openssl to quictls/openssl (James M Snell) #37601 * fs: * improve fsPromises writeFile performance (Nitzan Uziely) #37610 * improve fsPromises readFile performance (Nitzan Uziely) #37608 * lib: * implement AbortSignal.abort() (James M Snell) #37693 * node-api: * define version 8 (Gabriel Schulhof) #37652 * worker: * add setEnvironmentData/getEnvironmentData (James M Snell) #37486
PR-URL: #37712 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Myles Borins <myles.borins@gmail.com> Reviewed-By: Bradley Farias <bradley.meck@gmail.com> Reviewed-By: Geoffrey Booth <webmaster@geoffreybooth.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com>
|
Removing |
This update includes the following new features:
This update is fully backwards compatible with 1.0.0.
Ideally we should aim to backport this change as much as possible to maximise compatibility. Hopefully to Node.js 14 at least, not sure if Node.js 12 will be possible at this point.